[PATCH v2 2/8] crypto/lzo: support decompress_noctx

2015-08-19 Thread Joonsoo Kim
lzo's decompression doesn't requires any scratch buffer so
it doesn't need tfm context. Hence, it can support
crypto compression noctx API and this patch implements it.

Signed-off-by: Joonsoo Kim 
---
 crypto/lzo.c | 18 +-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/crypto/lzo.c b/crypto/lzo.c
index 9ca516b..f1844dd 100644
--- a/crypto/lzo.c
+++ b/crypto/lzo.c
@@ -80,6 +80,22 @@ static int lzo_decompress(struct crypto_tfm *tfm, const u8 
*src,
 
 }
 
+static int lzo_decompress_noctx(const u8 *src, unsigned int slen,
+   u8 *dst, unsigned int *dlen)
+{
+   int err;
+   size_t tmp_len = *dlen; /* size_t(ulong) <-> uint on 64 bit */
+
+   err = lzo1x_decompress_safe(src, slen, dst, &tmp_len);
+
+   if (err != LZO_E_OK)
+   return -EINVAL;
+
+   *dlen = tmp_len;
+   return 0;
+
+}
+
 static struct crypto_alg alg = {
.cra_name   = "lzo",
.cra_flags  = CRYPTO_ALG_TYPE_COMPRESS,
@@ -91,7 +107,7 @@ static struct crypto_alg alg = {
.coa_compress   = lzo_compress,
.coa_decompress = lzo_decompress,
.coa_compress_noctx = NULL,
-   .coa_decompress_noctx   = NULL } }
+   .coa_decompress_noctx   = lzo_decompress_noctx } }
 };
 
 static int __init lzo_mod_init(void)
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v2 2/8] crypto/lzo: support decompress_noctx

2015-08-26 Thread Sergey Senozhatsky
On (08/20/15 15:34), Joonsoo Kim wrote:
> lzo's decompression doesn't requires any scratch buffer so
> it doesn't need tfm context. Hence, it can support
> crypto compression noctx API and this patch implements it.
> 
> Signed-off-by: Joonsoo Kim 
> ---
>  crypto/lzo.c | 18 +-
>  1 file changed, 17 insertions(+), 1 deletion(-)
> 
> diff --git a/crypto/lzo.c b/crypto/lzo.c
> index 9ca516b..f1844dd 100644
> --- a/crypto/lzo.c
> +++ b/crypto/lzo.c
> @@ -80,6 +80,22 @@ static int lzo_decompress(struct crypto_tfm *tfm, const u8 
> *src,
>  
>  }
>  
> +static int lzo_decompress_noctx(const u8 *src, unsigned int slen,
> + u8 *dst, unsigned int *dlen)
> +{
> + int err;
> + size_t tmp_len = *dlen; /* size_t(ulong) <-> uint on 64 bit */
> +
> + err = lzo1x_decompress_safe(src, slen, dst, &tmp_len);
> +
> + if (err != LZO_E_OK)
> + return -EINVAL;
> +
> + *dlen = tmp_len;
> + return 0;
> +

just do

static int lzo_decompress_noctx(const u8 *src, unsigned int slen,
u8 *dst, unsigned int *dlen)
{
return lzo_decompress(NULL, src, len, dst, dlen);
}

?

-ss

> +}
> +
>  static struct crypto_alg alg = {
>   .cra_name   = "lzo",
>   .cra_flags  = CRYPTO_ALG_TYPE_COMPRESS,
> @@ -91,7 +107,7 @@ static struct crypto_alg alg = {
>   .coa_compress   = lzo_compress,
>   .coa_decompress = lzo_decompress,
>   .coa_compress_noctx = NULL,
> - .coa_decompress_noctx   = NULL } }
> + .coa_decompress_noctx   = lzo_decompress_noctx } }
>  };
>  
>  static int __init lzo_mod_init(void)
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html