Re: [PATCH v2 3/4] ARM: dts: rockchip: Add Crypto drivers for rk3288

2015-11-06 Thread Heiko Stuebner 
Am Freitag, 6. November 2015, 09:17:23 schrieb Zain Wang:
> Add Crypto drivers for rk3288 including crypto controller and dma clk.
> 
> Signed-off-by: Zain Wang 
> ---
> 
> Changed in v2:
> - None
> 
> Changed in v1:
> - remove the _crypto suffix
> - use "rockchip,rk3288-crypto" instead of "rockchip,rk3288"
> 
>  arch/arm/boot/dts/rk3288.dtsi | 15 +++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index 6a79c9c..7b7914e 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -170,6 +170,21 @@
>   };
>   };
>  
> + crypto: cypto-controller@ff8a {
> + compatible = "rockchip,rk3288-crypto";
> + reg = <0xff8a 0x4000>;
> + interrupts = ;
> + clocks = < ACLK_CRYPTO>,
> +  < HCLK_CRYPTO>,
> +  < SCLK_CRYPTO>,
> +  < ACLK_DMAC1>;
> + clock-names = "aclk",
> +   "hclk",
> +   "sclk",
> +   "apb_pclk";
> + status = "okay";
> + };
> +

please move that whole node to the right location. Entries are sorted by 
register address (the ff8a should then of course be below  i2s@ff89 
and above vop@ff93)


>   reserved-memory {
>   #address-cells = <1>;
>   #size-cells = <1>;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 3/4] ARM: dts: rockchip: Add Crypto drivers for rk3288

2015-11-06 Thread Zain 


On 2015年11月06日 18:12, Heiko Stuebner wrote:
> Am Freitag, 6. November 2015, 09:17:23 schrieb Zain Wang:
>> Add Crypto drivers for rk3288 including crypto controller and dma clk.
>>
>> Signed-off-by: Zain Wang 
>> ---
>>
>> Changed in v2:
>> - None
>>
>> Changed in v1:
>> - remove the _crypto suffix
>> - use "rockchip,rk3288-crypto" instead of "rockchip,rk3288"
>>
>>  arch/arm/boot/dts/rk3288.dtsi | 15 +++
>>  1 file changed, 15 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
>> index 6a79c9c..7b7914e 100644
>> --- a/arch/arm/boot/dts/rk3288.dtsi
>> +++ b/arch/arm/boot/dts/rk3288.dtsi
>> @@ -170,6 +170,21 @@
>>  };
>>  };
>>  
>> +crypto: cypto-controller@ff8a {
>> +compatible = "rockchip,rk3288-crypto";
>> +reg = <0xff8a 0x4000>;
>> +interrupts = ;
>> +clocks = < ACLK_CRYPTO>,
>> + < HCLK_CRYPTO>,
>> + < SCLK_CRYPTO>,
>> + < ACLK_DMAC1>;
>> +clock-names = "aclk",
>> +  "hclk",
>> +  "sclk",
>> +  "apb_pclk";
>> +status = "okay";
>> +};
>> +
> please move that whole node to the right location. Entries are sorted by 
> register address (the ff8a should then of course be below  i2s@ff89 
> and above vop@ff93)
ok! done!
>
>
>>  reserved-memory {
>>  #address-cells = <1>;
>>  #size-cells = <1>;
>>
>
>
>


--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 3/4] ARM: dts: rockchip: Add Crypto drivers for rk3288

2015-11-06 Thread Zain 
Hi:

On 2015年11月06日 10:00, Caesar Wang wrote:
> the subject should be add the node/info for crypto...
ok! done!
>
> 在 2015年11月06日 09:17, Zain Wang 写道:
>> Add Crypto drivers for rk3288 including crypto controller and dma clk.
>>
>> Signed-off-by: Zain Wang 
>> ---
>>
>> Changed in v2:
>> - None
>>
>> Changed in v1:
>> - remove the _crypto suffix
>> - use "rockchip,rk3288-crypto" instead of "rockchip,rk3288"
>>
>>   arch/arm/boot/dts/rk3288.dtsi | 15 +++
>>   1 file changed, 15 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rk3288.dtsi
>> b/arch/arm/boot/dts/rk3288.dtsi
>> index 6a79c9c..7b7914e 100644
>> --- a/arch/arm/boot/dts/rk3288.dtsi
>> +++ b/arch/arm/boot/dts/rk3288.dtsi
>> @@ -170,6 +170,21 @@
>>   };
>>   };
>>   +crypto: cypto-controller@ff8a {
>> +compatible = "rockchip,rk3288-crypto";
>> +reg = <0xff8a 0x4000>;
>> +interrupts = ;
>> +clocks = < ACLK_CRYPTO>,
>> + < HCLK_CRYPTO>,
>> + < SCLK_CRYPTO>,
>> + < ACLK_DMAC1>;
>> +clock-names = "aclk",
>> +  "hclk",
>> +  "sclk",
>> +  "apb_pclk";
>
> I guess  you can do this:
>
> clocks = < ACLK_CRYPTO>, < HCLK_CRYPTO>,  < SCLK_CRYPTO>, 
> < ACLK_DMAC1>;
>
> clock-names = "aclk", "hclk",  "sclk", "apb_pclk";
ok! done!
>
>
>> +status = "okay";
>> +};
>> +
>>   reserved-memory {
>>   #address-cells = <1>;
>>   #size-cells = <1>;
>
>


--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 3/4] ARM: dts: rockchip: Add Crypto drivers for rk3288

2015-11-05 Thread Zain Wang 
Add Crypto drivers for rk3288 including crypto controller and dma clk.

Signed-off-by: Zain Wang 
---

Changed in v2:
- None

Changed in v1:
- remove the _crypto suffix
- use "rockchip,rk3288-crypto" instead of "rockchip,rk3288"

 arch/arm/boot/dts/rk3288.dtsi | 15 +++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index 6a79c9c..7b7914e 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -170,6 +170,21 @@
};
};
 
+   crypto: cypto-controller@ff8a {
+   compatible = "rockchip,rk3288-crypto";
+   reg = <0xff8a 0x4000>;
+   interrupts = ;
+   clocks = < ACLK_CRYPTO>,
+< HCLK_CRYPTO>,
+< SCLK_CRYPTO>,
+< ACLK_DMAC1>;
+   clock-names = "aclk",
+ "hclk",
+ "sclk",
+ "apb_pclk";
+   status = "okay";
+   };
+
reserved-memory {
#address-cells = <1>;
#size-cells = <1>;
-- 
1.9.1


--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 3/4] ARM: dts: rockchip: Add Crypto drivers for rk3288

2015-11-05 Thread Caesar Wang 

the subject should be add the node/info for crypto...

在 2015年11月06日 09:17, Zain Wang 写道:

Add Crypto drivers for rk3288 including crypto controller and dma clk.

Signed-off-by: Zain Wang 
---

Changed in v2:
- None

Changed in v1:
- remove the _crypto suffix
- use "rockchip,rk3288-crypto" instead of "rockchip,rk3288"

  arch/arm/boot/dts/rk3288.dtsi | 15 +++
  1 file changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index 6a79c9c..7b7914e 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -170,6 +170,21 @@
};
};
  
+	crypto: cypto-controller@ff8a {

+   compatible = "rockchip,rk3288-crypto";
+   reg = <0xff8a 0x4000>;
+   interrupts = ;
+   clocks = < ACLK_CRYPTO>,
+< HCLK_CRYPTO>,
+< SCLK_CRYPTO>,
+< ACLK_DMAC1>;
+   clock-names = "aclk",
+ "hclk",
+ "sclk",
+ "apb_pclk";


I guess  you can do this:

clocks = < ACLK_CRYPTO>, < HCLK_CRYPTO>,  < SCLK_CRYPTO>,  < 
ACLK_DMAC1>;

clock-names = "aclk", "hclk",  "sclk", "apb_pclk";



+   status = "okay";
+   };
+
reserved-memory {
#address-cells = <1>;
#size-cells = <1>;



--
Thanks,
Caesar

--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html