Re: [v3 PATCH 0/8] crypto: Convert all AEAD users to new interface
On Wed, May 27, 2015 at 05:29:22PM +0800, Herbert Xu wrote: > On Wed, May 27, 2015 at 11:25:33AM +0200, Steffen Klassert wrote: > > > > Not sure if I missed something in the flood of patches, but if I > > apply your v3 patchset on top of the cryptodev tree, it crashes > > like that buring boot: > > Sorry, I forgot to mention that v3 depends on the series of fixes > posted just before it (but only to linux-crypto): > > https://www.mail-archive.com/linux-crypto@vger.kernel.org/msg14487.html > OK, I'll try with this. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [v3 PATCH 0/8] crypto: Convert all AEAD users to new interface
On Wed, May 27, 2015 at 11:25:33AM +0200, Steffen Klassert wrote: > > Not sure if I missed something in the flood of patches, but if I > apply your v3 patchset on top of the cryptodev tree, it crashes > like that buring boot: Sorry, I forgot to mention that v3 depends on the series of fixes posted just before it (but only to linux-crypto): https://www.mail-archive.com/linux-crypto@vger.kernel.org/msg14487.html Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [v3 PATCH 0/8] crypto: Convert all AEAD users to new interface
On Wed, May 27, 2015 at 04:01:05PM +0800, Herbert Xu wrote: > Hi: > > The only changes from the last version are that set_ad no longer > takes a cryptoff argument and testmgr has been updated to always > supply space for the authentication tag. > > The algif_aead patch has been removed and will be posted separately. > > Series description: > > This series of patches convert all in-tree AEAD users that I > could find to the new single SG list interface. For IPsec it > also adopts the new explicit IV generator scheme. > > To recap, the old AEAD interface takes an associated data (AD) > SG list in addition to the plain/cipher text SG list(s). That > forces the underlying AEAD algorithm implementors to try to stitch > those two lists together where possible in order to maximise the > contiguous chunk of memory passed to the ICV/hash function. Things > get even more hairy for IPsec as it has a third piece of memory, > the generated IV (giv) that needs to be hashed. One look at the > nasty things authenc does for example is enough to make anyone > puke :) > > In fact the interface is just getting in our way because for the > main user IPsec the data is naturally contiguous as the protocol > was designed with this in mind. > > So the new AEAD interface gets rid of the separate AD SG list > and instead simply requires the AD to be at the head of the src > and dst SG lists. > > The conversion of in-tree users is fairly straightforward. The > only non-trivial bit is IPsec as I'm taking this opportunity to > move the IV generation knowledge into IPsec as that's where it > belongs since we may in future wish to support different generation > schemes for a single algorithm. Not sure if I missed something in the flood of patches, but if I apply your v3 patchset on top of the cryptodev tree, it crashes like that buring boot: [4.668297] [ cut here ] [4.669143] kernel BUG at /home/klassert/git/linux-stk/include/linux/scatterlist.h:67! [4.670457] invalid opcode: [#1] SMP DEBUG_PAGEALLOC [4.671595] CPU: 0 PID: 1363 Comm: cryptomgr_test Not tainted 4.0.0+ #951 [4.672025] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 [4.672025] task: ce9e7300 ti: ceb54000 task.ti: ceb54000 [4.672025] EIP: 0060:[] EFLAGS: 00010206 CPU: 0 [4.672025] EIP is at scatterwalk_ffwd+0xf5/0x100 [4.672025] EAX: ceb43b20 EBX: ceb55c94 ECX: 0014 EDX: c11db23f [4.672025] ESI: 0010 EDI: 0003 EBP: ceb55c7c ESP: ceb55c6c [4.672025] DS: 007b ES: 007b FS: 00d8 GS: SS: 0068 [4.672025] CR0: 8005003b CR2: bfbb6fc0 CR3: 0eb26000 CR4: 06d0 [4.672025] Stack: [4.672025] cffd28c0 0014 ceb35400 cea33618 ceb55cd0 c11d45e8 ceb43b20 [4.672025] ceb35438 c11db220 ceb55c9c c11db23f ceb55cac c11da470 ceb35438 ceb353c8 [4.672025] ceb55cb4 c11da763 ceb55cd0 c11f2c6f ceb35400 0200 ceb35358 ceb353c8 [4.672025] Call Trace: [4.672025] [] scatterwalk_map_and_copy+0x28/0xc0 [4.672025] [] ? shash_ahash_finup+0x80/0x80 [4.672025] [] ? shash_async_finup+0x1f/0x30 [4.672025] [] ? crypto_ahash_op+0x20/0x50 [4.672025] [] ? crypto_ahash_finup+0x13/0x20 [4.672025] [] ? crypto_authenc_ahash_fb+0xaf/0xd0 [4.672025] [] crypto_authenc_genicv+0xfc/0x340 [4.672025] [] crypto_authenc_encrypt+0x96/0xb0 [4.672025] [] ? crypto_authenc_decrypt+0x3e0/0x3e0 [4.672025] [] old_crypt+0xa7/0xc0 [4.672025] [] old_encrypt+0x19/0x20 [4.672025] [] __test_aead+0x268/0x1580 [4.672025] [] ? __crypto_alloc_tfm+0x37/0x120 [4.672025] [] ? __crypto_alloc_tfm+0x37/0x120 [4.672025] [] ? skcipher_geniv_init+0x22/0x40 [4.672025] [] ? eseqiv_init+0x43/0x50 [4.672025] [] ? __crypto_alloc_tfm+0xc6/0x120 [4.672025] [] test_aead+0x31/0xc0 [4.672025] [] alg_test_aead+0x43/0xa0 [4.672025] [] ? alg_find_test+0x2e/0x70 [4.672025] [] alg_test+0xa2/0x240 [4.672025] [] ? finish_task_switch+0x83/0xe0 [4.672025] [] ? __schedule+0x412/0x1067 [4.672025] [] ? __wake_up_common+0x47/0x70 [4.672025] [] ? cryptomgr_notify+0x450/0x450 [4.672025] [] cryptomgr_test+0x3f/0x50 [4.672025] [] kthread+0xab/0xc0 [4.672025] [] ret_from_kernel_thread+0x21/0x30 [4.672025] [] ? __kthread_parkme+0x80/0x80 [4.672025] Code: 83 c4 04 5b 5e 5f 5d c3 81 3b 21 43 65 87 75 13 8b 43 04 83 e0 fe 83 c8 02 89 43 04 89 d8 e9 4d ff ff ff 0f 0b 0f 0b 0f 0b 0f 0b <0f> 0b 0f 0b 8d b4 26 00 00 00 00 55 89 e5 57 56 53 83 ec 40 3e [4.672025] EIP: [] scatterwalk_ffwd+0xf5/0x100 SS:ESP 0068:ceb55c6c [4.721562] ---[ end trace 94a02f0816fe7c7f ]--- -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [v3 PATCH 0/8] crypto: Convert all AEAD users to new interface
On Wed, 2015-05-27 at 17:07 +0800, Herbert Xu wrote: > On Wed, May 27, 2015 at 11:00:40AM +0200, Johannes Berg wrote: > > > > Right. Unfortunately, I can't typically rely on being able to make > > changes to the kernel our driver is built against, and I don't think we > > could do these changes otherwise. > > You could provide your own version of crypto_aead_encrypt and > crypto_aead_decrypt that did the same thing as old_crypt. Ah, good point, thanks. I'll look into it once these changes hit my tree :) johannes -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [v3 PATCH 0/8] crypto: Convert all AEAD users to new interface
On Wed, May 27, 2015 at 11:00:40AM +0200, Johannes Berg wrote: > > Right. Unfortunately, I can't typically rely on being able to make > changes to the kernel our driver is built against, and I don't think we > could do these changes otherwise. You could provide your own version of crypto_aead_encrypt and crypto_aead_decrypt that did the same thing as old_crypt. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [v3 PATCH 0/8] crypto: Convert all AEAD users to new interface
On Wed, 2015-05-27 at 16:39 +0800, Herbert Xu wrote: > On Wed, May 27, 2015 at 10:15:50AM +0200, Johannes Berg wrote: > > > > Do you think it'd be feasible at all to somehow override the > > aead_request_set_crypt() and aead_request_set_ad() functions or so to do > > something that works on older kernels (and thus older crypto subsystems) > > or do you think I just shouldn't bother looking at that and just add > > ifdefs to "undo" your changes in this series on older kernels? > > Another option is to backport the new interface to the older kernel. > > You only need something like > > https://patchwork.kernel.org/patch/6452601/ > > for the older kernel to support the new interface along with the > old interface. Right. Unfortunately, I can't typically rely on being able to make changes to the kernel our driver is built against, and I don't think we could do these changes otherwise. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [v3 PATCH 0/8] crypto: Convert all AEAD users to new interface
On Wed, May 27, 2015 at 10:15:50AM +0200, Johannes Berg wrote: > > Do you think it'd be feasible at all to somehow override the > aead_request_set_crypt() and aead_request_set_ad() functions or so to do > something that works on older kernels (and thus older crypto subsystems) > or do you think I just shouldn't bother looking at that and just add > ifdefs to "undo" your changes in this series on older kernels? Another option is to backport the new interface to the older kernel. You only need something like https://patchwork.kernel.org/patch/6452601/ for the older kernel to support the new interface along with the old interface. Note that this patch itself won't be good enough because I have since removed cryptoff. But it illustrates the amount of code you need. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [v3 PATCH 0/8] crypto: Convert all AEAD users to new interface
> The conversion of in-tree users is fairly straightforward. It is pretty much - but a related question (that you totally don't have to answer if you don't want to think about this). I'm going to have to (continue) backport(ing) this code to older kernels for customer support, and I prefer making as few modifications to the code as possible and putting all the logic into the external backports project. Do you think it'd be feasible at all to somehow override the aead_request_set_crypt() and aead_request_set_ad() functions or so to do something that works on older kernels (and thus older crypto subsystems) or do you think I just shouldn't bother looking at that and just add ifdefs to "undo" your changes in this series on older kernels? johannes -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[v3 PATCH 0/8] crypto: Convert all AEAD users to new interface
Hi: The only changes from the last version are that set_ad no longer takes a cryptoff argument and testmgr has been updated to always supply space for the authentication tag. The algif_aead patch has been removed and will be posted separately. Series description: This series of patches convert all in-tree AEAD users that I could find to the new single SG list interface. For IPsec it also adopts the new explicit IV generator scheme. To recap, the old AEAD interface takes an associated data (AD) SG list in addition to the plain/cipher text SG list(s). That forces the underlying AEAD algorithm implementors to try to stitch those two lists together where possible in order to maximise the contiguous chunk of memory passed to the ICV/hash function. Things get even more hairy for IPsec as it has a third piece of memory, the generated IV (giv) that needs to be hashed. One look at the nasty things authenc does for example is enough to make anyone puke :) In fact the interface is just getting in our way because for the main user IPsec the data is naturally contiguous as the protocol was designed with this in mind. So the new AEAD interface gets rid of the separate AD SG list and instead simply requires the AD to be at the head of the src and dst SG lists. The conversion of in-tree users is fairly straightforward. The only non-trivial bit is IPsec as I'm taking this opportunity to move the IV generation knowledge into IPsec as that's where it belongs since we may in future wish to support different generation schemes for a single algorithm. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
