Re: [PATCH] crypto: AF_ALG: handle 0 lengths in af_alg_make_sg

[Stephan Müller]

Am Mittwoch, 5. April 2017, 14:50:12 CEST schrieb Herbert Xu:

Hi Herbert,

> So this is only possible with patches that have not been applied
> yet?

Correct.

> In that case please fold this into whichever patch series
> that needs it.

Ok, let us defer it.

Ciao
Stephan

Re: [PATCH] crypto: AF_ALG: handle 0 lengths in af_alg_make_sg

[Herbert Xu]

On Sat, Apr 01, 2017 at 07:46:39PM +0200, Stephan Müller wrote:
> Am Samstag, 1. April 2017, 17:04:28 CEST schrieb Stephan Müller:
> 
> Hi Herbert,
> 
> > Hi Herbert,
> > 
> > If you concur with the patch, I think it should go to 4.11 as well as
> > to stable.
> 
> After checking this issue again, I see that it is not triggerable in the 
> current code as the different af_alg users make sure that this function is 
> not 
> called with 0.
> 
> I only triggered this issue during experimenting with the algif_skcipher and 
> algif_aead revamp as requested by you. During those experiments, I invoked 
> af_alg_make_sg with a len = 0.
> 
> Thus, this patch is not applicable for stable and 4.11.
> 
> Yet, I would suggest to consider this patch as a safeguard for any potential 
> programming errors.

So this is only possible with patches that have not been applied
yet? In that case please fold this into whichever patch series
that needs it.

Thanks,
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt