Re: [PATCH] crypto: jitterentropy - avoid compiler warnings
On Tue, Jun 23, 2015 at 04:18:54PM +0200, Stephan Mueller wrote: > Hi Geert, Guenter, > > may I ask that you check that the following patch compiles without errors or > warnings on your systems? > Stephan, I applied your patch on top of the current mainline (which includes the crypto updates for 4.2) and pushed it into my 'testing' branch. You should be able to see the results in a couple of hours at http://server.roeck-us.net:8010/builders, in the 'testing' column. The build system doesn't log warnings, but this should give us an idea if the build passes for all architectures. I'll have a look myself later and let you know as well. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] crypto: jitterentropy - avoid compiler warnings
Am Dienstag, 23. Juni 2015, 08:31:10 schrieb Guenter Roeck: Hi Guenter, >On Tue, Jun 23, 2015 at 04:18:54PM +0200, Stephan Mueller wrote: >> Hi Geert, Guenter, >> >> may I ask that you check that the following patch compiles without errors >> or warnings on your systems? >Stephan, > >I applied your patch on top of the current mainline (which includes >the crypto updates for 4.2) and pushed it into my 'testing' branch. >You should be able to see the results in a couple of hours at >http://server.roeck-us.net:8010/builders, in the 'testing' column. > >The build system doesn't log warnings, but this should give us an idea >if the build passes for all architectures. > >I'll have a look myself later and let you know as well. Thank you very much! Ciao Stephan -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] crypto: jitterentropy - avoid compiler warnings
On Tue, Jun 23, 2015 at 04:18:54PM +0200, Stephan Mueller wrote: > Hi Geert, Guenter, > > may I ask that you check that the following patch compiles without errors or > warnings on your systems? > No build failures for all architectures. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] crypto: jitterentropy - avoid compiler warnings
Am Dienstag, 23. Juni 2015, 10:41:03 schrieb Guenter Roeck: Hi Guenter, Geert, >On Tue, Jun 23, 2015 at 04:18:54PM +0200, Stephan Mueller wrote: >> Hi Geert, Guenter, >> >> may I ask that you check that the following patch compiles without errors >> or warnings on your systems? >No build failures for all architectures. Thank you very much for your help. Now, if Geert would be so kind and have a check on his OpenRISC to ensure that there are no compiler warnings, I would be happy. Though, does anybody have any idea what the AVR32 compiler warning about crypto/builtin.o not being relaxable mean and whether that is an issue? Note, when I was compiling AVR32, I saw some of these warnings for other builtin.o too. Ciao Stephan -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] crypto: jitterentropy - avoid compiler warnings
Hi Stephan,
On Tue, Jun 23, 2015 at 4:18 PM, Stephan Mueller wrote:
> may I ask that you check that the following patch compiles without errors or
> warnings on your systems?
>
> Though, when I test that patch with the AVR32 cross compiler, I get a warning
> about the code being not relaxable.
>
> Thank you very much.
>
> ---8<---
> The core of the Jitter RNG is intended to be compiled with -O0. To
> ensure that the Jitter RNG can be compiled on all architectures,
> separate out the RNG core into a stand-alone C file that can be compiled
> with -O0 which does not depend on any kernel include file.
>
> As no kernel includes can be used in the C file implementing the core
> RNG, any dependencies on kernel code must be extracted.
>
> A second file provides the link to the kernel and the kernel crypto API
> that can be compiled with the regular compile options of the kernel.
>
> Signed-off-by: Stephan Mueller
Thanks, the warnings I saw before with m68k-linux-gnu-gcc-4.1.2
are gone.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] crypto: jitterentropy - avoid compiler warnings
On 06/23/2015 10:55 AM, Stephan Mueller wrote: Am Dienstag, 23. Juni 2015, 10:41:03 schrieb Guenter Roeck: Hi Guenter, Geert, On Tue, Jun 23, 2015 at 04:18:54PM +0200, Stephan Mueller wrote: Hi Geert, Guenter, may I ask that you check that the following patch compiles without errors or warnings on your systems? No build failures for all architectures. Thank you very much for your help. Now, if Geert would be so kind and have a check on his OpenRISC to ensure that there are no compiler warnings, I would be happy. Though, does anybody have any idea what the AVR32 compiler warning about crypto/builtin.o not being relaxable mean and whether that is an issue? Note, when I was compiling AVR32, I saw some of these warnings for other builtin.o too. At least it compiles ;-). I don't think there is anything else we can do. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] crypto: jitterentropy - avoid compiler warnings
On Tue, Jun 23, 2015 at 04:18:54PM +0200, Stephan Mueller wrote: > Hi Geert, Guenter, > > may I ask that you check that the following patch compiles without errors or > warnings on your systems? > > Though, when I test that patch with the AVR32 cross compiler, I get a warning > about the code being not relaxable. > > Thank you very much. > > ---8<--- > The core of the Jitter RNG is intended to be compiled with -O0. To > ensure that the Jitter RNG can be compiled on all architectures, > separate out the RNG core into a stand-alone C file that can be compiled > with -O0 which does not depend on any kernel include file. > > As no kernel includes can be used in the C file implementing the core > RNG, any dependencies on kernel code must be extracted. > > A second file provides the link to the kernel and the kernel crypto API > that can be compiled with the regular compile options of the kernel. > > Signed-off-by: Stephan Mueller Applied. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
