Re: [PATCH 1/2 v2] crypto: Key-agreement Protocol Primitives API (KPP)
On Tue, Apr 26, 2016 at 10:27:25AM +0900, Marcel Holtmann wrote: > > actually if we have support for ECDH P-256, then Bluetooth could be converted > easily and we get an internal user of this API. Great, then I would like to see the KPP patch come with an implementation for that algorithm and a conversion patch for bluetooth so that they can be reviewed together. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2 v2] crypto: Key-agreement Protocol Primitives API (KPP)
Hi Herbert, >> Add key-agreement protocol primitives (kpp) API which allows to >> implement primitives required by protocols such as DH and ECDH. >> The API is composed mainly by the following functions >> * set_params() - It allows the user to set the parameters known to >> both parties involved in the key-agreement session >> * set_secret() - It allows the user to set his secret, also >> referred to as his private key >> * generate_public_key() - It generates the public key to be sent to >> the other counterpart involved in the key-agreement session. The >> function has to be called after set_params() and set_secret() >> * generate_secret() - It generates the shared secret for the session >> >> Other functions such as init() and exit() are provided for allowing >> cryptographic hardware to be inizialized properly before use >> >> Signed-off-by: Salvatore Benedetto > > I don't have any strong objections to this interface. > > However, I'd like to see it along with an actual user. Because > otherwise I'm afraid that I'll soon start receiving patches adding > drivers using this interface even before we settle on what the > user interface looks like. And what the user interface looks > like is very important because it may impact how we structure > this. actually if we have support for ECDH P-256, then Bluetooth could be converted easily and we get an internal user of this API. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2 v2] crypto: Key-agreement Protocol Primitives API (KPP)
On Fri, Apr 15, 2016 at 10:25:15AM +0100, Salvatore Benedetto wrote: > Add key-agreement protocol primitives (kpp) API which allows to > implement primitives required by protocols such as DH and ECDH. > The API is composed mainly by the following functions > * set_params() - It allows the user to set the parameters known to >both parties involved in the key-agreement session > * set_secret() - It allows the user to set his secret, also >referred to as his private key > * generate_public_key() - It generates the public key to be sent to >the other counterpart involved in the key-agreement session. The >function has to be called after set_params() and set_secret() > * generate_secret() - It generates the shared secret for the session > > Other functions such as init() and exit() are provided for allowing > cryptographic hardware to be inizialized properly before use > > Signed-off-by: Salvatore Benedetto I don't have any strong objections to this interface. However, I'd like to see it along with an actual user. Because otherwise I'm afraid that I'll soon start receiving patches adding drivers using this interface even before we settle on what the user interface looks like. And what the user interface looks like is very important because it may impact how we structure this. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
