Re: [PATCH 1/5] crypto: talitos - add hmac algorithms
On Thu, Nov 17, 2011 at 12:19:16AM +, Kim Phillips wrote: From: Lee Nipper lee.nip...@gmail.com Add these hmac algorithms to talitos: All patches applied. Thanks! -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/5] crypto: talitos - add hmac algorithms
On Wed, Nov 16, 2011 at 6:19 PM, Kim Phillips kim.phill...@freescale.com wrote: From: Lee Nipper lee.nip...@gmail.com Add these hmac algorithms to talitos: hmac(md5), hmac(sha1), hmac(sha224), hmac(sha256), hmac(sha384), hmac(sha512). These are all type ahash. Signed-off-by: Lee Nipper lee.nip...@gmail.com Fixed up to not register HMAC algorithms on sec2.0 devices. Rationale (from Lee): on an 8349E Rev1.1, there's a problem with hmac for any talitos hmac sequence requiring an intermediate hash context (Pointer DWORD 1); the result is an incorrect hmac. An intermediate hash context is required for something longer than (65536-blocksize), and for other cases when update/finup/final are used inefficiently. Interestingly, a normal hash (without hmac) works perfectly when using an intermediate context. Signed-off-by: Kim Phillips kim.phill...@freescale.com Thanks Kim for re-submitting this patch, and the fix for avoiding sec2.0 problem. Since I don't have sec2.1+ h/w, I won't be able to hammer test it. :( Does AH IPsec now function with talitos hmac with this patch ? Cheers, Lee -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/5] crypto: talitos - add hmac algorithms
On Thu, 17 Nov 2011 09:01:16 -0600 Lee Nipper lee.nip...@gmail.com wrote: Thanks Kim for re-submitting this patch, and the fix for avoiding sec2.0 problem. thanks for the code - sorry it took so long - the AH fix below was a good motivator. Since I don't have sec2.1+ h/w, I won't be able to hammer test it. :( truth be told, I only tested with the alg. registration time tests myself ;) Does AH IPsec now function with talitos hmac with this patch ? once these: http://git.kernel.org/?p=linux/kernel/git/davem/net.git;a=commitdiff;h=b7ea81a58adc123a4e980cb0eff9eb5c144b5dc7 http://git.kernel.org/?p=linux/kernel/git/davem/net.git;a=commitdiff;h=069294e813ed5f27f82613b027609bcda5f1b914 go in, I'm sure it will :) Kim -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
