Re: [PATCH 3/7] crypto/testmgr: add testing for arc4 based on ecb(arc4)
* Herbert Xu | 2010-04-07 17:29:07 [+0800]: Sebastian, how about precomputing the IV and provide them directly as a hex array? To test arc4_setup_iv itself, you can add an alg_test_arc4 function (like alg_test_crc32) that tests IV generation specifically. Alternatively, just add an alg_test_arc4 that computes the IV before calling alg_test_skcipher. I take a look at this. Cheers, Sebastian -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/7] crypto/testmgr: add testing for arc4 based on ecb(arc4)
On Sat, 2010-04-03 at 09:49 +0200, Sebastian Andrzej Siewior wrote: + if (mode == CRYPT_ARC4) + arc4_setup_iv((struct arc4_iv *)iv, + template[i].key, template[i].klen); + else + ret = crypto_ablkcipher_setkey(tfm, template[i].key, template[i].klen); Can we avoid those special cases? If the goal is to make arc4 compliant with the crypto API, this looks like a step in a wrong direction. The same applies to many other changes in the series. I do realize that the original arc4 is not a block cipher at all. -- Regards, Pavel Roskin -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/7] crypto/testmgr: add testing for arc4 based on ecb(arc4)
On Wed, Apr 07, 2010 at 02:29:53AM -0400, Pavel Roskin wrote:
Can we avoid those special cases? If the goal is to make arc4
compliant with the crypto API, this looks like a step in a wrong
direction.
The same applies to many other changes in the series.
I do realize that the original arc4 is not a block cipher at all.
I don't like this bit either.
Sebastian, how about precomputing the IV and provide them directly
as a hex array?
To test arc4_setup_iv itself, you can add an alg_test_arc4 function
(like alg_test_crc32) that tests IV generation specifically.
Alternatively, just add an alg_test_arc4 that computes the IV
before calling alg_test_skcipher.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
