Re: [PATCH v2.2 1/7] crypto: GnuPG based MPI lib - source files (part 1)
Hi Dmitry, On Mon, 21 Nov 2011 17:32:54 +0200 "Kasatkin, Dmitry" wrote: > > In fact it does not break bisect, because compilation is enabled in > the 3rd patch. Ah. sorry, I missed that. -- Cheers, Stephen Rothwells...@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ pgp4yIPO6WWQb.pgp Description: PGP signature
Re: [PATCH v2.2 1/7] crypto: GnuPG based MPI lib - source files (part 1)
On Mon, Nov 21, 2011 at 1:27 PM, James Morris wrote: > On Mon, 21 Nov 2011, Kasatkin, Dmitry wrote: > >> It can be easily split into 2 commits and one of them would not comply >> with mailing list limits. >> >> James, should I do anything about it? > > No, it's in my public tree now. > Ok. In fact it does not break bisect, because compilation is enabled in the 3rd patch. BR, Dmitry > > - James > -- > James Morris > > -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2.2 1/7] crypto: GnuPG based MPI lib - source files (part 1)
On Mon, 21 Nov 2011, Kasatkin, Dmitry wrote: > It can be easily split into 2 commits and one of them would not comply > with mailing list limits. > > James, should I do anything about it? No, it's in my public tree now. - James -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2.2 1/7] crypto: GnuPG based MPI lib - source files (part 1)
On Sat, Nov 19, 2011 at 5:33 AM, Stephen Rothwell wrote: > Hi all, > > On Wed, 19 Oct 2011 14:51:30 +0300 Dmitry Kasatkin > wrote: >> >> Adds the multi-precision-integer maths library which was originally taken >> from GnuPG and ported to the kernel by (among others) David Howells. >> This version is taken from Fedora kernel 2.6.32-71.14.1.el6. >> The difference is that checkpatch reported errors and warnings have been >> fixed. >> >> This library is used to implemenet RSA digital signature verification >> used in IMA/EVM integrity protection subsystem. >> >> Due to patch size limitation, the patch is divided into 4 parts. > > I just noticed that this has been added to the "next" branch of the > security tree (and thus into the next release of linux-next). I think > that these patches should be rearranged as in their current form, they > break bisection (since the files in this patch reference include files in > a latter patch). We generally prefer large patches to be broken up into > logical sub patches rather than just along file boundaries. > > In this case, even though it was broken up for review, it could have been > committed as one large commit (assuming that there is no sensible way to > break it up). Hi, It can be easily split into 2 commits and one of them would not comply with mailing list limits. James, should I do anything about it? Thanks, - Dmitry > -- > Cheers, > Stephen Rothwell s...@canb.auug.org.au > http://www.canb.auug.org.au/~sfr/ > -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2.2 1/7] crypto: GnuPG based MPI lib - source files (part 1)
Hi all, On Wed, 19 Oct 2011 14:51:30 +0300 Dmitry Kasatkin wrote: > > Adds the multi-precision-integer maths library which was originally taken > from GnuPG and ported to the kernel by (among others) David Howells. > This version is taken from Fedora kernel 2.6.32-71.14.1.el6. > The difference is that checkpatch reported errors and warnings have been > fixed. > > This library is used to implemenet RSA digital signature verification > used in IMA/EVM integrity protection subsystem. > > Due to patch size limitation, the patch is divided into 4 parts. I just noticed that this has been added to the "next" branch of the security tree (and thus into the next release of linux-next). I think that these patches should be rearranged as in their current form, they break bisection (since the files in this patch reference include files in a latter patch). We generally prefer large patches to be broken up into logical sub patches rather than just along file boundaries. In this case, even though it was broken up for review, it could have been committed as one large commit (assuming that there is no sensible way to break it up). -- Cheers, Stephen Rothwells...@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ pgp3DsW9I1LEI.pgp Description: PGP signature
