Re: [RFC PATCH 0/3] take 2: repurposing blkcipher walk api for aead
On Tue, Mar 04, 2014 at 01:28:37PM +0800, Ard Biesheuvel wrote: > I think this is a better approach than the one I proposed before. This time, > I have only added a single function specifically for use by aeads: > > blkcipher_aead_walk_virt_block() > > which takes an additional aead param which is used to get the ivsize, > alignmask > and blocksize of the underlying transform. Looks good to me. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 0/3] take 2: repurposing blkcipher walk api for aead
On 4 March 2014 15:46, Herbert Xu wrote: > On Tue, Mar 04, 2014 at 01:28:37PM +0800, Ard Biesheuvel wrote: >> I think this is a better approach than the one I proposed before. This time, >> I have only added a single function specifically for use by aeads: >> >> blkcipher_aead_walk_virt_block() >> >> which takes an additional aead param which is used to get the ivsize, >> alignmask >> and blocksize of the underlying transform. > > Looks good to me. Thanks! Great! Thank you. Is there anything else required before you can take these patches? Note that the first one should go through the arm64 tree, and may need further review on the arm list as well, but for the first two, it is completely up to you. Regards, Ard. -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 0/3] take 2: repurposing blkcipher walk api for aead
On Tue, Mar 04, 2014 at 03:51:11PM +0800, Ard Biesheuvel wrote: > > Is there anything else required before you can take these patches? > Note that the first one should go through the arm64 tree, and may need > further review on the arm list as well, but for the first two, it is > completely up to you. OK I'll take the first two right now. You can add my ack to the last patch for arm. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 0/3] take 2: repurposing blkcipher walk api for aead
On 4 March 2014 15:53, Herbert Xu wrote: > On Tue, Mar 04, 2014 at 03:51:11PM +0800, Ard Biesheuvel wrote: >> >> Is there anything else required before you can take these patches? >> Note that the first one should go through the arm64 tree, and may need >> further review on the arm list as well, but for the first two, it is >> completely up to you. > > OK I'll take the first two right now. You can add my ack to the > last patch for arm. > Thank you, will do! -- Ard. -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
