On Wed, Oct 2, 2013 at 4:56 PM, Borislav Petkov b...@alien8.de wrote:
On Wed, Oct 02, 2013 at 03:19:51PM -0700, Jim Davis wrote:
Building with the attached random configuration file,
LD init/built-in.o
crypto/built-in.o: In function `RSA_verify_signature':
rsa.c:(.text+0x2dc5e): undefined reference to `mpi_get_nbits'
rsa.c:(.text+0x2dc68): undefined reference to `mpi_get_nbits'
rsa.c:(.text+0x2dc89): undefined reference to `mpi_free'
rsa.c:(.text+0x2dca4): undefined reference to `mpi_cmp_ui'
rsa.c:(.text+0x2dcb7): undefined reference to `mpi_cmp'
rsa.c:(.text+0x2dcc6): undefined reference to `mpi_alloc'
rsa.c:(.text+0x2dce7): undefined reference to `mpi_powm'
rsa.c:(.text+0x2dcff): undefined reference to `mpi_get_nbits'
rsa.c:(.text+0x2dd1c): undefined reference to `mpi_get_buffer'
rsa.c:(.text+0x2de07): undefined reference to `mpi_free'
make: *** [vmlinux] Error 1
Looks like someone has forgotten this completely unused MPILIB_EXTRA
thing in there.
Does this totally untested but obvious patch help?
---
From: Borislav Petkov b...@suse.de
Date: Thu, 3 Oct 2013 01:51:15 +0200
Subject: [PATCH] crypto: Correct RSA MPI dependency
9e235dcaf4f6 (Revert crypto: GnuPG based MPI lib - additional sources
(part 4)) removed the MPI lib extra stuff but left RSA selecting it
while it should select CONFIG_MPILIB instead. Fix it.
Reported-by: Jim Davis jim.ep...@gmail.com
Cc: Herbert Xu herb...@gondor.apana.org.au
Cc: David S. Miller da...@davemloft.net
Cc: David Howells dhowe...@redhat.com
Signed-off-by: Borislav Petkov b...@suse.de
---
crypto/asymmetric_keys/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/crypto/asymmetric_keys/Kconfig b/crypto/asymmetric_keys/Kconfig
index 6d2c2ea12559..755f6174585a 100644
--- a/crypto/asymmetric_keys/Kconfig
+++ b/crypto/asymmetric_keys/Kconfig
@@ -21,7 +21,7 @@ config ASYMMETRIC_PUBLIC_KEY_SUBTYPE
config PUBLIC_KEY_ALGO_RSA
tristate RSA public-key algorithm
depends on ASYMMETRIC_PUBLIC_KEY_SUBTYPE
- select MPILIB_EXTRA
+ select MPILIB
help
This option enables support for the RSA algorithm (PKCS#1, RFC3447).
--
1.8.4
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
Yes, with the change that configuration file didn't generate a build
error. Tested-by: jim.ep...@gmail.com (if it isn't overkill for for
an obvious patch!). Thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
