Re: [PATCH net-next 00/12] fscache: Fixes, traces and development
On Fri, Apr 06, 2018 at 11:32:11AM -0700, Linus Torvalds wrote: > On Fri, Apr 6, 2018 at 11:21 AM, Linus Torvalds > wrote: > > > > No, but if you can redo the pull request part so that the diffstat I > > get will match the diffstat I see in the pull request, that would be > > good. > > Oh, and can you please make sure there is a "[GIT PULL]" in the > subject line for your pull requests? > > Particularly during the merge window (not so much later) I end up > having a separate filtered list of emails that I look at that mention > "git pull". > > Your pull requests don't seem to match that, so your pull requests > don't actually even show up in my list of pending pull requests. We have out of date information in Documentation ... Jon, please consider applying: diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst index f7152ed565e5..908bb55be407 100644 --- a/Documentation/process/submitting-patches.rst +++ b/Documentation/process/submitting-patches.rst @@ -761,7 +761,7 @@ requests, especially from new, unknown developers. If in doubt you can use the pull request as the cover letter for a normal posting of the patch series, giving the maintainer the option of using either. -A pull request should have [GIT] or [PULL] in the subject line. The +A pull request should have [GIT PULL] in the subject line. The request itself should include the repository name and the branch of interest on a single line; it should look something like:: -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH net-next 00/12] fscache: Fixes, traces and development
On Fri, Apr 6, 2018 at 2:02 PM, Matthew Wilcox wrote: > > We have out of date information in Documentation ... My match is actually fairly lax. As long as the email has both "git" and "pull" somewhere, I should see it. It doesn't actually have to be in the subject line. And almost always the "git" is there anyway, and DavidH's email had that one at least twice, in just one line: >git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git and a lot of people end up having some boiler-plate that says "Please pull" or something, so they get the "pull" part that way too, and I'll see those emails even when they have nothing at all in the subject line. But yes: > Jon, please consider applying: > > diff --git a/Documentation/process/submitting-patches.rst > b/Documentation/process/submitting-patches.rst > index f7152ed565e5..908bb55be407 100644 > --- a/Documentation/process/submitting-patches.rst > +++ b/Documentation/process/submitting-patches.rst > -A pull request should have [GIT] or [PULL] in the subject line. The > +A pull request should have [GIT PULL] in the subject line. The That's the *safest* thing to have, in that now the subject line itself already covers everything, and doesn't depend on anything else being implicitly in the message itself. And it's what most people seem to use, based on what I see. It makes them stand out visually to humans too, not just to my usual filter. Having "PATCH" in the subject like (like DavidH _does_ have) also ends up being something I look for, but not during the first week of the merge window when I'm overwhelmed by pull requests. I usually do that at the very end of the merge window just to try to make sure (sometimes even successfully) that I didn't miss anything. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
