Re: [linux-dvb] PCTV200e driver: solved NULL pointer dereference
Juan Antonio Garcia schreef:
After a bit of work I have found the reason for getting the NULL
Pointer dereference error when the PCTV200e is initialized.
The reason is that in the function pctv200e_frontend_attach
adap-fe is NULL, and when the mt352 registration fails it continues
being NULL. When the mt2060 is attached, in mt2060.c the following
line:
struct dvb_frontend *fe = ops-fe;
Tries to reference the NULL pointer.
I have made the following modification to pctv200e.c:
static int pctv200e_frontend_attach(struct dvb_usb_adapter *adap)
{
struct dvb_frontend *fe;
if ((adap-fe = dvb_attach(mt352_attach, pctv200e_mt352_config,
adap-dev-i2c_adap)) != NULL) {
adap-fe-ops.tuner_ops.calc_regs = dvb_usb_tuner_calc_regs;
return 0;
} else {
warn(frontend_attach failed (mt352));
fe = kzalloc(sizeof(struct dvb_frontend), GFP_KERNEL);
if (fe == NULL)
return -EIO;
adap-fe = fe;
}
warn(next: attaching tuner.);
After this the PCTV200e registers and unregisters successfully.
So I guess these changes help...
I would like to continue helping. But I would need some directions,
because I don't know what to do next...
And I am really interested in having the PCTV200e under Linux.
Thanks,
Juan
LLama Gratis a cualquier PC del Mundo.
Llamadas a fijos y móviles desde 1 céntimo por minuto.
http://es.voice.yahoo.com
http://us.rd.yahoo.com/mail/es/tagline/messenger/*http://es.voice.yahoo.com/
___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Juan,
Have a look at the following page fo your patch and how to get it into
mainline. Create a patch file and send it to this list and it should get
incorporated ito mainline as it looks to me as a sound solution to a bug.
http://www.linuxtv.org/v4lwiki/index.php/SubmittingPatches
Regards,
Michel.
___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
[linux-dvb] Patch for PCTV200e driver solving NULL pointer dereference
I have tested the patch below (included at the end) and seems to kill the NULL
Pointer dereference bug when initializing the PCTV200e driver.
The
reason I found for the bug is that in the function pctv200e_frontend_attach
adap-fe
is NULL, and when the mt352 registration fails it continues being NULL.
When the mt2060 is attached using: (adap-fe = dvb_attach(mt2060_attach,
adap-fe-ops.tuner_ops, adap-dev-i2c_adap, pctv200e_mt2060_config, if1).
The adap-fe-ops.tuner_ops is non existent since adap-fe is null. And
when in mt2060.c the following line:
struct dvb_frontend *fe = ops-fe;
tries to reference the NULL pointer.
With this patch the initialization and deinitialization works fine.
I have tested it in a 2.6.20.16 Ubuntu Kernel.
Any way in my PCTV200e tuner still non of the frontends is attached, I get:
dvb-usb: no frontend was attached by 'Pinnacle PCTV 200e DVB-T'
Does anyone gets it attached?
Regards,
Juan
Patch file:
--- pctv200e.c.orig2007-07-14 09:43:49.0 +0300
+++ pctv200e.c2007-07-14 10:33:26.0 +0300
@@ -159,20 +159,31 @@ static u16 if1 = 1220; // this is probab
// source (for the tuner attach: dibusb-common.c)
static int pctv200e_frontend_attach(struct dvb_usb_adapter *adap)
{
+struct dvb_frontend *fe;
+
if ((adap-fe = dvb_attach(mt352_attach, pctv200e_mt352_config,
adap-dev-i2c_adap)) != NULL) {
adap-fe-ops.tuner_ops.calc_regs = dvb_usb_tuner_calc_regs;
return 0;
-} else
+} else {
warn(frontend_attach failed (mt352));
+fe = kzalloc(sizeof(struct dvb_frontend), GFP_KERNEL);
+if (fe == NULL)
+return -EIO;
+
+adap-fe = fe;
+}
+
warn(next: attaching tuner.);
if ((adap-fe = dvb_attach(mt2060_attach, adap-fe-ops.tuner_ops,
adap-dev-i2c_adap, pctv200e_mt2060_config, if1)) != NULL) {
adap-fe-ops.tuner_ops.fe = adap-fe;
adap-fe-ops.tuner_ops.set_params = pctv200e_mt2060_tuner_set_params;
return 0;
-}else
+} else {
+kfree(fe);
warn(frontend_attach failed (mt2060));
+}
warn( frontend attached.);
return -EIO;
__
LLama Gratis a cualquier PC del Mundo.
Llamadas a fijos y móviles desde 1 céntimo por minuto.
http://es.voice.yahoo.com___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
[linux-dvb] Medion MD8800 Quadro DVB-S Support
Hi all, i have a question about the Medion MD8800 Quadro Support for DVB-S. When the module is loaded i get only a message about Analog and DVB-T, there is nothing mentioned with DVB-S. I hope there is already support for this card and that i just did something wrong.. or forget something.. At the moment i only do : modprobe saa7134 and the while TV thing is running. kernel: 2.6.22-1 Distribution: GNU/Debian lenny have a good time all, Steffen -- Steffen Pohle ([EMAIL PROTECTED]) http://stpohle.dyndns.org JabberID: [EMAIL PROTECTED] ICQ: 370965 Yahoo: stpohle MSN: [EMAIL PROTECTED] pgp7gTLcYgwlV.pgp Description: PGP signature ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] Medion MD8800 Quadro DVB-S Support
Hello, Am Samstag, den 14.07.2007, 15:28 +0200 schrieb Steffen Pohle: Hi all, i have a question about the Medion MD8800 Quadro Support for DVB-S. When the module is loaded i get only a message about Analog and DVB-T, there is nothing mentioned with DVB-S. I hope there is already support for this card and that i just did something wrong.. or forget something.. At the moment i only do : modprobe saa7134 and the while TV thing is running. kernel: 2.6.22-1 Distribution: GNU/Debian lenny have a good time all, Steffen it might be close to be supported soon. Have a look at these threads: http://linuxtv.org/pipermail/linux-dvb/2007-June/018741.html http://linuxtv.org/pipermail/linux-dvb/2007-June/018667.html Like the first Creatix with triple TV and the can DVB-S tuner, you have an ISL6405ER. On pictures we have from adding the initial dual analog TV support, there are also two chips marked PF608 (8 pins) connected to it visible. Thanks to Andrew, the DVB-S silicon tuners and the tda10086 channel decoders are supported now too. You might help Hartmut with testing when he has something. Please be patient or try yourself. Cheers, Hermann ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] Patch for PCTV200e driver solving NULL pointer dereference
On Sat, 14 Jul 2007, Juan Antonio Garcia wrote: I have tested the patch below (included at the end) and seems to kill the NULL Pointer dereference bug when initializing the PCTV200e driver. does the driver actually work after this patch? I don't see this driver in v4l-dvb, but this doesn't look right to me. If the demod attach fails, it allocates a fake frontend struct and attaches a tuner anyway? How's it supposed to do anything without the demod? ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] Patch for PCTV200e driver solving NULL pointer dereference
The driver still does not work after this patch. This patch helps so the driver does not crash when the attachment fails. The development still continues. But it would be good to hear the opinion of the driver developers that have been working on the driver. How far the driver works? In my case now the driver loads and unloads but the attachment of the tuner and demod fails. How about others? - Mensaje original De: Trent Piepho [EMAIL PROTECTED] Para: Juan Antonio Garcia [EMAIL PROTECTED] CC: Linux DVB linux-dvb@linuxtv.org Enviado: domingo, 15 de julio, 2007 0:54:14 Asunto: Re: [linux-dvb] Patch for PCTV200e driver solving NULL pointer dereference On Sat, 14 Jul 2007, Juan Antonio Garcia wrote: I have tested the patch below (included at the end) and seems to kill the NULL Pointer dereference bug when initializing the PCTV200e driver. does the driver actually work after this patch? I don't see this driver in v4l-dvb, but this doesn't look right to me. If the demod attach fails, it allocates a fake frontend struct and attaches a tuner anyway? How's it supposed to do anything without the demod? __ LLama Gratis a cualquier PC del Mundo. Llamadas a fijos y móviles desde 1 céntimo por minuto. http://es.voice.yahoo.com___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] KNC1 DVB-S CI?
I have one KNC DVB-S card, and 3 Cineview decoders + flat-cables; none of them seem to work. Without any CAM module inserted, FTA reception is OK. But when I insert an official Mediaguard Canal Digitaal, or Aston Seca2 1.7, in both cases all data stops, including FTA channels (BVN); sometimes FTA comes back after a minute or so. dmesg shows that the CAM is being detected and initialized succesfully though. I am starting to think that perhaps there is a problem with my KNC DVB-S card ...? My setup is Gentoo linux-2.6.21.r4 plus Kaffeine; also tried 2.6.16.r13 and 2.6.19 (vanilla), without succes. Can you tell me what kernel version you are using? And are you using included dvb-drivers, or did you download the latest version? I would like to test the exact same setup; if that still gives problems then I have no option but to try and get another KNC1 card I guess. Tia, Z. === P. van Gaans wrote: Christoph Pfister wrote: 2007/7/7, P. van Gaans [EMAIL PROTECTED]: P. van Gaans wrote: e9hack wrote: P. van Gaans wrote: Some more news. I'm now looking at dvb_ca_en50221.c and I'm pretty sure the solution is in here and not in budget-av.c. Somewhere around line 270 is a thing that loops in a while and breaks after timeout. I removed the break (so it keeps looping). Now I see the following when I insert a CAM: [ 71.764000] budget-av: cam inserted A [ 82.144000] dvb_ca adaptor 0: PC card did not respond :( So at least there's no more infinite loop with ejected-inserted-ejected and so on. But it doesn't work either. It reaches DVB_CA_SLOTSTATE_WAITREADY and times out there. From there it should automatically change state, but it doesn't. Now I'm getting a little stuck, because I don't really know what it's doing and what piece really gets stuck. I also removed the timeout from slotstate_waitready, now I don't get errors anymore, but it (of course) doesn't work. And I broke the ability to eject the CAM, I'm guessing it's stuck in a loop after I ejected and re-inserted the CAM. It seems, there is a little bug within the debi functions. If a debi error occurs, SPCI_DEBI_S is not reset within PSR. In this case, saa7146_wait_for_debi_done returns always ETIMEDOUT. Ttpci_budget_debiread/write doesn't upload a debi command anymore. For testing, you can remove the first 'return result;' statement in both functions. - Hartmut ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb I just booted my computer into Windows so I could at least watch TV tonight. Guess not, the Windows software responds like there is no CAM inserted at all. Please don't tell me I completely killed the card just by removing some timeouts! I didn't know my hardware could be at risk :( . I wonder if it's really dead :( . ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb Things take a whole new turn. Apparently something went wrong with the cable to the CI daughterboard, after re-connecting it the card worked again in Windows. Now for Linux, with once again the normal v4l-dvb (not my modified version): [ 253.42] budget-av: cam inserted B [ 256.384000] dvb_ca adapter 0: DVB CAM detected and initialised successfully Ok! Kaffeine says: DvbCam::probe(): LLCI slot found on /dev/dvb/adapter0/ca0 DvbCam::probe(): CA module present on /dev/dvb/adapter0/ca0 This isn't sufficient - make sure the channel you're trying to watch is marked as scrambled ... But... No picture (and no, no sound either). No error visible. I'm now 100% sure the hardware is OK since it works on Windows now. And the messages in Linux make you think it should work here as well. But no picture? Tia, P. van Gaans Christoph Is that really required? I didn't know. It's a very good suggestion, because my provider (Canal Digitaal) screwed up big time a while ago and set a FTA flag for all their channels, so to some receivers (including GlobeTV on Windows and to kaffeine) they appear as FTA. The solution was closer than I thought! I changed the channels to scrambled and it just works now! No need to change anything in v4l-dvb, the CI is just supported! I'll go test all my CAMs and update the wiki, thanks! ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb ___ linux-dvb mailing list
[linux-dvb] Assistance writing patch for Nova-T 500 stuttering problems
Hi there, The Nova-T 500 has some serious problems with some channels in various locations around Australia. These channels show serious video break-up/stuttering like there is poor reception, however this is not the case. Using other tuners (e.g. other cards, or tuners in TVs), or using the Nova-T 500 on Windows doesn't exhibit these problems. I raised this issue 3 or four months ago (http://www.linuxtv.org/pipermail/linux-dvb/2007-April/017065.html). Patrick Boettcher indicated that it relates to some peculiarities with the DVB broadcast (http://www.linuxtv.org/pipermail/linux-dvb/2007-April/017102.html). The Hauppauge windows drivers now have a registry key (HKEY_LOCAL_MACHINE\System\CurrentControlSet\Services\HCW99BDA\Parameters\FixSFN) that can be used to modify the tuner's behaviour to fix this problem. I'd like to work on a patch for the drivers to add a module option fix_sfn, that does the same as the windows drivers. But need to know what registry settings need to be changed. If Patrick or someone from Hauupauge or Dibcom could give me this information, I'd like to develop the initial patch. Thanks in advance, Matt ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] KNC1 DVB-S CI?
P. van Gaans wrote: Christoph Pfister wrote: 2007/7/7, P. van Gaans [EMAIL PROTECTED]: P. van Gaans wrote: e9hack wrote: P. van Gaans wrote: Some more news. I'm now looking at dvb_ca_en50221.c and I'm pretty sure the solution is in here and not in budget-av.c. Somewhere around line 270 is a thing that loops in a while and breaks after timeout. I removed the break (so it keeps looping). Now I see the following when I insert a CAM: [ 71.764000] budget-av: cam inserted A [ 82.144000] dvb_ca adaptor 0: PC card did not respond :( So at least there's no more infinite loop with ejected-inserted-ejected and so on. But it doesn't work either. It reaches DVB_CA_SLOTSTATE_WAITREADY and times out there. From there it should automatically change state, but it doesn't. Now I'm getting a little stuck, because I don't really know what it's doing and what piece really gets stuck. I also removed the timeout from slotstate_waitready, now I don't get errors anymore, but it (of course) doesn't work. And I broke the ability to eject the CAM, I'm guessing it's stuck in a loop after I ejected and re-inserted the CAM. It seems, there is a little bug within the debi functions. If a debi error occurs, SPCI_DEBI_S is not reset within PSR. In this case, saa7146_wait_for_debi_done returns always ETIMEDOUT. Ttpci_budget_debiread/write doesn't upload a debi command anymore. For testing, you can remove the first 'return result;' statement in both functions. - Hartmut ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb I just booted my computer into Windows so I could at least watch TV tonight. Guess not, the Windows software responds like there is no CAM inserted at all. Please don't tell me I completely killed the card just by removing some timeouts! I didn't know my hardware could be at risk :( . I wonder if it's really dead :( . ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb Things take a whole new turn. Apparently something went wrong with the cable to the CI daughterboard, after re-connecting it the card worked again in Windows. Now for Linux, with once again the normal v4l-dvb (not my modified version): [ 253.42] budget-av: cam inserted B [ 256.384000] dvb_ca adapter 0: DVB CAM detected and initialised successfully Ok! Kaffeine says: DvbCam::probe(): LLCI slot found on /dev/dvb/adapter0/ca0 DvbCam::probe(): CA module present on /dev/dvb/adapter0/ca0 This isn't sufficient - make sure the channel you're trying to watch is marked as scrambled ... But... No picture (and no, no sound either). No error visible. I'm now 100% sure the hardware is OK since it works on Windows now. And the messages in Linux make you think it should work here as well. But no picture? Tia, P. van Gaans Christoph Is that really required? I didn't know. It's a very good suggestion, because my provider (Canal Digitaal) screwed up big time a while ago and set a FTA flag for all their channels, so to some receivers (including GlobeTV on Windows and to kaffeine) they appear as FTA. The solution was closer than I thought! I changed the channels to scrambled and it just works now! No need to change anything in v4l-dvb, the CI is just supported! I'll go test all my CAMs and update the wiki, thanks! ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb Zoilo Gomez wrote: I have one KNC DVB-S card, and 3 Cineview decoders + flat-cables; none of them seem to work. Without any CAM module inserted, FTA reception is OK. But when I insert an official Mediaguard Canal Digitaal, or Aston Seca2 1.7, in both cases all data stops, including FTA channels (BVN); sometimes FTA comes back after a minute or so. dmesg shows that the CAM is being detected and initialized succesfully though. I am starting to think that perhaps there is a problem with my KNC DVB-S card ...? My setup is Gentoo linux-2.6.21.r4 plus Kaffeine; also tried 2.6.16.r13 and 2.6.19 (vanilla), without succes. Can you tell me what kernel version you are using? And are you using included dvb-drivers, or did you download the latest version? I would like to test the exact same setup; if that still gives problems then I have no option but to try and get another KNC1 card I guess. Tia, Z. === I am using Ubuntu 7.04 (32bit x86) with
