Re: [linux-dvb] [PATCH, RFC] KWorld ATSC-115 detection

2007-10-02 Thread Eric Sandeen
Michael Krufky wrote:

> Eric,
> You can remove every hunk of your patch except for the one above, but
> instead link that subsystem ID to SAA7134_BOARD_KWORLD_ATSC110 ...
> The two cards are the same, as far as the driver is concerned.
> Will you be able to test ATSC, QAM and NTSC?
> Cheers,
> Mike
>
>   
Hi Mike -

How's this; I changed the name string too, to say "110/115"

(BTW it's unfortunate that the udev strings get truncated; I haven't yet
looked to see where the 32-char limit is at)

  looking at device '/class/video4linux/video1':
KERNEL=="video1"
SUBSYSTEM=="video4linux"
SYSFS{name}=="saa7133_0_ video _Kworld ATSC11"
SYSFS{dev}=="81:1"


Anyway, patch:

-----

Recognize the KWorld ATSC115 PCI ID as a hardware clone
of the ATSC110.

Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]>

Index: v4l-dvb/linux/Documentation/video4linux/CARDLIST.saa7134
===
--- v4l-dvb.orig/linux/Documentation/video4linux/CARDLIST.saa7134
+++ v4l-dvb/linux/Documentation/video4linux/CARDLIST.saa7134
@@ -88,7 +88,7 @@
  87 -> ADS Instant TV Duo Cardbus PTV331[0331:1421]
  88 -> Tevion/KWorld DVB-T 220RF[17de:7201]
  89 -> ELSA EX-VISION 700TV [1048:226c]
- 90 -> Kworld ATSC110   [17de:7350]
+ 90 -> Kworld ATSC110/115   [17de:7350,17de:7352]
  91 -> AVerMedia A169 B [1461:7360]
  92 -> AVerMedia A169 B1[1461:6360]
  93 -> Medion 7134 Bridge #2[16be:0005]
Index: dvb-pll/linux/drivers/media/video/saa7134/saa7134-cards.c
===
--- v4l-dvb.orig/linux/drivers/media/video/saa7134/saa7134-cards.c
+++ v4l-dvb/linux/drivers/media/video/saa7134/saa7134-cards.c
@@ -2820,7 +2820,7 @@ struct saa7134_board saa7134_boards[] = 
},
},
[SAA7134_BOARD_KWORLD_ATSC110] = {
-   .name   = "Kworld ATSC110",
+   .name   = "Kworld ATSC110/115",
.audio_clock= 0x00187de7,
.tuner_type = TUNER_PHILIPS_TUV1236D,
.radio_type = UNSET,
@@ -4121,6 +4121,12 @@ struct pci_device_id saa7134_pci_tbl[] =
.driver_data  = SAA7134_BOARD_KWORLD_ATSC110,
},{
.vendor   = PCI_VENDOR_ID_PHILIPS,
+   .device   = PCI_DEVICE_ID_PHILIPS_SAA7133, /* SAA7135HL */
+   .subvendor= 0x17de,
+   .subdevice= 0x7352,
+   .driver_data  = SAA7134_BOARD_KWORLD_ATSC110,
+   },{
+   .vendor   = PCI_VENDOR_ID_PHILIPS,
.device   = PCI_DEVICE_ID_PHILIPS_SAA7134,
.subvendor= 0x1461,
.subdevice= 0x7360,



___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb


Re: [linux-dvb] [PATCH, RFC] KWorld ATSC-115 detection

2007-10-02 Thread Eric Sandeen
Michael Krufky wrote:

> Will you be able to test ATSC, QAM and NTSC?

I've been using the card for QAM in my mythbox without problems.

I did a quick check with xawtv (old school!) of the analog/NTSC side,
and it also seems fine.

This is all with the saa7134 module loaded with "card=90,90" (with the
110 and the 115 both in the box) for now.

Thanks,

-Eric

___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb


Re: [linux-dvb] [PATCH, RFC] KWorld ATSC-115 detection

2007-09-28 Thread Eric Sandeen
CityK wrote:
> Eric Sandeen wrote:
>> Kworld ATSC-115 card  PCI ID
>>
>> 
>>
>> +   .subvendor= 0x17de,
>> +   .subdevice= 0x7352,
> 
> I had been wondering about this for a while -- inquiries that I had made
> with other 115 users went unanswered, and, thinking that I could find
> the same by googling for the lspci results for the 115, other means
> yielded nothing as well.

Ok, any other questions you have, or testing you need, I'd be happy to
answer.

>> it is nice to see the actual product name in dmesg 
> 
> I was going to add that it would good of you to submit the subsystem
> info to the PCI ID repository too, but I see that you already have:
> http://pci-ids.ucw.cz/iii/?i=11317133

Yep, though the saa7134 driver will still say "ATSC110" - not a big
deal, though.

> PS. The PCI ID repository could really stand to improve its user
> interface, as its not made out very clearly what submitters are supposed
> to do, and can lead to errors such as: http://pci-ids.ucw.cz/iii/?i=17de
>  been there, done that a couple of times :P

Well, then, I feel better. :)

-Eric

___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb


Re: [linux-dvb] [PATCH, RFC] KWorld ATSC-115 detection

2007-09-27 Thread Eric Sandeen
Michael Krufky wrote:
>> @@ -4123,6 +4147,12 @@ struct pci_device_id saa7134_pci_tbl[] =
>> .driver_data  = SAA7134_BOARD_KWORLD_ATSC110,
>> },{
>> .vendor   = PCI_VENDOR_ID_PHILIPS,
>> +   .device   = PCI_DEVICE_ID_PHILIPS_SAA7133, /* SAA7135HL 
>> */
>> +   .subvendor= 0x17de,
>> +   .subdevice= 0x7352,
>> +   .driver_data  = SAA7134_BOARD_KWORLD_ATSC115,
>> +   },{
>> +   .vendor   = PCI_VENDOR_ID_PHILIPS,
>> .device   = PCI_DEVICE_ID_PHILIPS_SAA7134,
>> .subvendor= 0x1461,
>> .subdevice= 0x7360,
> 
> 
> Eric,
> 
> You can remove every hunk of your patch except for the one above, but
> instead link that subsystem ID to SAA7134_BOARD_KWORLD_ATSC110 ...
> The two cards are the same, as far as the driver is concerned.

Ok.  I knew it was overboard. (although it is nice to see the actual
product name in dmesg...)  :)

> Will you be able to test ATSC, QAM and NTSC?

I can test QAM and NTSC, but not ATSC, no antenna...

Thanks!
-Eric

___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb


[linux-dvb] [PATCH, RFC] KWorld ATSC-115 detection

2007-09-27 Thread Eric Sandeen
So, just got my shiny new Kworld ATSC-115 card in the mail.

Any desire for a patch to actually detect the new PCI ID, even
though I guess it's pretty much the same card as the ATSC 110?

Full-on pedantic patch below, I know not all of this needs to be
duplicated if it's truly identical hardware

Comments?  (build & load tested only, not currently near a signal
to test it but I assume it's fine, since using the card=90 module
option is reported to work)

Thanks,

-Eric

Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]>

Index: v4l-dvb/linux/Documentation/video4linux/CARDLIST.saa7134
===
--- v4l-dvb.orig/linux/Documentation/video4linux/CARDLIST.saa7134
+++ v4l-dvb/linux/Documentation/video4linux/CARDLIST.saa7134
@@ -116,3 +116,4 @@
 115 -> Sabrent PCMCIA TV-PCB05  [0919:2003]
 116 -> 10MOONS TM300 TV Card[1131:2304]
 117 -> Avermedia Super 007  [1461:f01d]
+118 -> Kworld ATSC115   [17de:7352]
Index: v4l-dvb/linux/drivers/media/video/saa7134/saa7134-cards.c
===
--- v4l-dvb.orig/linux/drivers/media/video/saa7134/saa7134-cards.c
+++ v4l-dvb/linux/drivers/media/video/saa7134/saa7134-cards.c
@@ -2845,6 +2845,30 @@ struct saa7134_board saa7134_boards[] = 
.amux = LINE2,
}},
},
+   [SAA7134_BOARD_KWORLD_ATSC115] = {
+   .name   = "Kworld ATSC115",
+   .audio_clock= 0x00187de7,
+   .tuner_type = TUNER_PHILIPS_TUV1236D,
+   .radio_type = UNSET,
+   .tuner_addr = ADDR_UNSET,
+   .radio_addr = ADDR_UNSET,
+   .tda9887_conf   = TDA9887_PRESENT,
+   .mpeg   = SAA7134_MPEG_DVB,
+   .inputs = {{
+   .name = name_tv,
+   .vmux = 1,
+   .amux = TV,
+   .tv   = 1,
+   },{
+   .name = name_comp1,
+   .vmux = 3,
+   .amux = LINE2,
+   },{
+   .name = name_svideo,
+   .vmux = 8,
+   .amux = LINE2,
+   }},
+   },
[SAA7134_BOARD_AVERMEDIA_A169_B] = {
/* AVerMedia A169  */
/* Rickard Osser <[EMAIL PROTECTED]>  */
@@ -4123,6 +4147,12 @@ struct pci_device_id saa7134_pci_tbl[] =
.driver_data  = SAA7134_BOARD_KWORLD_ATSC110,
},{
.vendor   = PCI_VENDOR_ID_PHILIPS,
+   .device   = PCI_DEVICE_ID_PHILIPS_SAA7133, /* SAA7135HL */
+   .subvendor= 0x17de,
+   .subdevice= 0x7352,
+   .driver_data  = SAA7134_BOARD_KWORLD_ATSC115,
+   },{
+   .vendor   = PCI_VENDOR_ID_PHILIPS,
.device   = PCI_DEVICE_ID_PHILIPS_SAA7134,
.subvendor= 0x1461,
.subdevice= 0x7360,
@@ -4727,6 +4757,7 @@ int saa7134_board_init2(struct saa7134_d
}
break;
case SAA7134_BOARD_KWORLD_ATSC110:
+   case SAA7134_BOARD_KWORLD_ATSC115:
{
/* enable tuner */
int i;
Index: v4l-dvb/linux/drivers/media/video/saa7134/saa7134-dvb.c
===
--- v4l-dvb.orig/linux/drivers/media/video/saa7134/saa7134-dvb.c
+++ v4l-dvb/linux/drivers/media/video/saa7134/saa7134-dvb.c
@@ -839,6 +839,10 @@ static struct nxt200x_config kworldatsc1
.demod_address= 0x0a,
 };
 
+static struct nxt200x_config kworldatsc115 = {
+   .demod_address= 0x0a,
+};
+
 /* ==
  * Core code
  */
@@ -991,6 +995,14 @@ static int dvb_init(struct saa7134_dev *
   NULL, DVB_PLL_TUV1236D);
}
break;
+   case SAA7134_BOARD_KWORLD_ATSC115:
+   dev->dvb.frontend = dvb_attach(nxt200x_attach, &kworldatsc115,
+  &dev->i2c_adap);
+   if (dev->dvb.frontend) {
+   dvb_attach(dvb_pll_attach, dev->dvb.frontend, 0x61,
+  NULL, DVB_PLL_TUV1236D);
+   }
+   break;
case SAA7134_BOARD_FLYDVBS_LR300:
dev->dvb.frontend = dvb_attach(tda10086_attach, &flydvbs,
   &dev->i2c_adap);
Index: v4l-dvb/linux/drivers/media/video/saa7134/saa7134.h
===
--- v4l-dvb.orig/linux/drivers/media/video/saa7134/saa7134.h
+++ v4l-dv

Re: [linux-dvb] [RFC] TUV1236d / dvb-pll: rf input switching via module option

2007-09-08 Thread Eric Sandeen
Michael Krufky wrote:

> Eric,
> 
> For now, the only thing that I'm asking you to test is whether you are
> able to switch the input selection using the module option.

Works for me.  for dvb_pll, input=1 on the ATSC-110 is the same as what
I get with no options, i.e. the bottom connector.  input=2 gives me the
top connector.

Would a printk about which input is being used for each card at startup
time be useful?

-Eric

___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb


Re: [linux-dvb] [RFC] TUV1236d / dvb-pll: rf input switching via module option

2007-09-07 Thread Eric Sandeen
Michael Krufky wrote:

> Please provide some feedback after testing this tree.  The changes in 
> question are:
> 
> http://linuxtv.org/hg/~mkrufky/dvb-pll
> 
> - dvb-pll: pass fe pointer into dvb_pll_configure() and set() functions
> - dvb-pll: store instance ID in dvb_pll_priv structure
> - dvb-pll: add module option to specify rf input
> - dvb-pll: add module option to force dvb-pll desc id (for debug use only)

it's 1am so not doing a whole lot, but set up all modules from that
repo, and my mythbox came up happy with the QAM input working on the
"bottom" connector of my Kworld ATSC-110.  I'll try the option to switch
them tomorrow  anything else you'd like me to test with this card?

Thanks,
-Eric

___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb


Re: [linux-dvb] cx88-dvb: fix nxt200x rf input switching broke my tuner? :)

2007-08-25 Thread Eric Sandeen
Eric Sandeen wrote:
> hi, I have a Kworld ATSC 110 PCI DVB card,
> 
> 03:09.0 Multimedia controller: Philips Semiconductors SAA7133/SAA7135
> Video Broadcast Decoder (rev f0)
> Subsystem: KWorld Computer Co. Ltd. ATSC 110 Digital / Analog
> HDTV Tuner
> Flags: bus master, medium devsel, latency 55, IRQ 23
> Memory at c4001000 (32-bit, non-prefetchable) [size=2K]
> Capabilities: [40] Power Management version 2
> 
> It seems this fairly recent mod broke my ability to tune in QAM HDTV:
> 
> ---
> 
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=f5ae29e284b328e0976789d5c199bbbe80e4b005
> [PATCH] cx88-dvb: fix nxt200x rf input switching
> Michael Krufky [Sat, 24 Mar 2007 17:21:53 + (13:21 -0400)]
> After dvb tuner refactoring, the pllbuff has been altered such that the
> pll address is now stored in buf[0].  Instead of sending buf to
> set_pll_input, we should send buf+1.
> 
> ---

Ok, after much patient assistance from mkrufky, we sorted out that a
recent change meant that I had to switch physical inputs on my card -
that is, plugging the physical cable into the *other* card input (the
input closer to the center of pci card bracket) - makes everything happy
again...

Thanks,

-Eric

___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb


[linux-dvb] cx88-dvb: fix nxt200x rf input switching broke my tuner? :)

2007-08-24 Thread Eric Sandeen
hi, I have a Kworld ATSC 110 PCI DVB card,

03:09.0 Multimedia controller: Philips Semiconductors SAA7133/SAA7135
Video Broadcast Decoder (rev f0)
Subsystem: KWorld Computer Co. Ltd. ATSC 110 Digital / Analog
HDTV Tuner
Flags: bus master, medium devsel, latency 55, IRQ 23
Memory at c4001000 (32-bit, non-prefetchable) [size=2K]
Capabilities: [40] Power Management version 2

It seems this fairly recent mod broke my ability to tune in QAM HDTV:

---

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=f5ae29e284b328e0976789d5c199bbbe80e4b005
[PATCH] cx88-dvb: fix nxt200x rf input switching
Michael Krufky [Sat, 24 Mar 2007 17:21:53 + (13:21 -0400)]
After dvb tuner refactoring, the pllbuff has been altered such that the
pll address is now stored in buf[0].  Instead of sending buf to
set_pll_input, we should send buf+1.

---

.. at least on my fedora kernel, 2.6.22.2-42.fc6

Reverting that change allows me to tune in HDTV programs again.

Also when that patch was in place, I got these messages:

Aug 24 22:28:10 mythbox kernel: nxt200x: NXT2004 Detected
Aug 24 22:28:10 mythbox kernel: nxt200x: Timeout waiting for nxt2004 to
init.
Aug 24 22:29:18 mythbox kernel: nxt200x: nxt200x_readbytes: i2c read
error (addr 0x0a, err == -5)
Aug 24 22:29:18 mythbox kernel: nxt200x: nxt200x_writebytes: i2c write
error (addr 0x0a, err == -5)

I see a few more changes are still in git, and I haven't been able to
test 2.6.23-rcX yet, but thought I'd report this for now .  If there is
any more info or testing I can provide, please let me know.

Thanks!
-Eric

___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb