[linux-dvb] [PATCH] ir-keymaps.c: Add support for the extra keys in the black Technotrend 1500 bundled remote, 2nd try

2007-04-14 Thread Ville-Pekka Vainio
Hi,

This is the second time I'm sending this patch to the list, I hope it could be 
applied. As you can see, it's a trivial patch but could be useful to some 
users. I have also CC'd Mauro and Michael directly, since they signed-off my 
previous TT1500 related patch. The patch is attached to avoid whitespace 
issues, I can also send it inlined if needed.


It has come to my knowledge that the Technotrend 1500 DVB cards have been sold 
bundled with at least two different kinds of remotes, a grey one and a black 
one. This patch adds support for the extra keys in the black remote to 
ir-keymaps.c.

Signed-off-by: Ville-Pekka Vainio [EMAIL PROTECTED]

-- 
Ville-Pekka Vainio
[EMAIL PROTECTED]
diff -r 16ef177616ec linux/drivers/media/common/ir-keymaps.c
--- a/linux/drivers/media/common/ir-keymaps.c	Sat Apr 14 10:25:53 2007 -0300
+++ b/linux/drivers/media/common/ir-keymaps.c	Tue Mar 06 14:58:06 2007 +0300
@@ -1789,7 +1789,7 @@ IR_KEYTAB_TYPE ir_codes_encore_enltv[IR_
 
 EXPORT_SYMBOL_GPL(ir_codes_encore_enltv);
 
-/* for the Technotrend 1500 bundled remote: */
+/* for the Technotrend 1500 bundled remotes (grey and black): */
 IR_KEYTAB_TYPE ir_codes_tt_1500[IR_KEYTAB_SIZE] = {
 	[ 0x01 ] = KEY_POWER,
 	[ 0x02 ] = KEY_SHUFFLE,	/* ? double-arrow key */
@@ -1824,6 +1824,12 @@ IR_KEYTAB_TYPE ir_codes_tt_1500[IR_KEYTA
 	[ 0x25 ] = KEY_VOLUMEUP,
 	[ 0x26 ] = KEY_VOLUMEDOWN,
 	[ 0x27 ] = KEY_SETUP,
+	[ 0x3a ] = KEY_RECORD, /* these keys are only in the black remote */
+	[ 0x3b ] = KEY_PLAY,
+	[ 0x3c ] = KEY_STOP,
+	[ 0x3d ] = KEY_REWIND,
+	[ 0x3e ] = KEY_PAUSE,
+	[ 0x3f ] = KEY_FORWARD,
 };
 
 EXPORT_SYMBOL_GPL(ir_codes_tt_1500);
___
linux-dvb mailing list
[EMAIL PROTECTED]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

[linux-dvb] [PATCH] ir-keymaps.c: Add support for the extra keys in the black Technotrend 1500 bundled remote

2007-03-24 Thread Ville-Pekka Vainio
Hi,

It has come to my knowledge that the Technotrend 1500 DVB cards have been sold 
bundled with at least two different kinds of remotes, a grey one and a black 
one.

This patch adds support for the extra keys in the black remote to 
ir-keymaps.c. It won't break any existing functionality for the users of the 
grey remote.

Signed-off-by: Ville-Pekka Vainio [EMAIL PROTECTED]

diff -r f592a4fca76a linux/drivers/media/common/ir-keymaps.c
--- a/linux/drivers/media/common/ir-keymaps.c   Wed Mar 21 16:35:28 2007 -0300
+++ b/linux/drivers/media/common/ir-keymaps.c   Tue Mar 06 13:58:06 2007 +0200
@@ -1789,7 +1789,7 @@ IR_KEYTAB_TYPE ir_codes_encore_enltv[IR_
 
 EXPORT_SYMBOL_GPL(ir_codes_encore_enltv);
 
-/* for the Technotrend 1500 bundled remote: */
+/* for the Technotrend 1500 bundled remotes (grey and black): */
 IR_KEYTAB_TYPE ir_codes_tt_1500[IR_KEYTAB_SIZE] = {
[ 0x01 ] = KEY_POWER,
[ 0x02 ] = KEY_SHUFFLE, /* ? double-arrow key */
@@ -1824,6 +1824,12 @@ IR_KEYTAB_TYPE ir_codes_tt_1500[IR_KEYTA
[ 0x25 ] = KEY_VOLUMEUP,
[ 0x26 ] = KEY_VOLUMEDOWN,
[ 0x27 ] = KEY_SETUP,
+   [ 0x3a ] = KEY_RECORD, /* these keys are only in the black remote */
+   [ 0x3b ] = KEY_PLAY,
+   [ 0x3c ] = KEY_STOP,
+   [ 0x3d ] = KEY_REWIND,
+   [ 0x3e ] = KEY_PAUSE,
+   [ 0x3f ] = KEY_FORWARD,
 };
 
 EXPORT_SYMBOL_GPL(ir_codes_tt_1500);

___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb


Re: [linux-dvb] Problem with keys repeated

2007-03-06 Thread Ville-Pekka Vainio
Kirjoitit viestissäsi (lähetysaika keskiviikko, 7. maaliskuuta 2007 00:18:49):

 I've been having the same kind of problems with Technotrend C-1500 and
  it's bundled remote (a grey one). I tried loading ir-common with
  repeat=0, but still it seems to take quite a long time before the
  keypress gets generated. It feels like I anyway have to invoke some kind
  of repeat handling to get the keypress through.

 I'm not quite sure I follow, you have the same kind of problem (i.e.
 that a continous keypress generates repeat events)? But then you talk
 about time before the keypress is generated?

I'll try to explain better how the remote works for me. I'm not sure if the 
problem is really the same, but it sounded similar, so I decided to tell 
about it on this thread...

At first, maybe for about ten keypresses after boot or reloading the drivers, 
the remote works perfectly. The event happens immediately after pressing the 
key. 

Then it goes into a mode where I have to press the key for a long time before 
anything happens. And when the event actually occurs, then it often also 
generates a repeat. I tried repeat=0 to stop this unwanted repeat from 
occurring, but it didn't work very well.

I tried to get an evtest log of the situation:

Event: time 1173221474.755429, type 1 (Key), code 103 (Up), value 1
Event: time 1173221474.755434, type 0 (Reset), code 0 (Reset), value 0
Event: time 1173221475.155711, type 1 (Key), code 103 (Up), value 2
Event: time 1173221475.155716, type 0 (Reset), code 0 (Reset), value 0
Event: time 1173221475.219704, type 1 (Key), code 103 (Up), value 0
Event: time 1173221475.219707, type 0 (Reset), code 0 (Reset), value 0

-- 
Ville-Pekka Vainio
[EMAIL PROTECTED]

___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb


Re: RE: [linux-dvb] FusionHDTV Dual Digital zl10353 / dee1601 tuning

2006-08-18 Thread Ville-Pekka Vainio

Luke Rosenthal wrote:


I'm having a few probs compiling on FC5:

hg clone http://linuxtv.org/hg/v4l-dvb/
cd v4l-dvb
make

I get the following errors:

/tmp/v4l-dvb/v4l/dvb_net.c: In function 'wq_set_multicast_list':
/tmp/v4l-dvb/v4l/dvb_net.c:1141: error: 'struct net_device' has no member
named 'xmit_lock'
/tmp/v4l-dvb/v4l/dvb_net.c:1170: error: 'struct net_device' has no member
named 'xmit_lock'

Compiling against 2.6.17-1.2174_FC5, I have the following kernel packages
installed:

kernel-2.6.17-1.2145_FC5.i686.rpm
kernel-2.6.17-1.2174_FC5.i686.rpm
kernel-devel-2.6.17-1.2174_FC5.i686.rpm

Am I doing something wrong?  I have been able to compile the v4l-dvb tree
before as recently as a week ago (altho that was against 2.6.17-1.2145, I
think)

Luke


Hi,

This is my first time mailing to the list, I hope it gets through.

IIRC, the FC5 2.6.17 kernels are actually based on 2.6.18, so this 
problem can be fixed by doing small changes to the dvb_net.c file.


Find the function wq_set_multicast_list and change the two occurrences of

#if LINUX_VERSION_CODE  KERNEL_VERSION(2,6,18)

to

#if LINUX_VERSION_CODE  KERNEL_VERSION(2,6,17)

so that xmit_lock won't be used. Works for me.

Ville-Pekka

___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb