Re: [linux-dvb] Re: Hybrid tuner proposal (V4L/DVB)
On 4/16/07, Manu Abraham [EMAIL PROTECTED] wrote: Johannes Stezenbach wrote: On Mon, Apr 16, 2007, Manu Abraham wrote: Johannes Stezenbach wrote: I believe many people (users) would like em28xx to be merged asap, so I'm trying to find a way how it could be done. IMHO, code that which is bad should be fixed and then only be accepted into the project. I don't see any reason for any person/project to be given any special status and things should work just as normally. It is completely wrong to artificially create a huge importance/need and doing things -- Incorrect way of doing things. It's not artificial. The em28xx merge has been delayed for more than a year with little visible progress. That's a disaster. We have had discussions that have been outstanding since 2005. Don't you feel the same on those ? Do you know how many people were/are still anxiously looking forward, Sorry not just people -- OSS projects (applications and so on), Commercial projects and so on. Manu please stay on a constructive level now. What I don't like about your current approach is that you have to duplicate the wrapper in every new hybrid tuner module (eg you have one generic core tuning function and you have to build wrappers around to fit the i2c and dvb part). Please point me to your code and where my current approach will break the multiproto work you did last year. Regarding the difficulty, I don't see anything within the whole project which isn't doable everything's about time and patience of reading specs to get something done here. And it doesn't really matter whose fault it is. If you have technical reasons why Markus' code shouln't be merged (like breaks support for the X card, or even breaks all non-em28xx cards or crashes under SMP etc.), then you should let us know about it. Note that your hybrid tuner proposal is not dismissed by merging Markus' code, however time is important here, and I don't think it's OK to delay the merge another couple of weeks/months until your proposal is fully implemented, tested and merged. As i said, completely upto you. Don't have anything more to say. now stop pushing anyone and discuss the work we did so far, this is not only up to Johannes he didn't write your neither my code. Markus ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] Re: Hybrid tuner proposal (V4L/DVB)
Markus Rechberger wrote: On 4/16/07, Manu Abraham [EMAIL PROTECTED] wrote: Johannes Stezenbach wrote: On Mon, Apr 16, 2007, Manu Abraham wrote: Johannes Stezenbach wrote: I believe many people (users) would like em28xx to be merged asap, so I'm trying to find a way how it could be done. IMHO, code that which is bad should be fixed and then only be accepted into the project. I don't see any reason for any person/project to be given any special status and things should work just as normally. It is completely wrong to artificially create a huge importance/need and doing things -- Incorrect way of doing things. It's not artificial. The em28xx merge has been delayed for more than a year with little visible progress. That's a disaster. We have had discussions that have been outstanding since 2005. Don't you feel the same on those ? Do you know how many people were/are still anxiously looking forward, Sorry not just people -- OSS projects (applications and so on), Commercial projects and so on. Manu please stay on a constructive level now. *enough* Stop it. Someone talking constructive. Huh ! What I don't like about your current approach is that you have to duplicate the wrapper in every new hybrid tuner module (eg you have one generic core tuning function and you have to build wrappers around to fit the i2c and dvb part). Johannes, you probably understand now. Please point me to your code and where my current approach will break the multiproto work you did last year. You can read that discussion for understanding how. Not multiproto, but your broken approach _will_ break. Manu ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] Re: Hybrid tuner proposal (V4L/DVB)
On Mon, Apr 16, 2007, Manu Abraham wrote: Johannes, you probably understand now. Well, you want to be DVB maintainer, so please try to think like one. How can you serve the project better? [ ] By putting all personal issues aside and merge em28xx anyway, even if it means getting your hands dirty and having to fix up possible problems and any ugliness caused by it? [ ] By further delaying it until Markus might one day*) wake up enligthened and would magically fix up all issues to your whole content himself? Choose wisely. It's OK that you defend your code and your proposal, but if you look at the big picture the the choice should be clear, right? Johannes *) In Germany we call this day Sankt Nimmerleinstag ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] Re: Hybrid tuner proposal (V4L/DVB)
Johannes Stezenbach wrote: On Mon, Apr 16, 2007, Manu Abraham wrote: Johannes, you probably understand now. Well, you want to be DVB maintainer, so please try to think like one. How can you serve the project better? [ ] By putting all personal issues aside and merge em28xx anyway, even if it means getting your hands dirty and having to fix up possible problems and any ugliness caused by it? The merging probably sounds okay. (As i said in a previous post, it is upto you. I don't have the said device to comment on it) For later fixups, for API updates there needs to be co-operation from the author, rather than flames that's all. [ ] By further delaying it until Markus might one day*) wake up enligthened and would magically fix up all issues to your whole content himself? Choose wisely. It's OK that you defend your code and your proposal, but if you look at the big picture the the choice should be clear, right? Johannes *) In Germany we call this day Sankt Nimmerleinstag Manu ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] Re: Hybrid tuner proposal (V4L/DVB)
Em Ter, 2007-04-10 às 15:13 +0200, Johannes Stezenbach escreveu: Hi, [big snip] C'mon guys, let's leave the past behind us and not start fighting again. I believe many people (users) would like em28xx to be merged asap, so I'm trying to find a way how it could be done. Agreed. It is unfortunate that em28xx depends on the hybrid tuner API design, but we have to live with it. On 4/10/07, Manu Abraham [EMAIL PROTECTED] wrote: http://marc.info/?l=linux-videom=117571761928085w=2 http://marc.info/?l=linux-videom=117613833119350w=2 If that proposal is _proven to work_ (dummy_hybrid_tuner.c doesn't sound like it's been tested), _and_ has more supporters than Markus' code, then I would ask him to rebase his code on top of it. However, I don't think we should wait another month for your proposal to be ready. So currently I think if Markus code _works_, and _doesn't break_ any non-em28xx/xc3028 devices, then it should be merged. Agreed. But of course that requires that people test his stuff with non-em28xx equipment, and report if it still works. (And ideally someone who read through the code would ACK it or let us know why it can't be ACKed.) It is important to test the changes with boards that have tda9887 plus an analog tuner, tea5767 and tda8290/8275 tuners. I'll be travelling tomorrow, so probably, I won't have time this week for testing his code. I'll try to do the tests next week. You or someone else can rewrite the whole hybrid tuner stuff later once you have a proven better solution. I don't care and I guess Markus wouldn't mind, too. As Markus mentioned, I gave him some suggestions on other directions, to improve the API, but code optimizations can be done later, after merging his work. The more important thing to do right now is to focus on merging his code, to allow the driver updates and dvb support to go to 2.6.22. Cheers, Mauro ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
