RE: [PATCH v2 0/8] Decode IA32/X64 CPER

[Ghannam, Yazen]

> -Original Message-
> From: Borislav Petkov 
> Sent: Thursday, March 1, 2018 7:00 AM
> To: Ghannam, Yazen 
> Cc: Tony Luck ; linux-efi@vger.kernel.org; linux-
> ker...@vger.kernel.org; ard.biesheu...@linaro.org; x...@kernel.org
> Subject: Re: [PATCH v2 0/8] Decode IA32/X64 CPER
> 
> On Wed, Feb 28, 2018 at 08:58:15PM +, Ghannam, Yazen wrote:
> > 1) We keep this set mostly as-is. This would be our fallback if we don't 
> > have
> > anything better.
> 
> Yes, sounds good. We try to decode it as MCE and if we cannot, we dump
> the raw CPER record.
> 
> > 2) I add the MCA decoding to this set. I was thinking to do this in a 
> > separate
> > set but maybe it's better to do it all together.
> 
> I'm fine if you do it separately, as long as you do it so that we have
> user-friendly decoding in the end.
> 

I wanted to add the MCA decoding to this set but I got caught up with something
else and haven't had time to do it.

Is it alright if I go ahead and just send the v3 of this set without the MCA 
decoding?
I was hoping this could be accepted in the next merge window. And if that's 
still
possible I'd like to have some CPER decoding sooner rather than nothing.

Thanks,
Yazen
N�r��yb�X��ǧv�^�)޺{.n�+{�y^n�r���z���h�&���G���h�(�階�ݢj"���m��z�ޖ���f���h���~�m�

[PATCH] x86/efi: Free efi_pgd with free_pages()

[Waiman Long]

The efi_pgd is allocated as PGD_ALLOCATION_ORDER pages and so should
also be freed as PGD_ALLOCATION_ORDER pages with free_pages().

Fixes: d9e9a6418065 ("x86/mm/pti: Allocate a separate user PGD")
Signed-off-by: Waiman Long 
---
 arch/x86/platform/efi/efi_64.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/platform/efi/efi_64.c b/arch/x86/platform/efi/efi_64.c
index c310a82..f9cfbc0 100644
--- a/arch/x86/platform/efi/efi_64.c
+++ b/arch/x86/platform/efi/efi_64.c
@@ -227,7 +227,7 @@ int __init efi_alloc_page_tables(void)
if (!pud) {
if (CONFIG_PGTABLE_LEVELS > 4)
free_page((unsigned long) pgd_page_vaddr(*pgd));
-   free_page((unsigned long)efi_pgd);
+   free_pages((unsigned long)efi_pgd, PGD_ALLOCATION_ORDER);
return -ENOMEM;
}
 
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH -next] efi/libstub/tpm: Make function efi_retrieve_tpm2_eventlog_1_2() static

[Jarkko Sakkinen]

On Thu, 2018-03-22 at 16:06 +0200, Jarkko Sakkinen wrote:
> On Tue, 2018-03-20 at 14:17 +, Wei Yongjun wrote:
> > Fixes the following sparse warning:
> > 
> > drivers/firmware/efi/libstub/tpm.c:62:6: warning:
> >  symbol 'efi_retrieve_tpm2_eventlog_1_2' was not declared. Should it be
> > static?
> > 
> > Signed-off-by: Wei Yongjun 
> > ---
> >  drivers/firmware/efi/libstub/tpm.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/firmware/efi/libstub/tpm.c
> > b/drivers/firmware/efi/libstub/tpm.c
> > index 9d08cea..caa37a6 100644
> > --- a/drivers/firmware/efi/libstub/tpm.c
> > +++ b/drivers/firmware/efi/libstub/tpm.c
> > @@ -59,7 +59,7 @@ void efi_enable_reset_attack_mitigation(efi_system_table_t
> > *sys_table_arg)
> >  
> >  #endif
> >  
> > -void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t *sys_table_arg)
> > +static void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t
> > *sys_table_arg)
> >  {
> > efi_guid_t tcg2_guid = EFI_TCG2_PROTOCOL_GUID;
> > efi_guid_t linux_eventlog_guid = LINUX_EFI_TPM_EVENT_LOG_GUID;
> > 
> 
> Reviewed-by: Jarkko Sakkinen 

Applied.

/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH -next] efi/libstub/tpm: Make function efi_retrieve_tpm2_eventlog_1_2() static

[Jarkko Sakkinen]

On Tue, 2018-03-20 at 14:17 +, Wei Yongjun wrote:
> Fixes the following sparse warning:
> 
> drivers/firmware/efi/libstub/tpm.c:62:6: warning:
>  symbol 'efi_retrieve_tpm2_eventlog_1_2' was not declared. Should it be
> static?
> 
> Signed-off-by: Wei Yongjun 
> ---
>  drivers/firmware/efi/libstub/tpm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/efi/libstub/tpm.c
> b/drivers/firmware/efi/libstub/tpm.c
> index 9d08cea..caa37a6 100644
> --- a/drivers/firmware/efi/libstub/tpm.c
> +++ b/drivers/firmware/efi/libstub/tpm.c
> @@ -59,7 +59,7 @@ void efi_enable_reset_attack_mitigation(efi_system_table_t
> *sys_table_arg)
>  
>  #endif
>  
> -void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t *sys_table_arg)
> +static void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t *sys_table_arg)
>  {
>   efi_guid_t tcg2_guid = EFI_TCG2_PROTOCOL_GUID;
>   efi_guid_t linux_eventlog_guid = LINUX_EFI_TPM_EVENT_LOG_GUID;
> 

Reviewed-by: Jarkko Sakkinen 

/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html