Re: Add support for TCG2 log format on UEFI systems
On Mon, Apr 1, 2019 at 4:52 PM Jarkko Sakkinen wrote: > > On Wed, Feb 27, 2019 at 12:26:54PM -0800, Matthew Garrett wrote: > > Identical to V4, but based on tpmdd-next > > OK, so on my GLK NUC I get valid final log and invalid event log > after adding some extra klogs. > > I.e. > > - if (efi.tpm_log == EFI_INVALID_TABLE_ADDR) > + if (efi.tpm_log == EFI_INVALID_TABLE_ADDR) { Just to make sure - are you booting via the EFI boot stub? We need to obtain the boot log before ExitBootServices() is called, so if you're booting directly into the 32-bit entry point (eg, by using the "linux" command in grub) then you won't get a log.
Re: Add support for TCG2 log format on UEFI systems
On Wed, Feb 27, 2019 at 12:26:54PM -0800, Matthew Garrett wrote: > Identical to V4, but based on tpmdd-next OK, so on my GLK NUC I get valid final log and invalid event log after adding some extra klogs. I.e. - if (efi.tpm_log == EFI_INVALID_TABLE_ADDR) + if (efi.tpm_log == EFI_INVALID_TABLE_ADDR) { + pr_err("No event log\n"); return -ENODEV; + } will result [2.654392] No event log but still [0.00] efi: ACPI 2.0=0x69ca2000 ACPI=0x69ca2000 TPMFinalLog=0x69ce4000 SMBIOS=0x69f63000 SMBIOS 3.0=0x69f62000 ESRT=0x69f3e818 MEMATTR=0x63475118 Tomas, I wonder if you are able to get the log out with some machine? /Jarkko