a question about ext4_fsblk_t

[郭明阳]

Hello everyone:

I am a student interesting in linux filesystem, I have a 
problem about the replace of block number type to ext4_fsblk_t. Is it complete? 
Or has it passed all the test? Because I have found a place like this in 
linux-2.6.19-rc2/fs/ext4/inode.c 



+struct buffer_head *ext4_bread(handle_t *handle, struct inode *inode,
+   int block, int create, int *err)


the block's type is not changed. Although I think it will bring no mistake, I 
doubt about why not change it. Thank you !


guomingyang

-
To unsubscribe from this list: send the line unsubscribe linux-ext4 in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: a question about ext4_fsblk_t

[guomingyang]

   I also find many places where the block number type is not changed in 
namei.c and dir.c. Why? 
   Thank you to anyone who offer help
Hello everyone:

   I am a student interesting in linux filesystem, I have a 
 problem about the replace of block number type to ext4_fsblk_t. Is it 
 complete? Or has it passed all the test? Because I have found a place like 
 this in linux-2.6.19-rc2/fs/ext4/inode.c 



+struct buffer_head *ext4_bread(handle_t *handle, struct inode *inode,
+   int block, int create, int *err)


the block's type is not changed. Although I think it will bring no mistake, I 
doubt about why not change it. Thank you !


guomingyang

-
To unsubscribe from this list: send the line unsubscribe linux-fsdevel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

guomingyang

-
To unsubscribe from this list: send the line unsubscribe linux-ext4 in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] ext4: fix printk format warnings

[Randy Dunlap]

From: Randy Dunlap [EMAIL PROTECTED]

Fix ext4 printk format warnings:
fs/ext4/resize.c:72: warning: long long unsigned int format, __u64 arg (arg 4)
fs/ext4/resize.c:76: warning: long long unsigned int format, __u64 arg (arg 4)
fs/ext4/resize.c:81: warning: long long unsigned int format, __u64 arg (arg 4)
fs/ext4/resize.c:85: warning: long long unsigned int format, __u64 arg (arg 4)
fs/ext4/resize.c:89: warning: long long unsigned int format, __u64 arg (arg 4)
fs/ext4/resize.c:89: warning: long long unsigned int format, __u64 arg (arg 5)
fs/ext4/resize.c:93: warning: long long unsigned int format, __u64 arg (arg 4)
fs/ext4/resize.c:93: warning: long long unsigned int format, __u64 arg (arg 5)
fs/ext4/resize.c:98: warning: long long unsigned int format, __u64 arg (arg 4)
fs/ext4/resize.c:103: warning: long long unsigned int format, __u64 arg (arg 4)
fs/ext4/resize.c:109: warning: long long unsigned int format, __u64 arg (arg 4)

Signed-off-by: Randy Dunlap [EMAIL PROTECTED]
---

 fs/ext4/resize.c |   23 ++-
 1 files changed, 14 insertions(+), 9 deletions(-)

diff -Naurp linux-2619-rc2g4/fs/ext4/resize.c~ext4_printk 
linux-2619-rc2g4/fs/ext4/resize.c
--- linux-2619-rc2g4/fs/ext4/resize.c~ext4_printk   2006-10-20 
17:38:30.834843000 -0700
+++ linux-2619-rc2g4/fs/ext4/resize.c   2006-10-22 20:17:37.490397000 -0700
@@ -69,44 +69,49 @@ static int verify_group_input(struct sup
else if (outside(input-block_bitmap, start, end))
ext4_warning(sb, __FUNCTION__,
 Block bitmap not in group (block %llu),
-input-block_bitmap);
+(unsigned long long)input-block_bitmap);
else if (outside(input-inode_bitmap, start, end))
ext4_warning(sb, __FUNCTION__,
 Inode bitmap not in group (block %llu),
-input-inode_bitmap);
+(unsigned long long)input-inode_bitmap);
else if (outside(input-inode_table, start, end) ||
 outside(itend - 1, start, end))
ext4_warning(sb, __FUNCTION__,
 Inode table not in group (blocks %llu-%llu),
-input-inode_table, itend - 1);
+(unsigned long long)input-inode_table, itend - 1);
else if (input-inode_bitmap == input-block_bitmap)
ext4_warning(sb, __FUNCTION__,
 Block bitmap same as inode bitmap (%llu),
-input-block_bitmap);
+(unsigned long long)input-block_bitmap);
else if (inside(input-block_bitmap, input-inode_table, itend))
ext4_warning(sb, __FUNCTION__,
 Block bitmap (%llu) in inode table (%llu-%llu),
-input-block_bitmap, input-inode_table, itend-1);
+(unsigned long long)input-block_bitmap,
+(unsigned long long)input-inode_table, itend - 1);
else if (inside(input-inode_bitmap, input-inode_table, itend))
ext4_warning(sb, __FUNCTION__,
 Inode bitmap (%llu) in inode table (%llu-%llu),
-input-inode_bitmap, input-inode_table, itend-1);
+(unsigned long long)input-inode_bitmap,
+(unsigned long long)input-inode_table, itend - 1);
else if (inside(input-block_bitmap, start, metaend))
ext4_warning(sb, __FUNCTION__,
 Block bitmap (%llu) in GDT table
  (%llu-%llu),
-input-block_bitmap, start, metaend - 1);
+(unsigned long long)input-block_bitmap,
+start, metaend - 1);
else if (inside(input-inode_bitmap, start, metaend))
ext4_warning(sb, __FUNCTION__,
 Inode bitmap (%llu) in GDT table
  (%llu-%llu),
-input-inode_bitmap, start, metaend - 1);
+(unsigned long long)input-inode_bitmap,
+start, metaend - 1);
else if (inside(input-inode_table, start, metaend) ||
 inside(itend - 1, start, metaend))
ext4_warning(sb, __FUNCTION__,
 Inode table (%llu-%llu) overlaps
 GDT table (%llu-%llu),
-input-inode_table, itend - 1, start, metaend - 1);
+(unsigned long long)input-inode_table,
+itend - 1, start, metaend - 1);
else
err = 0;
brelse(bh);


---
-
To unsubscribe from this list: send the line unsubscribe linux-ext4 in
the body of a message to [EMAIL PROTECTED]
More majordomo