Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block size

2007-10-18 Thread Christoph Lameter 
On Wed, 17 Oct 2007, Andrew Morton wrote:

 b) what happens when an old ext2 driver tries to read and/or write this
directory entry?  Do we need a compat flag for it?

Old ext2 only supports up to 4k

include/linux/ext2_fs.h:

#define EXT2_MIN_BLOCK_SIZE 1024
#define EXT2_MAX_BLOCK_SIZE 4096
#define EXT2_MIN_BLOCK_LOG_SIZE   10

Should fail to mount the volume since the block size is too large.

-
To unsubscribe from this list: send the line unsubscribe linux-ext4 in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] jbd: JBD replace jbd_kmalloc with kmalloc

2007-10-08 Thread Christoph Lameter 
On Fri, 5 Oct 2007, Mingming Cao wrote:

 Index: linux-2.6.23-rc9/fs/jbd/transaction.c
 ===
 --- linux-2.6.23-rc9.orig/fs/jbd/transaction.c2007-10-05 
 12:08:08.0 -0700
 +++ linux-2.6.23-rc9/fs/jbd/transaction.c 2007-10-05 12:08:29.0 
 -0700
 @@ -96,8 +96,8 @@ static int start_this_handle(journal_t *
  
  alloc_transaction:
   if (!journal-j_running_transaction) {
 - new_transaction = jbd_kmalloc(sizeof(*new_transaction),
 - GFP_NOFS);
 + new_transaction = kmalloc(sizeof(*new_transaction),
 + GFP_NOFS|__GFP_NOFAIL);


Why was a __GFP_NOFAIL added here? I do not see a use of jbd_rep_kmalloc?

 -#define jbd_kmalloc(size, flags) \
 - __jbd_kmalloc(__FUNCTION__, (size), (flags), journal_oom_retry)

journal_oom_retry is no longer used?
-
To unsubscribe from this list: send the line unsubscribe linux-ext4 in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] jbd2: JBD replace jbd2_kmalloc with kmalloc

2007-10-08 Thread Christoph Lameter 
Acked-by: Christoph Lameter [EMAIL PROTECTED]


-
To unsubscribe from this list: send the line unsubscribe linux-ext4 in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] ext4: Avoid rec_len overflow with 64KB block size

2007-10-01 Thread Christoph Lameter 
Acked-by: Christoph Lameter [EMAIL PROTECTED]


-
To unsubscribe from this list: send the line unsubscribe linux-ext4 in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block size

2007-10-01 Thread Christoph Lameter 
Acked-by: Christoph Lameter [EMAIL PROTECTED]

-
To unsubscribe from this list: send the line unsubscribe linux-ext4 in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ext3: Support large blocksize up to PAGESIZE

2007-10-01 Thread Christoph Lameter 
Acked-by: Christoph Lameter [EMAIL PROTECTED]

-
To unsubscribe from this list: send the line unsubscribe linux-ext4 in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] ext3: Avoid rec_len overflow with 64KB block size

2007-10-01 Thread Christoph Lameter 
[Note that these will also be useful for 64K IA64 configurations]

Acked-by: Christoph Lameter [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe linux-ext4 in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] JBD slab cleanups

2007-09-14 Thread Christoph Lameter 
Thanks Mingming.


-
To unsubscribe from this list: send the line unsubscribe linux-ext4 in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RFC 1/4] Large Blocksize support for Ext2/3/4

2007-08-29 Thread Christoph Lameter 
On Wed, 29 Aug 2007, Mingming Cao wrote:

 It's quite simple to support large block size in ext2/3/4, mostly just
 enlarge the block size limit.  But it is NOT possible to have 64kB
 blocksize on ext2/3/4 without some changes to the directory handling
 code.  The reason is that an empty 64kB directory block would have a
 rec_len == (__u16)2^16 == 0, and this would cause an error to be hit in
 the filesystem.  The proposed solution is to put 2 empty records in such
 a directory, or to special-case an impossible value like rec_len =
 0x to handle this. 

Ahh. Good.

I could add the path to the large blocksize patchset?

-
To unsubscribe from this list: send the line unsubscribe linux-ext4 in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RFC/PATCH] ext3: remove inode constructor

2007-05-04 Thread Christoph Lameter 
On Fri, 4 May 2007, Pekka J Enberg wrote:

 Index: 2.6/fs/ext3/super.c
 ===
 --- 2.6.orig/fs/ext3/super.c  2007-05-04 12:57:09.0 +0300
 +++ 2.6/fs/ext3/super.c   2007-05-04 13:01:27.0 +0300
 @@ -444,17 +444,26 @@ static struct kmem_cache *ext3_inode_cac
  static struct inode *ext3_alloc_inode(struct super_block *sb)
  {
   struct ext3_inode_info *ei;
 + struct inode *inode;
  
   ei = kmem_cache_alloc(ext3_inode_cachep, GFP_NOFS);
   if (!ei)
   return NULL;
 +INIT_LIST_HEAD(ei-i_orphan);
 +#ifdef CONFIG_EXT3_FS_XATTR
 +init_rwsem(ei-xattr_sem);
 +#endif
 +mutex_init(ei-truncate_mutex);

^^^ whitespace issues

Also could this be generalized to also apply to the generic inode 
allocation in fs/inode.c?

-
To unsubscribe from this list: send the line unsubscribe linux-ext4 in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html