Re: [EXT4 set 4][PATCH 2/5] i_version: Add hi 32 bit inode version on ext4 on-disk inode

2007-07-10 Thread Andrew Morton
On Sun, 01 Jul 2007 03:37:16 -0400
Mingming Cao [EMAIL PROTECTED] wrote:

 This patch adds a 32-bit i_version_hi field to ext4_inode, which can be used 
 for 64-bit inode versions. This field will store the higher 32 bits of the 
 version, while Jean Noel's patch has added support to store the lower 32-bits 
 in osd1.linux1.l_i_version.

Please wordwrap this changelog entry to less than 80 columns.  Well, less
than 258, anyway ;)

 Signed-off-by: Mingming Cao [EMAIL PROTECTED]
 Signed-off-by: Andreas Dilger [EMAIL PROTECTED]
 Signed-off-by: Kalpak Shah [EMAIL PROTECTED]
 ---
 Index: linux-2.6.21/include/linux/ext4_fs.h
 ===
 --- linux-2.6.21.orig/include/linux/ext4_fs.h
 +++ linux-2.6.21/include/linux/ext4_fs.h
 @@ -342,6 +342,7 @@ struct ext4_inode {
   __le32  i_atime_extra;  /* extra Access time  (nsec  2 | epoch) */
   __le32  i_crtime;   /* File Creation time */
   __le32  i_crtime_extra; /* extra FileCreationtime (nsec  2 | epoch) */
 + __le32  i_version_hi;   /* high 32 bits for 64-bit version */
  };

Aren't there forward- backward-compatibility issues here?  How does the
filesystem driver work out whether this field is present and valid?

The changelog should describe this design issue.
-
To unsubscribe from this list: send the line unsubscribe linux-ext4 in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[EXT4 set 4][PATCH 2/5] i_version: Add hi 32 bit inode version on ext4 on-disk inode

2007-07-01 Thread Mingming Cao
This patch adds a 32-bit i_version_hi field to ext4_inode, which can be used 
for 64-bit inode versions. This field will store the higher 32 bits of the 
version, while Jean Noel's patch has added support to store the lower 32-bits 
in osd1.linux1.l_i_version.

Signed-off-by: Mingming Cao [EMAIL PROTECTED]
Signed-off-by: Andreas Dilger [EMAIL PROTECTED]
Signed-off-by: Kalpak Shah [EMAIL PROTECTED]
---
Index: linux-2.6.21/include/linux/ext4_fs.h
===
--- linux-2.6.21.orig/include/linux/ext4_fs.h
+++ linux-2.6.21/include/linux/ext4_fs.h
@@ -342,6 +342,7 @@ struct ext4_inode {
__le32  i_atime_extra;  /* extra Access time  (nsec  2 | epoch) */
__le32  i_crtime;   /* File Creation time */
__le32  i_crtime_extra; /* extra FileCreationtime (nsec  2 | epoch) */
+   __le32  i_version_hi;   /* high 32 bits for 64-bit version */
 };

 #define i_size_highi_dir_acl


-
To unsubscribe from this list: send the line unsubscribe linux-ext4 in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html