Re: [EXT4 set 1][PATCH 1/2] Add noextents mount option

2007-07-10 Thread Mingming Cao
On Tue, 2007-07-10 at 16:30 -0700, Andrew Morton wrote:
> On Sun, 01 Jul 2007 03:35:48 -0400
> Mingming Cao <[EMAIL PROTECTED]> wrote:
> 
> > Add a mount option to turn off extents.
> 
> Please update the changelog to describe the reason for making this change.
> 
> 

Sure, I will update the changelog, mainly this is for wide testing of
extents feature in ext4dev.

> > Signed-off-by: Mingming Cao <[EMAIL PROTECTED]>
> > ---
> > Index: linux-2.6.22-rc4/fs/ext4/super.c
> > ===
> > --- linux-2.6.22-rc4.orig/fs/ext4/super.c   2007-06-11 17:02:18.0 
> > -0700
> > +++ linux-2.6.22-rc4/fs/ext4/super.c2007-06-11 17:02:22.0 
> > -0700
> > @@ -725,7 +725,7 @@
> > Opt_usrjquota, Opt_grpjquota, Opt_offusrjquota, Opt_offgrpjquota,
> > Opt_jqfmt_vfsold, Opt_jqfmt_vfsv0, Opt_quota, Opt_noquota,
> > Opt_ignore, Opt_barrier, Opt_err, Opt_resize, Opt_usrquota,
> > -   Opt_grpquota, Opt_extents,
> > +   Opt_grpquota, Opt_extents, Opt_noextents,
> >  };
> >  
> >  static match_table_t tokens = {
> > @@ -776,6 +776,7 @@
> > {Opt_usrquota, "usrquota"},
> > {Opt_barrier, "barrier=%u"},
> > {Opt_extents, "extents"},
> > +   {Opt_noextents, "noextents"},
> > {Opt_err, NULL},
> > {Opt_resize, "resize"},
> >  };
> > @@ -,6 +1112,9 @@
> > case Opt_extents:
> > set_opt (sbi->s_mount_opt, EXTENTS);
> > break;
> > +   case Opt_noextents:
> > +   clear_opt (sbi->s_mount_opt, EXTENTS);
> > +   break;
> > default:
> > printk (KERN_ERR
> > "EXT4-fs: Unrecognized mount option \"%s\" "
> > 
> > 
> > -
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to [EMAIL PROTECTED]
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [EXT4 set 1][PATCH 1/2] Add noextents mount option

2007-07-10 Thread Andrew Morton
On Sun, 01 Jul 2007 03:35:48 -0400
Mingming Cao <[EMAIL PROTECTED]> wrote:

> Add a mount option to turn off extents.

Please update the changelog to describe the reason for making this change.


> Signed-off-by: Mingming Cao <[EMAIL PROTECTED]>
> ---
> Index: linux-2.6.22-rc4/fs/ext4/super.c
> ===
> --- linux-2.6.22-rc4.orig/fs/ext4/super.c 2007-06-11 17:02:18.0 
> -0700
> +++ linux-2.6.22-rc4/fs/ext4/super.c  2007-06-11 17:02:22.0 -0700
> @@ -725,7 +725,7 @@
>   Opt_usrjquota, Opt_grpjquota, Opt_offusrjquota, Opt_offgrpjquota,
>   Opt_jqfmt_vfsold, Opt_jqfmt_vfsv0, Opt_quota, Opt_noquota,
>   Opt_ignore, Opt_barrier, Opt_err, Opt_resize, Opt_usrquota,
> - Opt_grpquota, Opt_extents,
> + Opt_grpquota, Opt_extents, Opt_noextents,
>  };
>  
>  static match_table_t tokens = {
> @@ -776,6 +776,7 @@
>   {Opt_usrquota, "usrquota"},
>   {Opt_barrier, "barrier=%u"},
>   {Opt_extents, "extents"},
> + {Opt_noextents, "noextents"},
>   {Opt_err, NULL},
>   {Opt_resize, "resize"},
>  };
> @@ -,6 +1112,9 @@
>   case Opt_extents:
>   set_opt (sbi->s_mount_opt, EXTENTS);
>   break;
> + case Opt_noextents:
> + clear_opt (sbi->s_mount_opt, EXTENTS);
> + break;
>   default:
>   printk (KERN_ERR
>   "EXT4-fs: Unrecognized mount option \"%s\" "
> 
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [EMAIL PROTECTED]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html