Re: [f2fs-dev] [PATCH] f2fs: fix up f2fs_lookup tracepoints

2021-09-22 Thread Chao Yu

On 2021/9/21 22:37, Gao Xiang wrote:

Fix up a misuse that the filename pointer isn't always valid in
the ring buffer, and we should copy the content instead.

Fixes: 0c5e36db17f5 ("f2fs: trace f2fs_lookup")
Signed-off-by: Gao Xiang 


Reviewed-by: Chao Yu 

Thanks,


___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


[f2fs-dev] [PATCH] f2fs: fix up f2fs_lookup tracepoints

2021-09-21 Thread Gao Xiang
Fix up a misuse that the filename pointer isn't always valid in
the ring buffer, and we should copy the content instead.

Fixes: 0c5e36db17f5 ("f2fs: trace f2fs_lookup")
Signed-off-by: Gao Xiang 
---
 include/trace/events/f2fs.h | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h
index 4e881d9..4cb055a 100644
--- a/include/trace/events/f2fs.h
+++ b/include/trace/events/f2fs.h
@@ -807,20 +807,20 @@
TP_STRUCT__entry(
__field(dev_t,  dev)
__field(ino_t,  ino)
-   __field(const char *,   name)
+   __string(name,  dentry->d_name.name)
__field(unsigned int, flags)
),
 
TP_fast_assign(
__entry->dev= dir->i_sb->s_dev;
__entry->ino= dir->i_ino;
-   __entry->name   = dentry->d_name.name;
+   __assign_str(name, dentry->d_name.name);
__entry->flags  = flags;
),
 
TP_printk("dev = (%d,%d), pino = %lu, name:%s, flags:%u",
show_dev_ino(__entry),
-   __entry->name,
+   __get_str(name),
__entry->flags)
 );
 
@@ -834,7 +834,7 @@
TP_STRUCT__entry(
__field(dev_t,  dev)
__field(ino_t,  ino)
-   __field(const char *,   name)
+   __string(name,  dentry->d_name.name)
__field(nid_t,  cino)
__field(int,err)
),
@@ -842,14 +842,14 @@
TP_fast_assign(
__entry->dev= dir->i_sb->s_dev;
__entry->ino= dir->i_ino;
-   __entry->name   = dentry->d_name.name;
+   __assign_str(name, dentry->d_name.name);
__entry->cino   = ino;
__entry->err= err;
),
 
TP_printk("dev = (%d,%d), pino = %lu, name:%s, ino:%u, err:%d",
show_dev_ino(__entry),
-   __entry->name,
+   __get_str(name),
__entry->cino,
__entry->err)
 );
-- 
1.8.3.1



___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel