FAI 4.2.1, LVM fixes included

2014-07-09 Thread Thomas Lange 
FAI 4.2.1 is now released. It includes several LVM related fixes in
setup-storage.

Please keep in mind that you should use liblinux-lvm-perl version
0.17-2 or newer to get all fixes. This version is included in the
package repository at fai-project.org.
-- 
regards Thomas

RE: FAI 4.2.1, LVM fixes included

2014-07-09 Thread Bjarne Bertilsson 
Does this fix preserve with lvm on top of raid?

Thanks!

BR
/ Bjarne

-Original Message-
From: linux-fai [mailto:linux-fai-boun...@uni-koeln.de] On Behalf Of Thomas 
Lange
Sent: den 9 juli 2014 16:29
To: FAI Mailing
Subject: FAI 4.2.1, LVM fixes included

FAI 4.2.1 is now released. It includes several LVM related fixes in 
setup-storage.

Please keep in mind that you should use liblinux-lvm-perl version
0.17-2 or newer to get all fixes. This version is included in the package 
repository at fai-project.org.
--
regards Thomas

RE: FAI 4.2.1, LVM fixes included

2014-07-09 Thread Kerim Güney 
I did test it with LVM preserve and RAID separately; can't remember if I tested 
it with both in the same config, though I'm confident that it will work. Just 
to make sure, you can send me a config file and I will check it out and get 
back to you.

Kerim

On 9 Temmuz 2014 16:40:36 CEST, Bjarne Bertilsson  
wrote:
>Does this fix preserve with lvm on top of raid?
>
>Thanks!
>
>BR
>/ Bjarne
>
>-Original Message-
>From: linux-fai [mailto:linux-fai-boun...@uni-koeln.de] On Behalf Of
>Thomas Lange
>Sent: den 9 juli 2014 16:29
>To: FAI Mailing
>Subject: FAI 4.2.1, LVM fixes included
>
>FAI 4.2.1 is now released. It includes several LVM related fixes in
>setup-storage.
>
>Please keep in mind that you should use liblinux-lvm-perl version
>0.17-2 or newer to get all fixes. This version is included in the
>package repository at fai-project.org.
>--
>regards Thomas

-- 
Sent from my phone. Please excuse my brevity.

Re: FAI 4.2.1, LVM fixes included

2014-07-10 Thread Thomas Neumann 
On Wednesday 09 July 2014 16:28:37 Thomas Lange wrote:
> FAI 4.2.1 is now released. It includes several LVM related fixes in
> setup-storage.

I just had a look at the patches that have been applied and noticed:

https://github.com/faiproject/fai/commit/aa5d11e0d1a93bc986e2d0c7fbd086e794fe50e1
"Fixes wipefs problem when attempting to preserve lv or vg"

  I'm pretty sure the description is wrong. As far as I understand the modified
  lines apply only if the logical volume is NOT to be preserved.

https://github.com/faiproject/fai/commit/0ecef06a9ab31261b7d090d484c82d35577cd33a
Closes #670614; Improved bugfix by Christian Kreidl

  Since it was already requested by Thomas L. to split patches to make them
  easier to understand I'm pointing out this one. IMHO this patch should have
  been split into an 'improve the code' and 'apply actual fix' part. It adds 13
  and removes 21 lines, but I ~think~ the actual fix is removing 6 lines. I'm
  unable to say whether the changes to 739-744 are 'bugfix' or 'improvement'.


Apart from that it would have been nice to announce these changes on the fai-
devel list before making the actual release. (Really - what is fai-devel for? 
It's pretty much dead.) There were 16 commits between the last mail on fai-
devel and today. I think at least a 'setup-storage / lvm was patched and is 
supposed to be fixed now - please try the ... branch' would have been nice.

bye
thomas

Re: FAI 4.2.1, LVM fixes included

2014-07-10 Thread Kerim Güney 


On 07/10/2014 11:11 AM, Thomas Neumann wrote:

On Wednesday 09 July 2014 16:28:37 Thomas Lange wrote:

FAI 4.2.1 is now released. It includes several LVM related fixes in
setup-storage.

I just had a look at the patches that have been applied and noticed:

https://github.com/faiproject/fai/commit/aa5d11e0d1a93bc986e2d0c7fbd086e794fe50e1
"Fixes wipefs problem when attempting to preserve lv or vg"

   I'm pretty sure the description is wrong. As far as I understand the modified
   lines apply only if the logical volume is NOT to be preserved.


That particular block of code in which those modified lines are nested 
is only executed if the user attempts to preserve an LV and as such the 
description is correct. The commit message doesn't imply that wipefs is 
called on an LV that's marked to be preserved.



https://github.com/faiproject/fai/commit/0ecef06a9ab31261b7d090d484c82d35577cd33a
Closes #670614; Improved bugfix by Christian Kreidl

   Since it was already requested by Thomas L. to split patches to make them
   easier to understand I'm pointing out this one. IMHO this patch should have
   been split into an 'improve the code' and 'apply actual fix' part. It adds 13
   and removes 21 lines, but I ~think~ the actual fix is removing 6 lines. I'm
   unable to say whether the changes to 739-744 are 'bugfix' or 'improvement'.


Valid point. The patch was a bit bigger, because it removed the previous 
bugfix and I agree that it should have been divided into at least two 
patches.


Best regards
Kerim Gueney

Re: FAI 4.2.1, LVM fixes included

2014-07-10 Thread Kerim Güney 


On 07/09/2014 04:40 PM, Bjarne Bertilsson wrote:

Does this fix preserve with lvm on top of raid?


Hey Bjarne,

I tried out your config just now and unfortunately it didn't work. In 
fact, there seems to be a bug with LVM preservation in general that I 
have missed yesterday, though I'll fix it today or tomorrow and will let 
you know as soon as I find out whether your config works or not.



Best Regards
Kerim Gueney

Re: FAI 4.2.1, LVM fixes included

2014-07-17 Thread Kerim Güney 


Hello Bjarne,

We recently applied a patch to fix your issues, I also tried out your 
config and it should work now. You can get the packages from the jenkins 
repo ( http://fai-project.org/sources/ ). Would appreciate it if you 
could report back and tell us whether it works or not.


Best regards
Kerim