Re: cramfs b0rken on HIGHMEM machines

[Alan Cox]

> just look at fs/cramfs/inode.c:cramfs_read_page()
> It uses page_address instead of kmap().
> 
> I would have fixed it myself, but I don't know, how I should
> kunmap() it, once we have memory pressure.

Take a look at ramfs. kmap isnt really a 'pressure' thing. You want to kunmap
the page as soon as you can. The kmap/unmap operations are fairly fast but
there is a limited pool of maps.

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAIL PROTECTED]

cramfs b0rken on HIGHMEM machines

[Ingo Oeser]

Hi there,

just look at fs/cramfs/inode.c:cramfs_read_page()

It uses page_address instead of kmap().

I would have fixed it myself, but I don't know, how I should
kunmap() it, once we have memory pressure.

BTW: I bought an SMP machine with 1GB RAM yesterday to test such
   cases and found the first BUG now.

Yes I know, that nobody build embedded machines with HIGHMEM
support, but it's still a BUG right? ;-)

Regards

Ingo Oeser
-- 
10.+11.03.2001 - 3. Chemnitzer LinuxTag 
  been there and had much fun   
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAIL PROTECTED]