Re: [PATCH v3] gpio: dwapb: use a second irq chip

[Jamie Iles]

On Mon, May 26, 2014 at 10:58:14PM +0200, Sebastian Andrzej Siewior wrote:
 Right new have one irq chip running always in level mode. It would nicer
 to have two irq chips where one is handling level type interrupts and
 the other one is doing edge interrupts. So we can have at runtime two users
 where one is using edge and the other level.
 
 Acked-by: Alan Tull delicious.qui...@gmail.com
 Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de

Acked-by: Jamie Iles ja...@jamieiles.com
--
To unsubscribe from this list: send the line unsubscribe linux-gpio in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] gpio: dwapb: drop irq_setup_generic_chip()

[Jamie Iles]

On Tue, Mar 25, 2014 at 09:37:50PM +0100, Linus Walleij wrote:
 Aha Jamie not even on the original thread. Here.
 
 On Tue, Mar 25, 2014 at 9:37 PM, Linus Walleij linus.wall...@linaro.org 
 wrote:
  On Thu, Mar 20, 2014 at 8:55 PM, Sebastian Andrzej Siewior
  bige...@linutronix.de wrote:
 
  This looks kinda wrong I didn't manage to fully test it.
  The driver calls irq_alloc_domain_generic_chips() which creates a gc and
  adds it to gc_list. The driver later then calls irq_setup_generic_chip()
  which also initializes the gc and adds it to the gc_list() and this
  corrupts the list.
  I can't find a single chip in tree which uses both functions so I think
  that irq_setup_generic_chip() can be dropped.
 
  Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de
 
  Jamie: comments?

I don't have anything to add to either yours or Alan's comments.  I'll 
be more than happy to review the versions with the generic helpers if 
I'm copied onto the review.

Thanks,

Jamie
--
To unsubscribe from this list: send the line unsubscribe linux-gpio in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html