Re: [Linux-ha-dev] Regarding to (Patch #2434: Latest addition to external/riloe

2010-09-23 Thread Dejan Muhamedagic
Hi,

On Sun, Aug 29, 2010 at 11:51:54AM +0200, Holger Teutsch wrote:
> Jochen,
> your method getconfignames returns *all* parameters.
> 
> [1.62]  if cmd == 'getconfignames':
> [1.63] -for arg in [ "hostlist", "ilo_hostname", "ilo_user", 
> "ilo_password", "ilo_can_reset", "ilo_protocol", "ilo_powerdown_method"]:
> [1.64] +for arg in [ "hostlist", "ilo_hostname", "ilo_user", 
> "ilo_password", "ilo_can_reset", "ilo_protocol", "ilo_powerdown_method", 
> "ilo_proxyhost", "ilo_proxyport"]:
> 
> I think that "getconfignames" should only return the *required* parameters. 
> Else you get a warning logged by 

There could still be some installations which require all
parameters to be shown.

> lib/plugins/stonith/external.c (lines 416 to 420) for each unspecified  (e.g. 
> *optional*) parameter.

Those messages have now reduced severity. Unfortunately, they're
also dumped to stdout which makes the pacemaker v1.1 complain
about not being able to parse the line. The issue is tracked in
https://bugzilla.novell.com/show_bug.cgi?id=639165

Thanks,

Dejan

> Regards
> Holger
> ___
> WEB.DE DSL SOMMER-SPECIAL: Surf & Phone Flat 16.000 für 
> nur 19,99 ¿/mtl.!* http://web.de/DSL-Doppel-Flatrate/
> ___
> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
___
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


[Linux-ha-dev] Regarding to (Patch #2434: Latest addition to external/riloe

2010-08-29 Thread Holger Teutsch
Jochen,
your method getconfignames returns *all* parameters.

[1.62]  if cmd == 'getconfignames':
[1.63] -for arg in [ "hostlist", "ilo_hostname", "ilo_user", 
"ilo_password", "ilo_can_reset", "ilo_protocol", "ilo_powerdown_method"]:
[1.64] +for arg in [ "hostlist", "ilo_hostname", "ilo_user", 
"ilo_password", "ilo_can_reset", "ilo_protocol", "ilo_powerdown_method", 
"ilo_proxyhost", "ilo_proxyport"]:

I think that "getconfignames" should only return the *required* parameters. 
Else you get a warning logged by 

lib/plugins/stonith/external.c (lines 416 to 420) for each unspecified  (e.g. 
*optional*) parameter.

Regards
Holger
___
WEB.DE DSL SOMMER-SPECIAL: Surf & Phone Flat 16.000 für 
nur 19,99 ¿/mtl.!* http://web.de/DSL-Doppel-Flatrate/
___
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/