RE: Ryzen 2700 Temperature offset?
Hi Rudolf, Yeah, let me do some checking. I was already aware that our docs were missing this information; need to check if there are actual plans to address or not. Best Regards, Jon > -Original Message- > From: Rudolf Marek > Sent: Friday, June 15, 2018 4:57 PM > To: Kai-Heng Feng ; Grimm, Jon > > Cc: Guenter Roeck ; Chris Ouellet > ; linux-hwmon@vger.kernel.org; Linux Kernel > Mailing List > Subject: Re: Ryzen 2700 Temperature offset? > > Hi Jon, > > Please can you help? > > Thanks > Rudolf > > > Dne 10.6.2018 v 07:14 Guenter Roeck napsal(a): > > On Sun, Jun 10, 2018 at 03:03:47AM +0800, Kai-Heng Feng wrote: > >> at 23:49, Guenter Roeck wrote: > >> > >>> On Thu, Jun 07, 2018 at 11:03:13AM +0800, Kai Heng Feng wrote: > Hi Guenter, > > A user thinks the Ryzen 2700 temperature may not be correct [1]. > Can you take a look when you have time? Thanks. > > Also, where can I find all these temperature offsets? I googled but > with no result. > >>> Problem is that the offsets are not documented in public, making it > >>> difficult to find out. For Ryzen 2700, there is currently no offset > >>> configured; I was told that there is none. For Ryzen 2700X, the > >>> offset is 10 degrees C. > >> > >> I am still quite interesting where you get this information... > >> > > Primarily lots of online research. Windows tools usually support the > > offsets, so screendumps help in some cases. > > > >>> > [1] https://bugs.launchpad.net/bugs/1774817 > >>> > >>> The key here is the commit mentioned in the log (1b59788979acd). It > >>> does not only adjust the per-CPU offset, but also takes a > >>> configurable offset of 49 degrees C into account. You'll need to > >>> apply that patch in your kernel, or the temperature may be off by 49 > degrees C. > >> > >> So unless AMD shares these offsets value, we can never know what > >> correct offsets are? > >> > > Unfortunately that is correct. > > > > AFAIK the information is available from AMD under NDA. I can not sign > > such an NDA, and even if I could and would, I could not use the > > information in an open source driver. Kind of a loose-loose situation. > > If you (Canonical) have any influence at AMD, it might be useful to > > let them know that their policy is not very helpful. > > > > Guenter > > > > > >> Kai-Heng > >> > >>> > >>> Hope this helps. If not, please let me know. Note that I am > >>> travelling; responses may be delayed. > >>> > >>> Guenter > >> > >> > >> -- > >> To unsubscribe from this list: send the line "unsubscribe > >> linux-hwmon" in the body of a message to majord...@vger.kernel.org > >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-hwmon" > > in the body of a message to majord...@vger.kernel.org More majordomo > > info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Ryzen 2700 Temperature offset?
Hi Jon, Please can you help? Thanks Rudolf Dne 10.6.2018 v 07:14 Guenter Roeck napsal(a): > On Sun, Jun 10, 2018 at 03:03:47AM +0800, Kai-Heng Feng wrote: >> at 23:49, Guenter Roeck wrote: >> >>> On Thu, Jun 07, 2018 at 11:03:13AM +0800, Kai Heng Feng wrote: Hi Guenter, A user thinks the Ryzen 2700 temperature may not be correct [1]. Can you take a look when you have time? Thanks. Also, where can I find all these temperature offsets? I googled but with no result. >>> Problem is that the offsets are not documented in public, making it >>> difficult to find out. For Ryzen 2700, there is currently no offset >>> configured; I was told that there is none. For Ryzen 2700X, the offset >>> is 10 degrees C. >> >> I am still quite interesting where you get this information... >> > Primarily lots of online research. Windows tools usually support the > offsets, so screendumps help in some cases. > >>> [1] https://bugs.launchpad.net/bugs/1774817 >>> >>> The key here is the commit mentioned in the log (1b59788979acd). It does >>> not only adjust the per-CPU offset, but also takes a configurable offset >>> of 49 degrees C into account. You'll need to apply that patch in your >>> kernel, or the temperature may be off by 49 degrees C. >> >> So unless AMD shares these offsets value, we can never know what correct >> offsets are? >> > Unfortunately that is correct. > > AFAIK the information is available from AMD under NDA. I can not sign such an > NDA, and even if I could and would, I could not use the information in an open > source driver. Kind of a loose-loose situation. If you (Canonical) have any > influence at AMD, it might be useful to let them know that their policy is > not very helpful. > > Guenter > > >> Kai-Heng >> >>> >>> Hope this helps. If not, please let me know. Note that I am travelling; >>> responses may be delayed. >>> >>> Guenter >> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in >> the body of a message to majord...@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 16/27] docs: Fix more broken references
Quoting Mauro Carvalho Chehab (2018-06-14 09:09:01) > As we move stuff around, some doc references are broken. Fix some of > them via this script: > ./scripts/documentation-file-ref-check --fix > > Manually checked that produced results are valid. > > Signed-off-by: Mauro Carvalho Chehab > --- > .../devicetree/bindings/clock/st/st,clkgen.txt | 8 > .../devicetree/bindings/clock/ti/gate.txt | 2 +- > .../devicetree/bindings/clock/ti/interface.txt | 2 +- Acked-by: Stephen Boyd -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 16/26] docs: Fix more broken references
On Fri, Jun 15, 2018 at 6:30 PM, Mauro Carvalho Chehab wrote: > As we move stuff around, some doc references are broken. Fix some of > them via this script: > ./scripts/documentation-file-ref-check --fix > > Manually checked that produced results are valid. > > Acked-by: Matthias Brugger > Acked-by: Takashi Iwai > Acked-by: Jeff Kirsher > Acked-by: Guenter Roeck > Signed-off-by: Mauro Carvalho Chehab > --- > .../bindings/clock/st/st,clkgen.txt | 8 > .../devicetree/bindings/clock/ti/gate.txt | 2 +- > .../bindings/clock/ti/interface.txt | 2 +- > .../bindings/cpufreq/cpufreq-mediatek.txt | 2 +- > .../bindings/devfreq/rk3399_dmc.txt | 2 +- > .../bindings/gpu/arm,mali-midgard.txt | 2 +- > .../bindings/gpu/arm,mali-utgard.txt | 2 +- > .../devicetree/bindings/mfd/mt6397.txt| 2 +- > .../devicetree/bindings/mfd/sun6i-prcm.txt| 2 +- > .../bindings/mmc/exynos-dw-mshc.txt | 2 +- > .../devicetree/bindings/net/dsa/ksz.txt | 2 +- > .../devicetree/bindings/net/dsa/mt7530.txt| 2 +- > .../devicetree/bindings/power/fsl,imx-gpc.txt | 2 +- > .../bindings/power/wakeup-source.txt | 2 +- > .../devicetree/bindings/usb/rockchip,dwc3.txt | 2 +- > Documentation/hwmon/ina2xx| 2 +- > Documentation/maintainer/pull-requests.rst| 2 +- > Documentation/translations/ko_KR/howto.rst| 2 +- > MAINTAINERS | 20 +-- > drivers/net/ethernet/intel/Kconfig| 8 > drivers/soundwire/stream.c| 8 > fs/Kconfig.binfmt | 2 +- > fs/binfmt_misc.c | 2 +- > 23 files changed, 41 insertions(+), 41 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/st/st,clkgen.txt > b/Documentation/devicetree/bindings/clock/st/st,clkgen.txt > index 7364953d0d0b..45ac19bfa0a9 100644 > --- a/Documentation/devicetree/bindings/clock/st/st,clkgen.txt > +++ b/Documentation/devicetree/bindings/clock/st/st,clkgen.txt > @@ -31,10 +31,10 @@ This binding uses the common clock binding[1]. > Each subnode should use the binding described in [2]..[7] > > [1] Documentation/devicetree/bindings/clock/clock-bindings.txt > -[3] Documentation/devicetree/bindings/clock/st,clkgen-mux.txt > -[4] Documentation/devicetree/bindings/clock/st,clkgen-pll.txt > -[7] Documentation/devicetree/bindings/clock/st,quadfs.txt > -[8] Documentation/devicetree/bindings/clock/st,flexgen.txt > +[3] Documentation/devicetree/bindings/clock/st/st,clkgen-mux.txt > +[4] Documentation/devicetree/bindings/clock/st/st,clkgen-pll.txt > +[7] Documentation/devicetree/bindings/clock/st/st,quadfs.txt > +[8] Documentation/devicetree/bindings/clock/st/st,flexgen.txt > > > Required properties: > diff --git a/Documentation/devicetree/bindings/clock/ti/gate.txt > b/Documentation/devicetree/bindings/clock/ti/gate.txt > index 03f8fdee62a7..56d603c1f716 100644 > --- a/Documentation/devicetree/bindings/clock/ti/gate.txt > +++ b/Documentation/devicetree/bindings/clock/ti/gate.txt > @@ -10,7 +10,7 @@ will be controlled instead and the corresponding hw-ops for > that is used. > > [1] Documentation/devicetree/bindings/clock/clock-bindings.txt > -[2] Documentation/devicetree/bindings/clock/gate-clock.txt > +[2] Documentation/devicetree/bindings/clock/gpio-gate-clock.txt > [3] Documentation/devicetree/bindings/clock/ti/clockdomain.txt > > Required properties: > diff --git a/Documentation/devicetree/bindings/clock/ti/interface.txt > b/Documentation/devicetree/bindings/clock/ti/interface.txt > index 3111a409fea6..3f4704040140 100644 > --- a/Documentation/devicetree/bindings/clock/ti/interface.txt > +++ b/Documentation/devicetree/bindings/clock/ti/interface.txt > @@ -9,7 +9,7 @@ companion clock finding (match corresponding functional gate > clock) and hardware autoidle enable / disable. > > [1] Documentation/devicetree/bindings/clock/clock-bindings.txt > -[2] Documentation/devicetree/bindings/clock/gate-clock.txt > +[2] Documentation/devicetree/bindings/clock/gpio-gate-clock.txt > > Required properties: > - compatible : shall be one of: > diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt > b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt > index d36f07e0a2bb..0551c78619de 100644 > --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt > +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt > @@ -8,7 +8,7 @@ Required properties: > "intermediate" - A parent of "cpu" clock which is used as > "intermediate" clock > source (usually MAINPLL) when the original CPU PLL > is under > transition and not stable yet. > - Please refer to > Documentation/devicetree/bindings/clk/clock-bindings.txt for > + Please refer to > Documentation/devicetree/b
[PATCH v4 16/26] docs: Fix more broken references
As we move stuff around, some doc references are broken. Fix some of them via this script: ./scripts/documentation-file-ref-check --fix Manually checked that produced results are valid. Acked-by: Matthias Brugger Acked-by: Takashi Iwai Acked-by: Jeff Kirsher Acked-by: Guenter Roeck Signed-off-by: Mauro Carvalho Chehab --- .../bindings/clock/st/st,clkgen.txt | 8 .../devicetree/bindings/clock/ti/gate.txt | 2 +- .../bindings/clock/ti/interface.txt | 2 +- .../bindings/cpufreq/cpufreq-mediatek.txt | 2 +- .../bindings/devfreq/rk3399_dmc.txt | 2 +- .../bindings/gpu/arm,mali-midgard.txt | 2 +- .../bindings/gpu/arm,mali-utgard.txt | 2 +- .../devicetree/bindings/mfd/mt6397.txt| 2 +- .../devicetree/bindings/mfd/sun6i-prcm.txt| 2 +- .../bindings/mmc/exynos-dw-mshc.txt | 2 +- .../devicetree/bindings/net/dsa/ksz.txt | 2 +- .../devicetree/bindings/net/dsa/mt7530.txt| 2 +- .../devicetree/bindings/power/fsl,imx-gpc.txt | 2 +- .../bindings/power/wakeup-source.txt | 2 +- .../devicetree/bindings/usb/rockchip,dwc3.txt | 2 +- Documentation/hwmon/ina2xx| 2 +- Documentation/maintainer/pull-requests.rst| 2 +- Documentation/translations/ko_KR/howto.rst| 2 +- MAINTAINERS | 20 +-- drivers/net/ethernet/intel/Kconfig| 8 drivers/soundwire/stream.c| 8 fs/Kconfig.binfmt | 2 +- fs/binfmt_misc.c | 2 +- 23 files changed, 41 insertions(+), 41 deletions(-) diff --git a/Documentation/devicetree/bindings/clock/st/st,clkgen.txt b/Documentation/devicetree/bindings/clock/st/st,clkgen.txt index 7364953d0d0b..45ac19bfa0a9 100644 --- a/Documentation/devicetree/bindings/clock/st/st,clkgen.txt +++ b/Documentation/devicetree/bindings/clock/st/st,clkgen.txt @@ -31,10 +31,10 @@ This binding uses the common clock binding[1]. Each subnode should use the binding described in [2]..[7] [1] Documentation/devicetree/bindings/clock/clock-bindings.txt -[3] Documentation/devicetree/bindings/clock/st,clkgen-mux.txt -[4] Documentation/devicetree/bindings/clock/st,clkgen-pll.txt -[7] Documentation/devicetree/bindings/clock/st,quadfs.txt -[8] Documentation/devicetree/bindings/clock/st,flexgen.txt +[3] Documentation/devicetree/bindings/clock/st/st,clkgen-mux.txt +[4] Documentation/devicetree/bindings/clock/st/st,clkgen-pll.txt +[7] Documentation/devicetree/bindings/clock/st/st,quadfs.txt +[8] Documentation/devicetree/bindings/clock/st/st,flexgen.txt Required properties: diff --git a/Documentation/devicetree/bindings/clock/ti/gate.txt b/Documentation/devicetree/bindings/clock/ti/gate.txt index 03f8fdee62a7..56d603c1f716 100644 --- a/Documentation/devicetree/bindings/clock/ti/gate.txt +++ b/Documentation/devicetree/bindings/clock/ti/gate.txt @@ -10,7 +10,7 @@ will be controlled instead and the corresponding hw-ops for that is used. [1] Documentation/devicetree/bindings/clock/clock-bindings.txt -[2] Documentation/devicetree/bindings/clock/gate-clock.txt +[2] Documentation/devicetree/bindings/clock/gpio-gate-clock.txt [3] Documentation/devicetree/bindings/clock/ti/clockdomain.txt Required properties: diff --git a/Documentation/devicetree/bindings/clock/ti/interface.txt b/Documentation/devicetree/bindings/clock/ti/interface.txt index 3111a409fea6..3f4704040140 100644 --- a/Documentation/devicetree/bindings/clock/ti/interface.txt +++ b/Documentation/devicetree/bindings/clock/ti/interface.txt @@ -9,7 +9,7 @@ companion clock finding (match corresponding functional gate clock) and hardware autoidle enable / disable. [1] Documentation/devicetree/bindings/clock/clock-bindings.txt -[2] Documentation/devicetree/bindings/clock/gate-clock.txt +[2] Documentation/devicetree/bindings/clock/gpio-gate-clock.txt Required properties: - compatible : shall be one of: diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt index d36f07e0a2bb..0551c78619de 100644 --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt @@ -8,7 +8,7 @@ Required properties: "intermediate" - A parent of "cpu" clock which is used as "intermediate" clock source (usually MAINPLL) when the original CPU PLL is under transition and not stable yet. - Please refer to Documentation/devicetree/bindings/clk/clock-bindings.txt for + Please refer to Documentation/devicetree/bindings/clock/clock-bindings.txt for generic clock consumer properties. - operating-points-v2: Please refer to Documentation/devicetree/bindings/opp/opp.txt for detail. diff --git a/Documentation/devicetree/bindings/devfreq/rk33
Re: [PATCH v3 16/27] docs: Fix more broken references
On 14/06/18 18:09, Mauro Carvalho Chehab wrote: > As we move stuff around, some doc references are broken. Fix some of > them via this script: > ./scripts/documentation-file-ref-check --fix > > Manually checked that produced results are valid. > > Signed-off-by: Mauro Carvalho Chehab for mt6397.txt: Acked-by: Matthias Brugger > --- > .../devicetree/bindings/clock/st/st,clkgen.txt | 8 > .../devicetree/bindings/clock/ti/gate.txt | 2 +- > .../devicetree/bindings/clock/ti/interface.txt | 2 +- > .../bindings/cpufreq/cpufreq-mediatek.txt | 2 +- > .../devicetree/bindings/devfreq/rk3399_dmc.txt | 2 +- > .../bindings/gpu/arm,mali-midgard.txt | 2 +- > .../bindings/gpu/arm,mali-utgard.txt | 2 +- > .../devicetree/bindings/mfd/mt6397.txt | 2 +- > .../devicetree/bindings/mfd/sun6i-prcm.txt | 2 +- > .../devicetree/bindings/mmc/exynos-dw-mshc.txt | 2 +- > .../devicetree/bindings/net/dsa/ksz.txt| 2 +- > .../devicetree/bindings/net/dsa/mt7530.txt | 2 +- > .../devicetree/bindings/power/fsl,imx-gpc.txt | 2 +- > .../bindings/power/wakeup-source.txt | 2 +- > .../devicetree/bindings/usb/rockchip,dwc3.txt | 2 +- > Documentation/hwmon/ina2xx | 2 +- > Documentation/maintainer/pull-requests.rst | 2 +- > Documentation/translations/ko_KR/howto.rst | 2 +- > MAINTAINERS| 18 +- > drivers/net/ethernet/intel/Kconfig | 8 > drivers/soundwire/stream.c | 8 > fs/Kconfig.binfmt | 2 +- > fs/binfmt_misc.c | 2 +- > 23 files changed, 40 insertions(+), 40 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/st/st,clkgen.txt > b/Documentation/devicetree/bindings/clock/st/st,clkgen.txt > index 7364953d0d0b..45ac19bfa0a9 100644 > --- a/Documentation/devicetree/bindings/clock/st/st,clkgen.txt > +++ b/Documentation/devicetree/bindings/clock/st/st,clkgen.txt > @@ -31,10 +31,10 @@ This binding uses the common clock binding[1]. > Each subnode should use the binding described in [2]..[7] > > [1] Documentation/devicetree/bindings/clock/clock-bindings.txt > -[3] Documentation/devicetree/bindings/clock/st,clkgen-mux.txt > -[4] Documentation/devicetree/bindings/clock/st,clkgen-pll.txt > -[7] Documentation/devicetree/bindings/clock/st,quadfs.txt > -[8] Documentation/devicetree/bindings/clock/st,flexgen.txt > +[3] Documentation/devicetree/bindings/clock/st/st,clkgen-mux.txt > +[4] Documentation/devicetree/bindings/clock/st/st,clkgen-pll.txt > +[7] Documentation/devicetree/bindings/clock/st/st,quadfs.txt > +[8] Documentation/devicetree/bindings/clock/st/st,flexgen.txt > > > Required properties: > diff --git a/Documentation/devicetree/bindings/clock/ti/gate.txt > b/Documentation/devicetree/bindings/clock/ti/gate.txt > index 03f8fdee62a7..56d603c1f716 100644 > --- a/Documentation/devicetree/bindings/clock/ti/gate.txt > +++ b/Documentation/devicetree/bindings/clock/ti/gate.txt > @@ -10,7 +10,7 @@ will be controlled instead and the corresponding hw-ops for > that is used. > > [1] Documentation/devicetree/bindings/clock/clock-bindings.txt > -[2] Documentation/devicetree/bindings/clock/gate-clock.txt > +[2] Documentation/devicetree/bindings/clock/gpio-gate-clock.txt > [3] Documentation/devicetree/bindings/clock/ti/clockdomain.txt > > Required properties: > diff --git a/Documentation/devicetree/bindings/clock/ti/interface.txt > b/Documentation/devicetree/bindings/clock/ti/interface.txt > index 3111a409fea6..3f4704040140 100644 > --- a/Documentation/devicetree/bindings/clock/ti/interface.txt > +++ b/Documentation/devicetree/bindings/clock/ti/interface.txt > @@ -9,7 +9,7 @@ companion clock finding (match corresponding functional gate > clock) and hardware autoidle enable / disable. > > [1] Documentation/devicetree/bindings/clock/clock-bindings.txt > -[2] Documentation/devicetree/bindings/clock/gate-clock.txt > +[2] Documentation/devicetree/bindings/clock/gpio-gate-clock.txt > > Required properties: > - compatible : shall be one of: > diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt > b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt > index d36f07e0a2bb..0551c78619de 100644 > --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt > +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt > @@ -8,7 +8,7 @@ Required properties: > "intermediate" - A parent of "cpu" clock which is used as > "intermediate" clock > source (usually MAINPLL) when the original CPU PLL is > under > transition and not stable yet. > - Please refer to > Documentation/devicetree/bindings/clk/clock-bindings.txt for > + Please refer to > Documentation/devicetree/bindings/clock/clock-bindings.txt for > ge
