[PATCH 2/2] hwmon: Remove multiple space after dot

2018-11-29 Thread Corentin Labbe
This patch remove extra space after a dot.
Signed-off-by: Corentin Labbe 
---
 drivers/hwmon/Kconfig | 236 +-
 1 file changed, 118 insertions(+), 118 deletions(-)

diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index 100b7fce1412..3ed91b21f368 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -11,7 +11,7 @@ menuconfig HWMON
  of a system. Most modern motherboards include such a device. It
  can include temperature sensors, voltage sensors, fan speed
  sensors and various additional features such as the ability to
- control the speed of the fans.  If you want this support you
+ control the speed of the fans. If you want this support you
  should say Y here and also to the specific driver(s) for your
  sensors chip(s) below.
 
@@ -19,7 +19,7 @@ menuconfig HWMON
  sensors-detect script from the lm_sensors package.  Read
   for details.
 
- This support can also be built as a module.  If so, the module
+ This support can also be built as a module. If so, the module
  will be called hwmon.
 
 if HWMON
@@ -46,7 +46,7 @@ config SENSORS_AB8500
  AB8500 die and two GPADC channels. The GPADC channel are preferably
  used to access sensors outside the AB8500 chip.
 
- This driver can also be built as a module.  If so, the module
+ This driver can also be built as a module. If so, the module
  will be called abx500-temp.
 
 config SENSORS_ABITUGURU
@@ -61,7 +61,7 @@ config SENSORS_ABITUGURU
  of which motherboards have which revision see
  Documentation/hwmon/abituguru
 
- This driver can also be built as a module.  If so, the module
+ This driver can also be built as a module. If so, the module
  will be called abituguru.
 
 config SENSORS_ABITUGURU3
@@ -75,7 +75,7 @@ config SENSORS_ABITUGURU3
  2005). For more info and a list of which motherboards have which
  revision see Documentation/hwmon/abituguru3
 
- This driver can also be built as a module.  If so, the module
+ This driver can also be built as a module. If so, the module
  will be called abituguru3.
 
 config SENSORS_AD7314
@@ -116,7 +116,7 @@ config SENSORS_ADM1021
  and ADM1023 sensor chips and clones: Maxim MAX1617 and MAX1617A,
  Genesys Logic GL523SM, National Semiconductor LM84 and TI THMC10.
 
- This driver can also be built as a module.  If so, the module
+ This driver can also be built as a module. If so, the module
  will be called adm1021.
 
 config SENSORS_ADM1025
@@ -127,7 +127,7 @@ config SENSORS_ADM1025
  If you say yes here you get support for Analog Devices ADM1025
  and Philips NE1619 sensor chips.
 
- This driver can also be built as a module.  If so, the module
+ This driver can also be built as a module. If so, the module
  will be called adm1025.
 
 config SENSORS_ADM1026
@@ -138,7 +138,7 @@ config SENSORS_ADM1026
  If you say yes here you get support for Analog Devices ADM1026
  sensor chip.
 
- This driver can also be built as a module.  If so, the module
+ This driver can also be built as a module. If so, the module
  will be called adm1026.
 
 config SENSORS_ADM1029
@@ -149,7 +149,7 @@ config SENSORS_ADM1029
  sensor chip.
  Very rare chip, please let us know you use it.
 
- This driver can also be built as a module.  If so, the module
+ This driver can also be built as a module. If so, the module
  will be called adm1029.
 
 config SENSORS_ADM1031
@@ -159,7 +159,7 @@ config SENSORS_ADM1031
  If you say yes here you get support for Analog Devices ADM1031
  and ADM1030 sensor chips.
 
- This driver can also be built as a module.  If so, the module
+ This driver can also be built as a module. If so, the module
  will be called adm1031.
 
 config SENSORS_ADM9240
@@ -170,7 +170,7 @@ config SENSORS_ADM9240
  If you say yes here you get support for Analog Devices ADM9240,
  Dallas DS1780, National Semiconductor LM81 sensor chips.
 
- This driver can also be built as a module.  If so, the module
+ This driver can also be built as a module. If so, the module
  will be called adm9240.
 
 config SENSORS_ADT7X10
@@ -242,7 +242,7 @@ config SENSORS_ADT7475
  ADT7473, ADT7475, ADT7476 and ADT7490 hardware monitoring
  chips.
 
- This driver can also be built as a module.  If so, the module
+ This driver can also be built as a module. If so, the module
  will be called adt7475.
 
 config SENSORS_ASC7621
@@ -255,7 +255,7 @@ config SENSORS_ASC7621
  aSC7621
  aSC7621a
 
- This driver can also be built as a module.  If so, the module
+ This driver can also be built

Re: [PATCH 2/2] hwmon: Remove multiple space after dot

2018-12-01 Thread Guenter Roeck
On Thu, Nov 29, 2018 at 08:09:15PM +, Corentin Labbe wrote:
> This patch remove extra space after a dot.
> Signed-off-by: Corentin Labbe 

Marginal ... I think that used to be common style a long time ago.
Nevertheless, applied to hwmon-next.

Thanks,
Guenter

> ---
>  drivers/hwmon/Kconfig | 236 +-
>  1 file changed, 118 insertions(+), 118 deletions(-)
> 
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 100b7fce1412..3ed91b21f368 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -11,7 +11,7 @@ menuconfig HWMON
> of a system. Most modern motherboards include such a device. It
> can include temperature sensors, voltage sensors, fan speed
> sensors and various additional features such as the ability to
> -   control the speed of the fans.  If you want this support you
> +   control the speed of the fans. If you want this support you
> should say Y here and also to the specific driver(s) for your
> sensors chip(s) below.
>  
> @@ -19,7 +19,7 @@ menuconfig HWMON
> sensors-detect script from the lm_sensors package.  Read
>  for details.
>  
> -   This support can also be built as a module.  If so, the module
> +   This support can also be built as a module. If so, the module
> will be called hwmon.
>  
>  if HWMON
> @@ -46,7 +46,7 @@ config SENSORS_AB8500
> AB8500 die and two GPADC channels. The GPADC channel are preferably
> used to access sensors outside the AB8500 chip.
>  
> -   This driver can also be built as a module.  If so, the module
> +   This driver can also be built as a module. If so, the module
> will be called abx500-temp.
>  
>  config SENSORS_ABITUGURU
> @@ -61,7 +61,7 @@ config SENSORS_ABITUGURU
> of which motherboards have which revision see
> Documentation/hwmon/abituguru
>  
> -   This driver can also be built as a module.  If so, the module
> +   This driver can also be built as a module. If so, the module
> will be called abituguru.
>  
>  config SENSORS_ABITUGURU3
> @@ -75,7 +75,7 @@ config SENSORS_ABITUGURU3
> 2005). For more info and a list of which motherboards have which
> revision see Documentation/hwmon/abituguru3
>  
> -   This driver can also be built as a module.  If so, the module
> +   This driver can also be built as a module. If so, the module
> will be called abituguru3.
>  
>  config SENSORS_AD7314
> @@ -116,7 +116,7 @@ config SENSORS_ADM1021
> and ADM1023 sensor chips and clones: Maxim MAX1617 and MAX1617A,
> Genesys Logic GL523SM, National Semiconductor LM84 and TI THMC10.
>  
> -   This driver can also be built as a module.  If so, the module
> +   This driver can also be built as a module. If so, the module
> will be called adm1021.
>  
>  config SENSORS_ADM1025
> @@ -127,7 +127,7 @@ config SENSORS_ADM1025
> If you say yes here you get support for Analog Devices ADM1025
> and Philips NE1619 sensor chips.
>  
> -   This driver can also be built as a module.  If so, the module
> +   This driver can also be built as a module. If so, the module
> will be called adm1025.
>  
>  config SENSORS_ADM1026
> @@ -138,7 +138,7 @@ config SENSORS_ADM1026
> If you say yes here you get support for Analog Devices ADM1026
> sensor chip.
>  
> -   This driver can also be built as a module.  If so, the module
> +   This driver can also be built as a module. If so, the module
> will be called adm1026.
>  
>  config SENSORS_ADM1029
> @@ -149,7 +149,7 @@ config SENSORS_ADM1029
> sensor chip.
> Very rare chip, please let us know you use it.
>  
> -   This driver can also be built as a module.  If so, the module
> +   This driver can also be built as a module. If so, the module
> will be called adm1029.
>  
>  config SENSORS_ADM1031
> @@ -159,7 +159,7 @@ config SENSORS_ADM1031
> If you say yes here you get support for Analog Devices ADM1031
> and ADM1030 sensor chips.
>  
> -   This driver can also be built as a module.  If so, the module
> +   This driver can also be built as a module. If so, the module
> will be called adm1031.
>  
>  config SENSORS_ADM9240
> @@ -170,7 +170,7 @@ config SENSORS_ADM9240
> If you say yes here you get support for Analog Devices ADM9240,
> Dallas DS1780, National Semiconductor LM81 sensor chips.
>  
> -   This driver can also be built as a module.  If so, the module
> +   This driver can also be built as a module. If so, the module
> will be called adm9240.
>  
>  config SENSORS_ADT7X10
> @@ -242,7 +242,7 @@ config SENSORS_ADT7475
> ADT7473, ADT7475, ADT7476 and ADT7490 hardware monitoring
> chips.
>  
> -   This driver can also be built as a module.  If so, the module
> +   This driver can als

Re: [PATCH 2/2] hwmon: Remove multiple space after dot

2018-12-01 Thread Randy Dunlap
On 12/1/18 12:27 PM, Joe Perches wrote:
> On Thu, 2018-11-29 at 20:09 +, Corentin Labbe wrote:
>> This patch remove extra space after a dot.
> []
>> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> ---
>>  drivers/hwmon/Kconfig | 236 +-
>>  1 file changed, 118 insertions(+), 118 deletions(-)
> []
>> @@ -11,7 +11,7 @@ menuconfig HWMON
>>of a system. Most modern motherboards include such a device. It
>>can include temperature sensors, voltage sensors, fan speed
>>sensors and various additional features such as the ability to
>> -  control the speed of the fans.  If you want this support you
>> +  control the speed of the fans. If you want this support you
>>should say Y here and also to the specific driver(s) for your
>>sensors chip(s) below.
> 
> Please no.

Ack.  No need for such a patch.


-- 
~Randy


Re: [PATCH 2/2] hwmon: Remove multiple space after dot

2018-12-01 Thread Joe Perches
On Thu, 2018-11-29 at 20:09 +, Corentin Labbe wrote:
> This patch remove extra space after a dot.
[]
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
---
>  drivers/hwmon/Kconfig | 236 +-
>  1 file changed, 118 insertions(+), 118 deletions(-)
[]
> @@ -11,7 +11,7 @@ menuconfig HWMON
> of a system. Most modern motherboards include such a device. It
> can include temperature sensors, voltage sensors, fan speed
> sensors and various additional features such as the ability to
> -   control the speed of the fans.  If you want this support you
> +   control the speed of the fans. If you want this support you
> should say Y here and also to the specific driver(s) for your
> sensors chip(s) below.

Please no.

You can't pry two spaces after a period when using a
fixed width font from me.

And the use is nowhere consistent in the kernel as it's
less than 2:1 in favor of one style over the other.

$ git grep -i '[a-z][a-z]\. [a-z][a-z ]' | wc -l
146888
$ git grep -i '[a-z][a-z]\.  [a-z][a-z ]' | wc -l
85195

The kernel Kconfig use ratio is similar.

$ git grep -i '[a-z][a-z]\. [a-z][a-z ]' -- '*/Kconfig*' | wc -l
5389
$ git grep -i '[a-z][a-z]\.  [a-z][a-z ]' -- '*/Kconfig*' | wc -l
2463

And even in this specific file, it's reversed ratio

$ git grep -i '[a-z][a-z]\. [a-z][a-z ]' -- 'drivers/hwmon/Kconfig*' | wc -l
70
$ git grep -i '[a-z][a-z]\.  [a-z][a-z ]' -- 'drivers/hwmon/Kconfig*' | wc -l
129

So if you _really_ wanted to do this, please do the
entire file consistently.

You seemed to do 118 conversions.  Shouldn't there be 129?