Re: [PATCH 05/17] mmc: mmci: Put the device into low power state at system suspend
Linus Walleij writes: > On Tue, Feb 4, 2014 at 8:22 PM, Kevin Hilman wrote: >> Ulf Hansson writes: >> >>> Due to the available runtime PM callbacks, we are now able to put our >>> device into low power state at system suspend. > (...) >> I'm trying to thing of a good reason to not make PM_SLEEP depend on >> PM_RUNTIME for platforms like this. > > Isn't the typical Android platform using PM_SLEEP without using > PM_RUNTIME? No, most Android platforms that I'm aware of use both extensively. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/6] i2c: bcm-kona: register with subsys_initcall
On Wed, Feb 05, 2014 at 10:30:29AM -0500, Alan Stern wrote: > On Wed, 5 Feb 2014, Matt Porter wrote: > > > On Wed, Feb 05, 2014 at 10:08:18AM +0100, Wolfram Sang wrote: > > > On Tue, Feb 04, 2014 at 07:19:07AM -0500, Matt Porter wrote: > > > > > > > Voltage regulators are needed very early due to deferred probe > > > > being incompatible with built-in USB gadget drivers. > > > > > > What does it need to fix those instead? > > > > [added Alan/Felipe for more insight] > > > > Discussion on that topic came about from this submission: > > http://www.spinics.net/lists/linux-usb/msg94217.html > > > > End of it is: > > http://www.spinics.net/lists/linux-usb/msg94731.html > > > > We can either add to the many drivers that already do subsys_initcall() > > for similar reasons...or I can drop this from the series and add gadget > > probe ordering to my TODO list. > > > > In short, it can't be a late_initcall() hack like the original post and > > really could be solved by converting to a real bus (and letting > > deferred probe do its job)..but Alan voiced concerns about that. > > Don't worry too much about what I said. If adding a "gadget" bus will > solve the problem in an appropriate way, and if nobody else objects > (particularly Felipe, who is on vacation now), then go for it. Ok, I'll take a look at what can be done and restart the conversation when Felipe returns. Wolfram: given this, as I mentioned, I'll simply drop this patch from the series and work around it for now. This will probably make Lee and Mark happy to not see subsys_initcall() in the MFD/regulator drivers as well. -Matt -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/6] i2c: bcm-kona: register with subsys_initcall
On Wed, 5 Feb 2014, Matt Porter wrote: > On Wed, Feb 05, 2014 at 10:08:18AM +0100, Wolfram Sang wrote: > > On Tue, Feb 04, 2014 at 07:19:07AM -0500, Matt Porter wrote: > > > > > Voltage regulators are needed very early due to deferred probe > > > being incompatible with built-in USB gadget drivers. > > > > What does it need to fix those instead? > > [added Alan/Felipe for more insight] > > Discussion on that topic came about from this submission: > http://www.spinics.net/lists/linux-usb/msg94217.html > > End of it is: > http://www.spinics.net/lists/linux-usb/msg94731.html > > We can either add to the many drivers that already do subsys_initcall() > for similar reasons...or I can drop this from the series and add gadget > probe ordering to my TODO list. > > In short, it can't be a late_initcall() hack like the original post and > really could be solved by converting to a real bus (and letting > deferred probe do its job)..but Alan voiced concerns about that. Don't worry too much about what I said. If adding a "gadget" bus will solve the problem in an appropriate way, and if nobody else objects (particularly Felipe, who is on vacation now), then go for it. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/6] i2c: bcm-kona: register with subsys_initcall
On Wed, Feb 05, 2014 at 10:08:18AM +0100, Wolfram Sang wrote: > On Tue, Feb 04, 2014 at 07:19:07AM -0500, Matt Porter wrote: > > > Voltage regulators are needed very early due to deferred probe > > being incompatible with built-in USB gadget drivers. > > What does it need to fix those instead? [added Alan/Felipe for more insight] Discussion on that topic came about from this submission: http://www.spinics.net/lists/linux-usb/msg94217.html End of it is: http://www.spinics.net/lists/linux-usb/msg94731.html We can either add to the many drivers that already do subsys_initcall() for similar reasons...or I can drop this from the series and add gadget probe ordering to my TODO list. In short, it can't be a late_initcall() hack like the original post and really could be solved by converting to a real bus (and letting deferred probe do its job)..but Alan voiced concerns about that. -Matt -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 14/17] i2c: nomadik: Fixup deployment of runtime PM
On Tue, Feb 4, 2014 at 1:58 PM, Ulf Hansson wrote:
> +static int nmk_i2c_runtime_resume(struct device *dev)
> +{
> + struct amba_device *adev = to_amba_device(dev);,
> + struct nmk_i2c_dev *nmk_i2c = amba_get_drvdata(adev);
> +
> + clk_prepare_enable(nmk_i2c->clk);
Previously the code was checking the return value from
clk_prepare_enable(). You should keep the check here.
Regards,
Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 14/17] i2c: nomadik: Fixup deployment of runtime PM
On Tue, Feb 4, 2014 at 4:58 PM, Ulf Hansson wrote: > Since the device is active while a successful probe has been completed, > the reference counting for the clock will be screwed up and never reach > zero. > > The issue is resolved by implementing runtime PM callbacks and let them > handle the resources accordingly, including the clock. > > Cc: Alessandro Rubini > Cc: Linus Walleij > Cc: Wolfram Sang > Signed-off-by: Ulf Hansson Hm do I read it right as patch 13 breaks runtime PM by leaving the device active after probe() and this patch 14 fixes it again? Maybe these two patches should be squashed then. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 11/17] i2c: nomadik: Convert to devm functions
On Tue, Feb 4, 2014 at 4:58 PM, Ulf Hansson wrote: > Use devm_* functions to simplify code and error handling. > > Cc: Alessandro Rubini > Cc: Linus Walleij > Cc: Wolfram Sang > Signed-off-by: Ulf Hansson Acked-by: Linus Walleij However make sure this (and the rest) applies on top of this patch: http://marc.info/?l=linux-i2c&m=139142325809973&w=2 Because I expect that to be applied first. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 05/17] mmc: mmci: Put the device into low power state at system suspend
On Wed, Feb 05, 2014 at 01:49:49PM +0100, Linus Walleij wrote: > On Tue, Feb 4, 2014 at 8:22 PM, Kevin Hilman wrote: > > I'm trying to thing of a good reason to not make PM_SLEEP depend on > > PM_RUNTIME for platforms like this. > Isn't the typical Android platform using PM_SLEEP without using > PM_RUNTIME? No, not at all. Android does make aggressive use of sleep but it's also highly desirable to use runtime PM - for example you don't want to have to power up the entire SoC simply because the system is getting a new e-mail pushed to it or location updates, most of the hardware is doing nothing. signature.asc Description: Digital signature
Re: [PATCH 10/17] spi: pl022: Remove redundant pinctrl to default state in probe
On Tue, Feb 4, 2014 at 4:58 PM, Ulf Hansson wrote: > The driver core is now taking care of putting our pins into default > state at probe. Thus we can remove the redundant call for it in probe. > > Cc: Mark Brown > Signed-off-by: Ulf Hansson Acked-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 05/17] mmc: mmci: Put the device into low power state at system suspend
On Tue, Feb 4, 2014 at 8:22 PM, Kevin Hilman wrote: > Ulf Hansson writes: > >> Due to the available runtime PM callbacks, we are now able to put our >> device into low power state at system suspend. (...) > I'm trying to thing of a good reason to not make PM_SLEEP depend on > PM_RUNTIME for platforms like this. Isn't the typical Android platform using PM_SLEEP without using PM_RUNTIME? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/6] i2c: bcm-kona: register with subsys_initcall
On Tue, Feb 04, 2014 at 07:19:07AM -0500, Matt Porter wrote: > Voltage regulators are needed very early due to deferred probe > being incompatible with built-in USB gadget drivers. What does it need to fix those instead? signature.asc Description: Digital signature
