Re: [PATCH RFC] OMAP: I2C: Fix the mismatch of pm_runtime enable and disable
On Wed, Jan 11, 2012 at 4:25 PM, Shubhrajyoti shubhrajy...@ti.com wrote: On Wednesday 11 January 2012 07:29 PM, Grazvydas Ignotas wrote: On Wed, Jan 11, 2012 at 3:21 PM, Shubhrajyoti D shubhrajy...@ti.com wrote: Currently the i2c driver calls the pm_runtime_enable and never the disable. This may cause a warning when pm_runtime_enable checks for the count match.Attempting to fix the same by calling pm_runtime_disable in the error and the remove path. I remember seeing Felipe doing the reverse to musb here: http://marc.info/?l=linux-omapm=132432610700952w=2 so I'm confused here. Strange however I see many drivers doing the same in the kernel on greping . Besides I expect a warn to come up. Felipe could you explain the issue? When do you see the warning? kfree(dev) should disable runtime pm, but without waking up the device. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] i2c: i2c-omap: Call request_irq with IRQF_DISABLED
On Thu, Mar 12, 2009 at 1:59 AM, Felipe Balbi m...@felipebalbi.com wrote: On Wed, Mar 11, 2009 at 05:55:50PM -0600, Paul Walmsley wrote: Ben's right, there shouldn't be any need for this. This patch could cause some unnecessary interrupt service latency. That's not what Thomas Gleixner thinks. How about the possibility of stack overflow ? According to Thomas (and Ingo, I'd say) all drivers should call request_irq() with IRQF_DISABLED and that's gonna be true as soon as the threaded irq handler support gets merged, if I'm not wrong. That's my understanding too, but I think it has always been true: http://marc.info/?l=linux-kernelm=123607685804562w=2 -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
