arc platform code updates (was Re: [PATCH 2/2] i2c: designware: Add support for AMD I2C controller)
+CC Guenter Roeck On Tuesday 07 October 2014 03:00 PM, Christian Ruppert wrote: > Hi Vineet, > > On Fri, Sep 26, 2014 at 09:20:20AM +0530, Vineet Gupta wrote: >> Hi Chrisitian, >> >> On Monday 22 September 2014 10:53 PM, Christian Ruppert wrote: >>> If there is no designware i2c in any of your platforms, simply ignore >>> my message. From my point of view there is no need to move "select >>> COMMON_CLK" up to the ARC architecture level. >> I still ended up moving COMMON_CLK out of tb10x to arch/arc - due to >> consolidation >> of .init_machine() callbacks - from platform to arc core. >> >> Give linux-next a spin (perhaps later today as I just pushed a build error >> in that >> area). >> >> You'll like the almost empty platform file :-) > This looks very nice indeed. Support for "standard" platforms is simple > and elegant. The fact that most platforms won't need any specific > support code at all (apart from drivers) goes well with the idea of > device tree. However, the kernel-doc comment for init_machine in > mach_desc.h is now slightly confusing (still mentioning device tree). A platform of future can still call of_platform_populate() etc to reparse the stuff for say it's platform devices ! So I would think it is still relevant ! > With this patch there remains only a single detail we need to manage > through platform-specific code: the reset handler. Today we still > provide a patch for the machine_restart function in reset.c to our > customers so that rebooting from the command line works. Do you have any > plans/ideas to fix this one as well? Patches are welcome ;-) ATM, I dont have a specific use-case for my current platforms, so can't write the code - you can propose a patch and then we can work out what's best in general for all ARC platforms. BTW there's a series in flight on related topic from Guenter so please take a look at that too for big picture ! http://www.spinics.net/linux/lists/kernel/msg1840650.html Cheers, -Vineet > > Greetings, > Christian > -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] i2c: designware: Add support for AMD I2C controller
Hi Chrisitian, On Monday 22 September 2014 10:53 PM, Christian Ruppert wrote: > If there is no designware i2c in any of your platforms, simply ignore > my message. From my point of view there is no need to move "select > COMMON_CLK" up to the ARC architecture level. I still ended up moving COMMON_CLK out of tb10x to arch/arc - due to consolidation of .init_machine() callbacks - from platform to arc core. Give linux-next a spin (perhaps later today as I just pushed a build error in that area). You'll like the almost empty platform file :-) -Vineet -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] i2c: designware: Add support for AMD I2C controller
On Monday 22 September 2014 07:30 PM, Mika Westerberg wrote: >>> COMMON_CLK is not selected by the ARC architecture in general. However, >>> > > we do select COMMON_CLK in the TB10x platform which uses the designware >>> > > I2C driver so this new dependency is no problem for us. >>> > > >>> > > Vineet, >>> > > >>> > > Do you see any issues with this on other existing ARC platforms, e.g. >>> > > arcfpga? >> > >> > So what needs to be done, COMMON_CLK needs to be defined in >> > arch/arc/Kconfig ? And >> > if so why ? > Without COMMON_CLK, you are not able to select I2C_DESIGNWARE_PLATFORM > anymore. So if something on ARC depends on this driver then we either > need the COMMON_CLK there or figure out alternative way to fix Carl's > problem. I have not seen the orig patch, but it seems COMMON_CLK is already being selected by TB10x, do we still need it in arch/arcKconfig, for all ARC platforms ? >> > OTOH, if we do have to, I don't see the issue with it - we just didn't >> > need it >> > for the legacy platform. > Is the legacy platform using this driver? Grepping "i2c_designware" > returns zero board files so at least that should be covered. > -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] i2c: designware: Add support for AMD I2C controller
On Monday 22 September 2014 05:59 PM, Christian Ruppert wrote: > Dear Mika, > > On Mon, Sep 22, 2014 at 12:12:07PM +0300, Mika Westerberg wrote: >> On Sat, Sep 20, 2014 at 11:36:34AM +0200, Wolfram Sang wrote: >>> On Thu, Sep 18, 2014 at 12:26:07PM +0300, Mika Westerberg wrote: From: Carl Peng Add support for AMD version of the DW I2C host controller. The device is enumerated from ACPI namespace with ACPI ID AMD0010. Because the core driver needs an input source clock, and this is not an Intel LPSS device where clocks are provided through drivers/acpi/acpi_lpss.c, we register the clock ourselves if the clock rate is given in ->driver_data. Signed-off-by: Carl Peng Signed-off-by: Mika Westerberg --- >>> Applied to for-next, still wondering... >> Thanks! >> drivers/i2c/busses/Kconfig | 1 + drivers/i2c/busses/i2c-designware-platdrv.c | 27 +++ 2 files changed, 28 insertions(+) diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index 2ac87fa3058d..9384498ef3c1 100644 --- a/drivers/i2c/busses/Kconfig +++ b/drivers/i2c/busses/Kconfig @@ -422,6 +422,7 @@ config I2C_DESIGNWARE_CORE config I2C_DESIGNWARE_PLATFORM tristate "Synopsys DesignWare Platform" + depends on COMMON_CLK >>> ... do all previous users have COMMON_CLK? >> The driver is being used on x86, ARM and ARC it seems. For x86 and ARM >> we pretty much have COMMON_CLK nowadays but I'm not sure about ARC. >> That's why I have copied Christian Ruppert. >> >> Christian, >> >> Do you see problems on your side if we depend on COMMON_CLK? > COMMON_CLK is not selected by the ARC architecture in general. However, > we do select COMMON_CLK in the TB10x platform which uses the designware > I2C driver so this new dependency is no problem for us. > > Vineet, > > Do you see any issues with this on other existing ARC platforms, e.g. > arcfpga? So what needs to be done, COMMON_CLK needs to be defined in arch/arc/Kconfig ? And if so why ? OTOH, if we do have to, I don't see the issue with it - we just didn't need it for the legacy platform. -Vineet -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v10] i2c-designware: make SDA hold time configurable
On 06/26/2013 02:25 PM, Christian Ruppert wrote: > This patch makes the SDA hold time configurable through device tree. > > Signed-off-by: Christian Ruppert > Signed-off-by: Pierrick Hascoet > --- > .../devicetree/bindings/i2c/i2c-designware.txt | 15 +++ > arch/arc/boot/dts/abilis_tb100_dvk.dts | 10 +- > arch/arc/boot/dts/abilis_tb101_dvk.dts | 10 +- > drivers/i2c/busses/i2c-designware-core.c | 13 + > drivers/i2c/busses/i2c-designware-core.h |1 + > drivers/i2c/busses/i2c-designware-platdrv.c| 10 ++ > 6 files changed, 49 insertions(+), 10 deletions(-) Acked-by: Vineet Gupta for arch/arc bits -Vineet -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v9] i2c-designware: make SDA hold time configurable
On 06/25/2013 10:09 PM, Wolfram Sang wrote: > Hi, > > On Fri, Jun 21, 2013 at 11:53:42AM +0200, Christian Ruppert wrote: >> > This patch makes the SDA hold time configurable through device tree. >> > >> > Signed-off-by: Christian Ruppert >> > Signed-off-by: Pierrick Hascoet >> > --- >> > .../devicetree/bindings/i2c/i2c-designware.txt | 14 ++ >> > arch/arc/boot/dts/abilis_tb100_dvk.dts | 10 +- >> > arch/arc/boot/dts/abilis_tb101_dvk.dts | 10 +- > Vineet, an ack for those would be nice since I think it is better if I > take all this via I2C. > Certainly, I was waiting for you guys to converge :-) Acked-by: Vineet Gupta# for arch/arc/boot/dts/* -Vineet -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
