Re: [PATCH] i2c: nomadik: Don't use IS_ERR for devm_ioremap

2014-05-14 Thread Wolfram Sang 
On Thu, Apr 10, 2014 at 04:19:29PM +0200, Ulf Hansson wrote:
> devm_ioremap() returns NULL on error, not an error.
> 
> Cc: Alessandro Rubini 
> Cc: Linus Walleij 
> Signed-off-by: Ulf Hansson 

Applied to for-current, thanks!



signature.asc
Description: Digital signature

Re: [PATCH] i2c: nomadik: Don't use IS_ERR for devm_ioremap

2014-05-06 Thread Linus Walleij 
On Tue, May 6, 2014 at 11:32 AM, Ulf Hansson  wrote:
> On 10 April 2014 16:19, Ulf Hansson  wrote:
>> devm_ioremap() returns NULL on error, not an error.
>>
>> Cc: Alessandro Rubini 
>> Cc: Linus Walleij 
>> Signed-off-by: Ulf Hansson 
>
> Linus, Wolfram - ping.

Acked-by: Linus Walleij 

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] i2c: nomadik: Don't use IS_ERR for devm_ioremap

2014-05-06 Thread Ulf Hansson 
On 10 April 2014 16:19, Ulf Hansson  wrote:
> devm_ioremap() returns NULL on error, not an error.
>
> Cc: Alessandro Rubini 
> Cc: Linus Walleij 
> Signed-off-by: Ulf Hansson 

Linus, Wolfram - ping.

Kind regards
Ulf Hansson
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] i2c: nomadik: Don't use IS_ERR for devm_ioremap

2014-04-10 Thread Ulf Hansson 
devm_ioremap() returns NULL on error, not an error.

Cc: Alessandro Rubini 
Cc: Linus Walleij 
Signed-off-by: Ulf Hansson 
---
 drivers/i2c/busses/i2c-nomadik.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c
index 28cbe1b..32c85e9 100644
--- a/drivers/i2c/busses/i2c-nomadik.c
+++ b/drivers/i2c/busses/i2c-nomadik.c
@@ -999,7 +999,7 @@ static int nmk_i2c_probe(struct amba_device *adev, const 
struct amba_id *id)
 
dev->virtbase = devm_ioremap(&adev->dev, adev->res.start,
resource_size(&adev->res));
-   if (IS_ERR(dev->virtbase)) {
+   if (!dev->virtbase) {
ret = -ENOMEM;
goto err_no_mem;
}
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html