Re: [PATCH] matroxfb: Convert struct i2c_msg initialization to C99 format

2012-10-10 Thread Shubhrajyoti Datta 
On Wed, Oct 10, 2012 at 2:35 PM, Jean Delvare  wrote:
> On Tue, 9 Oct 2012 17:07:48 +0530, Shubhrajyoti D wrote:
Thanks updated patch below.
>From 99073779197f5759a76e65c3f4ef2ad4e9c88eaf Mon Sep 17 00:00:00 2001
From: Shubhrajyoti D 
Date: Mon, 17 Sep 2012 21:19:32 +0530
Subject: [PATCHv2] matroxfb: Convert struct i2c_msg initialization to C99
 format

Convert the struct i2c_msg initialization to C99 format. This makes
maintaining and editing the code simpler. Also helps once other fields
like transferred are added in future.

Thanks to Julia Lawall   for automating the conversion

Acked-by: Jean Delvare 
Signed-off-by: Shubhrajyoti D 
---
 drivers/video/matrox/matroxfb_maven.c |   16 ++--
 1 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/drivers/video/matrox/matroxfb_maven.c
b/drivers/video/matrox/matroxfb_maven.c
index 217678e..f66c34c 100644
--- a/drivers/video/matrox/matroxfb_maven.c
+++ b/drivers/video/matrox/matroxfb_maven.c
@@ -137,8 +137,20 @@ static int* get_ctrl_ptr(struct maven_data* md, int idx) {

 static int maven_get_reg(struct i2c_client* c, char reg) {
char dst;
-   struct i2c_msg msgs[] = {{ c->addr, I2C_M_REV_DIR_ADDR, sizeof(reg), 
® },
-{ c->addr, I2C_M_RD | I2C_M_NOSTART, 
sizeof(dst), &dst }};
+   struct i2c_msg msgs[] = {
+   {
+   .addr = c->addr,
+   .flags = I2C_M_REV_DIR_ADDR,
+   .len = sizeof(reg),
+   .buf = ®
+   },
+   {
+   .addr = c->addr,
+   .flags = I2C_M_RD | I2C_M_NOSTART,
+   .len = sizeof(dst),
+   .buf = &dst
+   }
+   };
s32 err;

err = i2c_transfer(c->adapter, msgs, 2);
-- 
1.7.5.4
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] matroxfb: Convert struct i2c_msg initialization to C99 format

2012-10-10 Thread Jean Delvare 
On Tue, 9 Oct 2012 17:07:48 +0530, Shubhrajyoti D wrote:
> Convert the struct i2c_msg initialization to C99 format. This makes
> maintaining and editing the code simpler. Also helps once other fields
> like transferred are added in future.
> 
> Thanks to Julia Lawall   for automating the conversion
> 
> Signed-off-by: Shubhrajyoti D 
> ---
>  drivers/video/matrox/matroxfb_maven.c |   15 +--
>  1 files changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/matrox/matroxfb_maven.c 
> b/drivers/video/matrox/matroxfb_maven.c
> index 217678e..fb5c123 100644
> --- a/drivers/video/matrox/matroxfb_maven.c
> +++ b/drivers/video/matrox/matroxfb_maven.c
> @@ -137,8 +137,19 @@ static int* get_ctrl_ptr(struct maven_data* md, int idx) 
> {
>  
>  static int maven_get_reg(struct i2c_client* c, char reg) {
>   char dst;
> - struct i2c_msg msgs[] = {{ c->addr, I2C_M_REV_DIR_ADDR, sizeof(reg), 
> ® },
> -  { c->addr, I2C_M_RD | I2C_M_NOSTART, 
> sizeof(dst), &dst }};
> + struct i2c_msg msgs[] = {{
> + .addr = c->addr,
> + .flags = I2C_M_REV_DIR_ADDR,
> + .len = sizeof(reg),
> + .buf = ®
> + },
> + {
> + .addr = c->addr,
> + .flags = I2C_M_RD | I2C_M_NOSTART,
> + .len = sizeof(dst),
> + .buf = &dst
> + }

I'd prefer clean indentation as you have in the previous patches.

> + };
>   s32 err;
>  
>   err = i2c_transfer(c->adapter, msgs, 2);

Acked-by: Jean Delvare 

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] matroxfb: Convert struct i2c_msg initialization to C99 format

2012-10-09 Thread Shubhrajyoti D 
Convert the struct i2c_msg initialization to C99 format. This makes
maintaining and editing the code simpler. Also helps once other fields
like transferred are added in future.

Thanks to Julia Lawall   for automating the conversion

Signed-off-by: Shubhrajyoti D 
---
 drivers/video/matrox/matroxfb_maven.c |   15 +--
 1 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/drivers/video/matrox/matroxfb_maven.c 
b/drivers/video/matrox/matroxfb_maven.c
index 217678e..fb5c123 100644
--- a/drivers/video/matrox/matroxfb_maven.c
+++ b/drivers/video/matrox/matroxfb_maven.c
@@ -137,8 +137,19 @@ static int* get_ctrl_ptr(struct maven_data* md, int idx) {
 
 static int maven_get_reg(struct i2c_client* c, char reg) {
char dst;
-   struct i2c_msg msgs[] = {{ c->addr, I2C_M_REV_DIR_ADDR, sizeof(reg), 
® },
-{ c->addr, I2C_M_RD | I2C_M_NOSTART, 
sizeof(dst), &dst }};
+   struct i2c_msg msgs[] = {{
+   .addr = c->addr,
+   .flags = I2C_M_REV_DIR_ADDR,
+   .len = sizeof(reg),
+   .buf = ®
+   },
+   {
+   .addr = c->addr,
+   .flags = I2C_M_RD | I2C_M_NOSTART,
+   .len = sizeof(dst),
+   .buf = &dst
+   }
+   };
s32 err;
 
err = i2c_transfer(c->adapter, msgs, 2);
-- 
1.7.5.4

--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html