Re: [PATCH 3/3] i2c: uniphier: add bindings for UniPhier I2C controllers

[Masahiro Yamada]

2015-10-23 6:00 GMT+09:00 Wolfram Sang :
> On Thu, Jul 30, 2015 at 05:12:22PM +0900, Masahiro Yamada wrote:
>> Device Tree bindings for two I2C controllers embedded in
>> UniPhier SoCs.
>>
>> Signed-off-by: Masahiro Yamada 
>
> Please split this into two files with filenames matching those of the
> drivers. I know they will be very similar but I'd like to keep
> consistent.
>

OK, I splited it in v2.

Each document was merged into the corresponding driver patch.



-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] i2c: uniphier: add bindings for UniPhier I2C controllers

[Wolfram Sang]

On Thu, Jul 30, 2015 at 05:12:22PM +0900, Masahiro Yamada wrote:
> Device Tree bindings for two I2C controllers embedded in
> UniPhier SoCs.
> 
> Signed-off-by: Masahiro Yamada 

Please split this into two files with filenames matching those of the
drivers. I know they will be very similar but I'd like to keep
consistent.



signature.asc
Description: Digital signature

[PATCH 3/3] i2c: uniphier: add bindings for UniPhier I2C controllers

[Masahiro Yamada]

Device Tree bindings for two I2C controllers embedded in
UniPhier SoCs.

Signed-off-by: Masahiro Yamada yamada.masah...@socionext.com
---

 .../devicetree/bindings/i2c/i2c-uniphier.txt   | 46 ++
 1 file changed, 46 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/i2c/i2c-uniphier.txt

diff --git a/Documentation/devicetree/bindings/i2c/i2c-uniphier.txt 
b/Documentation/devicetree/bindings/i2c/i2c-uniphier.txt
new file mode 100644
index 000..e4ddb50
--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/i2c-uniphier.txt
@@ -0,0 +1,46 @@
+UniPhier I2C controller
+
+Two different types of I2C controller IPs are used on UniPhier SoC platform:
+- FIFO-less I2C controller on PH-LD4, PH1-sLD8 or older SoCs
+- FIFO-builtin I2C controller on PH1-Pro4 or newer SoCs
+
+Required properties:
+- compatible: should be one of the followings:
+   socionext,uniphier-i2c  (FIFO-less)
+   socionext,uniphier-fi2c (FIFO-builtin)
+- #address-cells: should be 1.
+- #size-cells: should be 0.
+- reg: offset and length of the register set for the device.
+- interrupts: a single interrupt specifier.
+- clocks: phandle to the input clock.
+
+Optional properties:
+- clock-frequency: desired I2C bus frequency in Hz.  The maximum supported
+  value is 40.  Defaults to 10 if not specified.
+
+Examples:
+
+- FIFO-less
+
+   i2c0: i2c@5840 {
+   compatible = socionext,uniphier-i2c;
+   reg = 0x5840 0x40;
+   #address-cells = 1;
+   #size-cells = 0;
+   interrupts = 0 41 1;
+   clocks = i2c_clk;
+   clock-frequency = 10;
+   };
+
+
+- FIFO-builtin
+
+   i2c0: i2c@5878 {
+   compatible = socionext,uniphier-fi2c;
+   reg = 0x5878 0x80;
+   #address-cells = 1;
+   #size-cells = 0;
+   interrupts = 0 41 4;
+   clocks = i2c_clk;
+   clock-frequency = 10;
+   };
-- 
1.9.1

--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html