Re: [PATCH 30/73] drivers/i2c: busses/i2c-acorn.c is tristate and should use module.h

[Wolfram Sang]

On Tue, Jan 21, 2014 at 04:22:33PM -0500, Paul Gortmaker wrote:
> This file is controlled by a tristate Kconfig option, and hence
> needs to include module.h so that it can get module_init() once
> we relocate it from init.h into module.h in the future.
> 
> Note that module_exit() appears to be missing from the driver, so
> it is questionable whether it would actually work for a removal
> and reload cycle if it was configured for a modular build.
> 
> Cc: Wolfram Sang 
> Cc: linux-i2c@vger.kernel.org
> Signed-off-by: Paul Gortmaker 

Applied to for-current, thanks!



signature.asc
Description: Digital signature

[PATCH 30/73] drivers/i2c: busses/i2c-acorn.c is tristate and should use module.h

[Paul Gortmaker]

This file is controlled by a tristate Kconfig option, and hence
needs to include module.h so that it can get module_init() once
we relocate it from init.h into module.h in the future.

Note that module_exit() appears to be missing from the driver, so
it is questionable whether it would actually work for a removal
and reload cycle if it was configured for a modular build.

Cc: Wolfram Sang 
Cc: linux-i2c@vger.kernel.org
Signed-off-by: Paul Gortmaker 
---
 drivers/i2c/busses/i2c-acorn.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-acorn.c b/drivers/i2c/busses/i2c-acorn.c
index ed9f48d..9d7be5a 100644
--- a/drivers/i2c/busses/i2c-acorn.c
+++ b/drivers/i2c/busses/i2c-acorn.c
@@ -12,7 +12,7 @@
  *  On Acorn machines, the following i2c devices are on the bus:
  * - PCF8583 real time clock & static RAM
  */
-#include 
+#include 
 #include 
 #include 
 #include 
-- 
1.8.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html