Re: [PATCH RESEND 1/2] i2c: pnx: Fix bit definitions
On Mon, Sep 03, 2012 at 10:16:22PM +0200, Roland Stigge wrote: > Hi Wolfram, > > On 20/08/12 19:55, Wolfram Sang wrote: > >> I've never had my hands on a PNX4008 chip at NXP, but I do > >> believe they are the same IP. That specific I2C IP was used in a > >> number of NXP/Phillips chips besides the PNX4008/LPC32xx. I don't > >> think there are any PNX4008's in the wild, and even working in > >> NXP, I can't find any non-marketing reference material for that > >> part (including the user manual). > > > > Thanks for the heads up. I'll apply both patches, then. > > Should I consider the two patches as applied now (where? > i2c-embedded?), or should I resend? ;-) I will apply them these days and then let them stay in linux-next for a few days. So, I'd think they should go in for rc6. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature
Re: [PATCH RESEND 1/2] i2c: pnx: Fix bit definitions
Hi Wolfram, On 20/08/12 19:55, Wolfram Sang wrote: >> I've never had my hands on a PNX4008 chip at NXP, but I do >> believe they are the same IP. That specific I2C IP was used in a >> number of NXP/Phillips chips besides the PNX4008/LPC32xx. I don't >> think there are any PNX4008's in the wild, and even working in >> NXP, I can't find any non-marketing reference material for that >> part (including the user manual). > > Thanks for the heads up. I'll apply both patches, then. Should I consider the two patches as applied now (where? i2c-embedded?), or should I resend? ;-) Thanks in advance, Roland -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH RESEND 1/2] i2c: pnx: Fix bit definitions
On 20/08/12 19:55, Wolfram Sang wrote: >> I've never had my hands on a PNX4008 chip at NXP, but I do >> believe they are the same IP. That specific I2C IP was used in a >> number of NXP/Phillips chips besides the PNX4008/LPC32xx. I don't >> think there are any PNX4008's in the wild, and even working in >> NXP, I can't find any non-marketing reference material for that >> part (including the user manual). > > Thanks for the heads up. I'll apply both patches, then. > > Roland, this looks like 3.6-material? Yes, all bugfixes. Thanks, Roland -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH RESEND 1/2] i2c: pnx: Fix bit definitions
On Monday 20 August 2012, Roland Stigge wrote: > On 08/20/2012 06:26 PM, Kevin Wells wrote: > > I've never had my hands on a PNX4008 chip at NXP, but I do believe they > > are the same IP. That specific I2C IP was used in a number of NXP/Phillips > > chips besides the PNX4008/LPC32xx. I don't think there are any PNX4008's in > > the wild, and even working in NXP, I can't find any non-marketing reference > > material for that part (including the user manual). > > Considering this, it might be a good idea to remove support for PNX4008 > (arch/arm/mach-pnx4008/) altogether. It's hard to maintain support for > hardware which isn't available, even at NXP. It would also simplify > maintenance of mach-lpc32xx because the overlap currently makes me > always wonder if the respective changes still work with mach-pnx4008. > > Any opposition? > > > PS: I just wonder how mach-pnx4008 came into the kernel at all... According to the git logs, Vitaly Wool originally added support for the platform in 2006 when working at MontaVista, and that year was also the last time he or anyone else from that company contributed anything in that directory. Russell was the only other person to make substantial contributions to it, but they all seem to be cross-platform changes. In the platform code, there is only a single board number reserved, with the name of the SoC: MACHINE_START(PNX4008, "Philips PNX4008"). This indicates that whoever was actually using the code did not have their board code upstream and relied on out-of-tree patches for the platform. >From all I can tell, the PNX4008 family probably went to ST-Ericsson, not to NXP in the various acquisitions and mergers that happened around NXP. This explains why Kevin has no documentation or hardware for it. On the ST-Ericsson web site, I could find some information about the PNX4908, presumably a follow-on chip, but not about PNX4008, so I guess the company also considers the product line dead. Finally, the chips seems to be targetted at mobile phones and was introduced seven years ago, which is multiple generations of products in that market, so probably people stopped caring about them long ago, unlike embedded chips from the same era for other markets. I'd say let's wait for Vitaly to reply on this matter, if he doesn't care about the code, we can kill it off in 3.7 or 3.8. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH RESEND 1/2] i2c: pnx: Fix bit definitions
On Mon, Aug 20, 2012 at 06:26:54PM +0200, Kevin Wells wrote: > >>> This patch for i2c-pnx affects PNX4008 and LPC32xx (and LPC31xx, > >>> not yet in mainline). Can you please test and double-check the > >>> manuals of PNX4008 and LPC31xx? I only found this via the manual > >>> of LPC32xx but assume it's the same for the others, also. > >>> > >>> Thanks in advance! > >> > >> Kevin, since the other manuals seem to be not easily available, can > >> you please check? > > > >Yes, would be great if someone at NXP could confirm that PNX actually > >uses the same IP core for the I2C controller as LPCs do (which is > >currently assumed by Linux anyway). > > I've never had my hands on a PNX4008 chip at NXP, but I do believe they > are the same IP. That specific I2C IP was used in a number of NXP/Phillips > chips besides the PNX4008/LPC32xx. I don't think there are any PNX4008's in > the wild, and even working in NXP, I can't find any non-marketing reference > material for that part (including the user manual). Thanks for the heads up. I'll apply both patches, then. Roland, this looks like 3.6-material? -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature
RE: [PATCH RESEND 1/2] i2c: pnx: Fix bit definitions
>>> This patch for i2c-pnx affects PNX4008 and LPC32xx (and LPC31xx, >>> not yet in mainline). Can you please test and double-check the >>> manuals of PNX4008 and LPC31xx? I only found this via the manual >>> of LPC32xx but assume it's the same for the others, also. >>> >>> Thanks in advance! >> >> Kevin, since the other manuals seem to be not easily available, can >> you please check? > >Yes, would be great if someone at NXP could confirm that PNX actually >uses the same IP core for the I2C controller as LPCs do (which is >currently assumed by Linux anyway). I've never had my hands on a PNX4008 chip at NXP, but I do believe they are the same IP. That specific I2C IP was used in a number of NXP/Phillips chips besides the PNX4008/LPC32xx. I don't think there are any PNX4008's in the wild, and even working in NXP, I can't find any non-marketing reference material for that part (including the user manual). The pnx I2C block is used in the LPC32xx (3 instances), the LPC313x, LPC2000 (1 instance for USB OTG), and the LPC17xx/LPC40xx (1 instance for USB OTG). The LPC2000, LPC17xx, and LPC40xx devices also use another completely different (non-pnx) I2C block for non-OTG I2C.
Re: [PATCH RESEND 1/2] i2c: pnx: Fix bit definitions
On 08/20/2012 06:26 PM, Kevin Wells wrote: This patch for i2c-pnx affects PNX4008 and LPC32xx (and LPC31xx, not yet in mainline). Can you please test and double-check the manuals of PNX4008 and LPC31xx? I only found this via the manual of LPC32xx but assume it's the same for the others, also. Thanks in advance! >>> >>> Kevin, since the other manuals seem to be not easily available, can >>> you please check? >> >> Yes, would be great if someone at NXP could confirm that PNX actually >> uses the same IP core for the I2C controller as LPCs do (which is >> currently assumed by Linux anyway). > > I've never had my hands on a PNX4008 chip at NXP, but I do believe they > are the same IP. That specific I2C IP was used in a number of NXP/Phillips > chips besides the PNX4008/LPC32xx. I don't think there are any PNX4008's in > the wild, and even working in NXP, I can't find any non-marketing reference > material for that part (including the user manual). Considering this, it might be a good idea to remove support for PNX4008 (arch/arm/mach-pnx4008/) altogether. It's hard to maintain support for hardware which isn't available, even at NXP. It would also simplify maintenance of mach-lpc32xx because the overlap currently makes me always wonder if the respective changes still work with mach-pnx4008. Any opposition? Roland PS: I just wonder how mach-pnx4008 came into the kernel at all... -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH RESEND 1/2] i2c: pnx: Fix bit definitions
On 18/08/12 11:51, Wolfram Sang wrote: > On Wed, Aug 08, 2012 at 09:42:31AM +0200, Roland Stigge wrote: >> The I2C Control Register bits RFDAIE and RFFIE were mixed up. In >> addition to this fix, this patch adds the missing bit DRSIE for >> completeness. >> >> Signed-off-by: Roland Stigge >> >> --- Applies to v3.6-rc1 >> >> This patch for i2c-pnx affects PNX4008 and LPC32xx (and LPC31xx, >> not yet in mainline). Can you please test and double-check the >> manuals of PNX4008 and LPC31xx? I only found this via the manual >> of LPC32xx but assume it's the same for the others, also. >> >> Thanks in advance! > > Kevin, since the other manuals seem to be not easily available, can > you please check? Yes, would be great if someone at NXP could confirm that PNX actually uses the same IP core for the I2C controller as LPCs do (which is currently assumed by Linux anyway). Thanks in advance, Roland -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH RESEND 1/2] i2c: pnx: Fix bit definitions
On Wed, Aug 08, 2012 at 09:42:31AM +0200, Roland Stigge wrote: > The I2C Control Register bits RFDAIE and RFFIE were mixed up. In addition to > this fix, this patch adds the missing bit DRSIE for completeness. > > Signed-off-by: Roland Stigge > > --- > Applies to v3.6-rc1 > > This patch for i2c-pnx affects PNX4008 and LPC32xx (and LPC31xx, not yet in > mainline). Can you please test and double-check the manuals of PNX4008 and > LPC31xx? I only found this via the manual of LPC32xx but assume it's the same > for the others, also. > > Thanks in advance! Kevin, since the other manuals seem to be not easily available, can you please check? Thanks, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature
[PATCH RESEND 1/2] i2c: pnx: Fix bit definitions
The I2C Control Register bits RFDAIE and RFFIE were mixed up. In addition to
this fix, this patch adds the missing bit DRSIE for completeness.
Signed-off-by: Roland Stigge
---
Applies to v3.6-rc1
This patch for i2c-pnx affects PNX4008 and LPC32xx (and LPC31xx, not yet in
mainline). Can you please test and double-check the manuals of PNX4008 and
LPC31xx? I only found this via the manual of LPC32xx but assume it's the same
for the others, also.
Thanks in advance!
drivers/i2c/busses/i2c-pnx.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--- linux-2.6.orig/drivers/i2c/busses/i2c-pnx.c
+++ linux-2.6/drivers/i2c/busses/i2c-pnx.c
@@ -48,8 +48,9 @@ enum {
mcntrl_afie = 0x0002,
mcntrl_naie = 0x0004,
mcntrl_drmie = 0x0008,
- mcntrl_daie = 0x0020,
- mcntrl_rffie = 0x0040,
+ mcntrl_drsie = 0x0010,
+ mcntrl_rffie = 0x0020,
+ mcntrl_daie = 0x0040,
mcntrl_tffie = 0x0080,
mcntrl_reset = 0x0100,
mcntrl_cdbmode = 0x0400,
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
