Re: [PATCH v2] i2c: designware: Suppress error message if platform_get_irq() 0

2015-03-15 Thread Wolfram Sang 
On Mon, Mar 09, 2015 at 12:03:12PM +0300, Alexey Brodkin wrote:
 As discussed here https://lkml.org/lkml/2015/3/3/568 and here
 https://lkml.org/lkml/2015/3/3/453 we're looking forward for
 implementing warnings and errors outputs right in platform_get_irq()
 instead of having all kind of different outputs in each and every driver
 that uses platform_get_irq().
 
 Signed-off-by: Alexey Brodkin abrod...@synopsys.com
 Cc: Vineet Gupta vgu...@synopsys.com
 Cc: Christian Ruppert christian.rupp...@abilis.com
 Cc: Mika Westerberg mika.westerb...@linux.intel.com
 Cc: Wolfram Sang w...@the-dreams.de
 Cc: Andy Shevchenko andriy.shevche...@linux.intel.com

Reworded the commit message to state the initial reason for this patch
and applied to for-next, thanks!



signature.asc
Description: Digital signature

Re: [PATCH v2] i2c: designware: Suppress error message if platform_get_irq() 0

2015-03-09 Thread Mika Westerberg 
On Mon, Mar 09, 2015 at 12:03:12PM +0300, Alexey Brodkin wrote:
 As discussed here https://lkml.org/lkml/2015/3/3/568 and here
 https://lkml.org/lkml/2015/3/3/453 we're looking forward for
 implementing warnings and errors outputs right in platform_get_irq()
 instead of having all kind of different outputs in each and every driver
 that uses platform_get_irq().
 
 Signed-off-by: Alexey Brodkin abrod...@synopsys.com
 Cc: Vineet Gupta vgu...@synopsys.com
 Cc: Christian Ruppert christian.rupp...@abilis.com
 Cc: Mika Westerberg mika.westerb...@linux.intel.com

Acked-by: Mika Westerberg mika.westerb...@linux.intel.com
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] i2c: designware: Suppress error message if platform_get_irq() 0

2015-03-09 Thread christian . ruppert 
Alexey Brodkin alexey.brod...@synopsys.com wrote on 03/09/2015 10:03:12 
AM:

 From: Alexey Brodkin alexey.brod...@synopsys.com
 To: linux-i2c@vger.kernel.org, 
 Cc: linux-ker...@vger.kernel.org, Alexey Brodkin 
 alexey.brod...@synopsys.com, Vineet Gupta 
 vineet.gup...@synopsys.com, Christian Ruppert 
 christian.rupp...@abilis.com, Mika Westerberg 
 mika.westerb...@linux.intel.com, Wolfram Sang w...@the-dreams.de,
 Andy Shevchenko andriy.shevche...@linux.intel.com
 Date: 03/09/2015 10:03 AM
 
 As discussed here https://lkml.org/lkml/2015/3/3/568 and here
 https://lkml.org/lkml/2015/3/3/453 we're looking forward for
 implementing warnings and errors outputs right in platform_get_irq()
 instead of having all kind of different outputs in each and every driver
 that uses platform_get_irq().
 
 Signed-off-by: Alexey Brodkin abrod...@synopsys.com
 Cc: Vineet Gupta vgu...@synopsys.com
 Cc: Christian Ruppert christian.rupp...@abilis.com
Acked-by: Christian Ruppert christian.rupp...@alitech.com

Please note that my email address has changed and use the alitech one in 
future. The abilis address might be switched off soon.

 Cc: Mika Westerberg mika.westerb...@linux.intel.com
 Cc: Wolfram Sang w...@the-dreams.de
 Cc: Andy Shevchenko andriy.shevche...@linux.intel.com
 ---
  drivers/i2c/busses/i2c-designware-platdrv.c | 6 ++
  1 file changed, 2 insertions(+), 4 deletions(-)
 
 diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/
 i2c/busses/i2c-designware-platdrv.c
 index c270f5f..fa4e2b5 100644
 --- a/drivers/i2c/busses/i2c-designware-platdrv.c
 +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
 @@ -143,10 +143,8 @@ static int dw_i2c_probe(struct platform_device 
*pdev)
 u32 clk_freq, ht = 0;
 
 irq = platform_get_irq(pdev, 0);
 -   if (irq  0) {
 -  dev_err(pdev-dev, no irq resource?\n);
 -  return irq; /* -ENXIO */
 -   }
 +   if (irq  0)
 +  return irq;
 
 dev = devm_kzalloc(pdev-dev, sizeof(struct dw_i2c_dev), 
GFP_KERNEL);
 if (!dev)
 -- 
 2.1.0
 


--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2] i2c: designware: Suppress error message if platform_get_irq() 0

2015-03-09 Thread Alexey Brodkin 
As discussed here https://lkml.org/lkml/2015/3/3/568 and here
https://lkml.org/lkml/2015/3/3/453 we're looking forward for
implementing warnings and errors outputs right in platform_get_irq()
instead of having all kind of different outputs in each and every driver
that uses platform_get_irq().

Signed-off-by: Alexey Brodkin abrod...@synopsys.com
Cc: Vineet Gupta vgu...@synopsys.com
Cc: Christian Ruppert christian.rupp...@abilis.com
Cc: Mika Westerberg mika.westerb...@linux.intel.com
Cc: Wolfram Sang w...@the-dreams.de
Cc: Andy Shevchenko andriy.shevche...@linux.intel.com
---
 drivers/i2c/busses/i2c-designware-platdrv.c | 6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c 
b/drivers/i2c/busses/i2c-designware-platdrv.c
index c270f5f..fa4e2b5 100644
--- a/drivers/i2c/busses/i2c-designware-platdrv.c
+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
@@ -143,10 +143,8 @@ static int dw_i2c_probe(struct platform_device *pdev)
u32 clk_freq, ht = 0;
 
irq = platform_get_irq(pdev, 0);
-   if (irq  0) {
-   dev_err(pdev-dev, no irq resource?\n);
-   return irq; /* -ENXIO */
-   }
+   if (irq  0)
+   return irq;
 
dev = devm_kzalloc(pdev-dev, sizeof(struct dw_i2c_dev), GFP_KERNEL);
if (!dev)
-- 
2.1.0

--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html