Re: [PATCH 2/2] i2c: mxs: Use devm_ioremap_resource()

2014-03-09 Thread Wolfram Sang 

 - if (!res || irq  0)
 + irq = platform_get_irq(pdev, 0);
 + if (irq  0)
   return -ENOENT;

Please return irq here.



signature.asc
Description: Digital signature

Re: [PATCH 2/2] i2c: mxs: Use devm_ioremap_resource()

2014-02-12 Thread Marek Vasut 
On Tuesday, February 11, 2014 at 02:04:55 PM, Jingoo Han wrote:
 Use devm_ioremap_resource() in order to make the code simpler,
 and remove redundant return value check of platform_get_resource()
 because the value is checked by devm_ioremap_resource().
 
 Signed-off-by: Jingoo Han jg1@samsung.com
 ---

Acked-by: Marek Vasut ma...@denx.de

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] i2c: mxs: Use devm_ioremap_resource()

2014-02-11 Thread Shawn Guo 
On Tue, Feb 11, 2014 at 10:04:55PM +0900, Jingoo Han wrote:
 Use devm_ioremap_resource() in order to make the code simpler,
 and remove redundant return value check of platform_get_resource()
 because the value is checked by devm_ioremap_resource().
 
 Signed-off-by: Jingoo Han jg1@samsung.com

Acked-by: Shawn Guo shawn@linaro.org

--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html