Re: [PATCH v2] i2c: nomadik: factor platform data into state container
On Mon, Feb 24, 2014 at 10:13 AM, Wolfram Sang wrote: > On Mon, Feb 24, 2014 at 09:57:05AM +0100, Linus Walleij wrote: >> I can easily fix that up ipso facto by modifying the device trees to >> state 400kHz for them. > > Then lets do it this way. After a check I see that this is already in place in the device trees. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] i2c: nomadik: factor platform data into state container
On Mon, Feb 24, 2014 at 09:57:05AM +0100, Linus Walleij wrote: > On Tue, Feb 18, 2014 at 7:35 PM, Wolfram Sang wrote: > > >> - of_property_read_u32(np, "clock-frequency", &pdata->clk_freq); > >> + /* Default to 400 kHz if no frequency is given in the node */ > >> + if (of_property_read_u32(np, "clock-frequency", &nmk->clk_freq)) > >> + nmk->clk_freq = 40; > > > > I can't really recommend this. 100kHz is something all devices support, > > but, although common, 400 kHz is already an extension of the standard. > > > > Let me know if I should fix this up for you. > > I think this is done like this because all devices on all Nomadik variants > out there (Nomadik, Ux500) support 400kHz. > > Buit change it if you prefer, nothing will break, it will just get slower :-) OK, then I'll change it. There is this idea of parsing "clock-frequency" in the core somewhen and if so, 100kHz would be the default, for sure. > I can easily fix that up ipso facto by modifying the device trees to > state 400kHz for them. Then lets do it this way. Thanks! signature.asc Description: Digital signature
Re: [PATCH v2] i2c: nomadik: factor platform data into state container
On Tue, Feb 18, 2014 at 7:35 PM, Wolfram Sang wrote: >> - of_property_read_u32(np, "clock-frequency", &pdata->clk_freq); >> + /* Default to 400 kHz if no frequency is given in the node */ >> + if (of_property_read_u32(np, "clock-frequency", &nmk->clk_freq)) >> + nmk->clk_freq = 40; > > I can't really recommend this. 100kHz is something all devices support, > but, although common, 400 kHz is already an extension of the standard. > > Let me know if I should fix this up for you. I think this is done like this because all devices on all Nomadik variants out there (Nomadik, Ux500) support 400kHz. Buit change it if you prefer, nothing will break, it will just get slower :-) I can easily fix that up ipso facto by modifying the device trees to state 400kHz for them. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] i2c: nomadik: factor platform data into state container
> - of_property_read_u32(np, "clock-frequency", &pdata->clk_freq); > + /* Default to 400 kHz if no frequency is given in the node */ > + if (of_property_read_u32(np, "clock-frequency", &nmk->clk_freq)) > + nmk->clk_freq = 40; I can't really recommend this. 100kHz is something all devices support, but, although common, 400 kHz is already an extension of the standard. Let me know if I should fix this up for you. signature.asc Description: Digital signature
Re: [PATCH v2] i2c: nomadik: factor platform data into state container
On Mon, Feb 3, 2014 at 11:27 AM, Linus Walleij wrote: > Move the former platform data struct nmk_i2c_controller into the > per-device state container struct i2c_nmk_client, and remove all > the platform data probe path hacks. > > Cc: Lee Jones > Signed-off-by: Linus Walleij > --- > ChangeLog v1->v2: > - Drop pointless check for np, as the device can only probe from > the device tree now. Wolfram, ping on this! Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
