Re: [PATCH v2 2/5] i2c: davinci: query STP always when NACK is received

2014-11-26 Thread Grygorii Strashko

On 11/26/2014 05:57 PM, Uwe Kleine-König wrote:

Hello,

I don't understand your use of query in the subject and later in the
commit log. Do you mean send?


will change to generate. Ok?



On Wed, Nov 26, 2014 at 03:59:50PM +0200, Grygorii Strashko wrote:

According to I2C specification the NACK should be handled as folows:

s/folows/follows/

ok.

Can I assume that you are ok with this patch in general?

regards,
-grygorii


--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v2 2/5] i2c: davinci: query STP always when NACK is received

2014-11-26 Thread Uwe Kleine-König
Hello Grygorii,

On Wed, Nov 26, 2014 at 06:31:22PM +0200, Grygorii Strashko wrote:
 On 11/26/2014 05:57 PM, Uwe Kleine-König wrote:
 I don't understand your use of query in the subject and later in the
 commit log. Do you mean send?
 
 will change to generate. Ok?
yes that would be better understandable

 Can I assume that you are ok with this patch in general?
Yeah, your argument that being able to send a Sr is not sensible made
sense to me. If Wolfram is happy with your patch so am I.

Best regards
Uwe

-- 
Pengutronix e.K.   | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html