Re: [PATCH v3 4/4] dt: paz00: define nvec as child of i2c bus
> It's up to you. I think if the NV guys are ok with the tegra i2c change, > Wolfram can merge it right away for 4.3. I asked him to resend, because I *want* to merge it for 4.3 :) Only the slave-mode enablement for i2c, of course. The other patches need to go via some other tree (when they are done). So, V4 with only this one patch is a good idea in my book. signature.asc Description: Digital signature
Re: [PATCH v3 4/4] dt: paz00: define nvec as child of i2c bus
Am Dienstag, 21. Juli 2015, 11:51:15 schrieb Andrey Danin: > On 21.07.2015 11:25, Marc Dietrich wrote: > > I think in this case it would be better to leave nvec and dt as it is for > > now, and just add the slave function to tegra-i2c. Otherwise we will > > again have two different "nvidia,nvec-slave" bindings (one for the > > intermediate hack and one for the final representation). As an > > alternative, you could also add slave function and port nvec in the same > > series. > > First patch only adds slave functionality to tegra-i2c driver. I sent v3 > to fix only tegra-i2c as Wolfram suggested. > > Unfortunately I haven't fixed all defects and I will resend patch(es). > I can resend only first patch (for tegra-i2c) if it is more obvious for > everyone. It's up to you. I think if the NV guys are ok with the tegra i2c change, Wolfram can merge it right away for 4.3. Not sure about the state of the nvec changes though and if they can be ready soon. Marc signature.asc Description: This is a digitally signed message part.
Re: [PATCH v3 4/4] dt: paz00: define nvec as child of i2c bus
On 21.07.2015 11:25, Marc Dietrich wrote: I think in this case it would be better to leave nvec and dt as it is for now, and just add the slave function to tegra-i2c. Otherwise we will again have two different "nvidia,nvec-slave" bindings (one for the intermediate hack and one for the final representation). As an alternative, you could also add slave function and port nvec in the same series. First patch only adds slave functionality to tegra-i2c driver. I sent v3 to fix only tegra-i2c as Wolfram suggested. Unfortunately I haven't fixed all defects and I will resend patch(es). I can resend only first patch (for tegra-i2c) if it is more obvious for everyone. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 4/4] dt: paz00: define nvec as child of i2c bus
Am Dienstag, 21. Juli 2015, 09:35:21 schrieb Andrey Danin:
> On 21.07.2015 1:19, Stephen Warren wrote:
> > On 07/20/2015 02:35 PM, Andrey Danin wrote:
> >> NVEC driver was reimplemented to use tegra i2c. Use common i2c bindings
> >> for NVEC node.
> >>
> >> diff --git a/arch/arm/boot/dts/tegra20-paz00.dts
> >> b/arch/arm/boot/dts/tegra20-paz00.dts
> >>
> >> +nvec: nvec@45 {
> >> +compatible = "nvidia,nvec-slave";
> >> +reg = <0x45>;
> >
> > I think you need to or in I2C_OWN_SLAVE_ADDRESS from
> > here?
>
> Sorry, I mentioned it in letter 0 only.
> I will rework nvec driver and device tree according to i2c core slave
> implementation later. v3 of this patchset is for fixing tegra i2c driver
> only.
I think in this case it would be better to leave nvec and dt as it is for now,
and just add the slave function to tegra-i2c. Otherwise we will again have two
different "nvidia,nvec-slave" bindings (one for the intermediate hack and one
for the final representation). As an alternative, you could also add slave
function and port nvec in the same series.
Marc
signature.asc
Description: This is a digitally signed message part.
Re: [PATCH v3 4/4] dt: paz00: define nvec as child of i2c bus
On 21.07.2015 1:19, Stephen Warren wrote:
On 07/20/2015 02:35 PM, Andrey Danin wrote:
NVEC driver was reimplemented to use tegra i2c. Use common i2c bindings
for NVEC node.
diff --git a/arch/arm/boot/dts/tegra20-paz00.dts
b/arch/arm/boot/dts/tegra20-paz00.dts
+nvec: nvec@45 {
+compatible = "nvidia,nvec-slave";
+reg = <0x45>;
I think you need to or in I2C_OWN_SLAVE_ADDRESS from
here?
Sorry, I mentioned it in letter 0 only.
I will rework nvec driver and device tree according to i2c core slave
implementation later. v3 of this patchset is for fixing tegra i2c driver
only.
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 4/4] dt: paz00: define nvec as child of i2c bus
On 07/20/2015 02:35 PM, Andrey Danin wrote:
NVEC driver was reimplemented to use tegra i2c. Use common i2c bindings
for NVEC node.
diff --git a/arch/arm/boot/dts/tegra20-paz00.dts
b/arch/arm/boot/dts/tegra20-paz00.dts
+ nvec: nvec@45 {
+ compatible = "nvidia,nvec-slave";
+ reg = <0x45>;
I think you need to or in I2C_OWN_SLAVE_ADDRESS from
here?
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
