Re: [PATCH] pata_cmd64x: Correct the speed ranges
Sergei Shtylyov wrote: Hello. Jeff Garzik wrote: Note that the olde driver has MWDMA fixed, and the new one has it still borken, yet MWDMA2 is the mode you're using. What about MWDMA is broken? The code that "sets" MWDMA timings is completely bogus -- I've already reported that before. And now I've fixed this in the old IDE driver at last. In what way is it completely bogus? Jeff - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ide: make CONFIG_IDE_GENERIC default to N
Tejun Heo wrote: These days, CONFIG_IDE_GENERIC causes more confusion and misconfiguration than it helps. Especially so because libata is linked after the generic driver. Default to N. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- drivers/ide/Kconfig |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ide/Kconfig b/drivers/ide/Kconfig index b1a9b81..8113909 100644 --- a/drivers/ide/Kconfig +++ b/drivers/ide/Kconfig @@ -304,9 +304,9 @@ comment "IDE chipset support/bugfixes" config IDE_GENERIC tristate "generic/default IDE chipset support" - default y + default n help - If unsure, say Y. + If unsure, say N. I don't know if we want to get this nit-picky, but you could probably just delete the "default y" line for the same effect. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] pata_cmd64x: Correct the speed ranges
Hello. Jeff Garzik wrote: Note that the olde driver has MWDMA fixed, and the new one has it still borken, yet MWDMA2 is the mode you're using. What about MWDMA is broken? The code that "sets" MWDMA timings is completely bogus -- I've already reported that before. And now I've fixed this in the old IDE driver at last. Jeff MBR, Sergei - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] pata_cmd64x: Correct the speed ranges
Hello. Jeff Garzik wrote: Note that the olde driver has MWDMA fixed, and the new one has it still borken, yet MWDMA2 is the mode you're using. What about MWDMA is broken? The code that "sets" MWDMA timings is completely bogus -- I've already reported that before. And now I've fixed this in the old IDE driver at last. In what way is it completely bogus? It writes these "timings" (they are incorrect too) to the BMIDE status reg. Bogus enough? ;-) Jeff MBR, Sergei - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ide: move ide_config_drive_speed() calls to upper layers
On Fri, 27 Jul 2007 02:22:27 +0200
Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote:
>
> * Convert {ide_hwif_t,ide_pci_device_t}->host_flag to be u16.
>
> * Add IDE_HFLAG_POST_SET_MODE host to indicate the need to program the
> host for the transfer mode after programming the device. Set it in
> au1xxx-ide/cs5530/cs5535/pdc202xx_new/sc1200/via82cxxx host drivers.
The CS5530 at least shouldn't care what order changes are done. I don't
think the SC1200 does either but I don't have the docs to hand.
For libata we went the post_set_mode way and then junked it. Instead
there is a ->set_mode method which defaults to the usual order and
actions. IT821x and similar override it to do very little, post_set_mode
people call the default method and then do their stuff, and some of the
crazier cases do stuff both before and after the default.
Much more flexible and it can do anything unlike flags for the cases you
have.
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] use ARRAY_SIZE in ide-cd.c
Hi,
ARY_LEN in ide-cd.{c,h} is an unnecessary duplication. Replace with generic
ARRAY_SIZE from
kernel.h.
Mark
commit 195695d6135fcc4615b70883c8c1c3cc82c5633c
Author: Mark Hindley <[EMAIL PROTECTED]>
Date: Fri Jul 27 18:55:33 2007 +0100
Replace ARY_LEN with ARRAY_SIZE in drivers/ide/ide-cd.{c,h}.
Signed-off-by: Mark Hindley <[EMAIL PROTECTED]>
diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
index 252ab82..79ee92a 100644
--- a/drivers/ide/ide-cd.c
+++ b/drivers/ide/ide-cd.c
@@ -481,7 +481,7 @@ void cdrom_analyze_sense_data(ide_drive_t *drive,
else
printk(" Unknown Error Type: ");
- if (sense->sense_key < ARY_LEN(sense_key_texts))
+ if (sense->sense_key < ARRAY_SIZE(sense_key_texts))
s = sense_key_texts[sense->sense_key];
printk("%s -- (Sense key=0x%02x)\n", s, sense->sense_key);
@@ -491,7 +491,7 @@ void cdrom_analyze_sense_data(ide_drive_t *drive,
sense->ascq);
s = buf;
} else {
- int lo = 0, mid, hi = ARY_LEN(sense_data_texts);
+ int lo = 0, mid, hi = ARRAY_SIZE(sense_data_texts);
unsigned long key = (sense->sense_key << 16);
key |= (sense->asc << 8);
if (!(sense->ascq >= 0x80 && sense->ascq <= 0xdd))
@@ -524,7 +524,7 @@ void cdrom_analyze_sense_data(ide_drive_t *drive,
if (failed_command != NULL) {
- int lo=0, mid, hi= ARY_LEN (packet_command_texts);
+ int lo=0, mid, hi= ARRAY_SIZE (packet_command_texts);
s = NULL;
while (hi > lo) {
diff --git a/drivers/ide/ide-cd.h b/drivers/ide/ide-cd.h
index ad1f2ed..228b29c 100644
--- a/drivers/ide/ide-cd.h
+++ b/drivers/ide/ide-cd.h
@@ -498,8 +498,6 @@ struct cdrom_info {
* Descriptions of ATAPI error codes.
*/
-#define ARY_LEN(a) ((sizeof(a) / sizeof(a[0])))
-
/* This stuff should be in cdrom.h, since it is now generic... */
/* ATAPI sense keys (from table 140 of ATAPI 2.6) */
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/4] libata: ACPI checks for 80wire cable
Alan Cox wrote: We can use the ACPI mode information with several drivers as a hint to cable type. If the ACPI mode set by the BIOS is faster than UDMA33 then we know the BIOS thinks there are 80wire cables. If it doesn't set such a mode or it has no ACPI method then we get no further information and can rely on existing approaches Introduce the function headers needed. Null it out for non ACPI boxes Signed-off-by: Alan Cox <[EMAIL PROTECTED]> I like this patchset. This is the direction we need to be following. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [2/3] 2.6.23-rc1: known regressions v2
Hi all, Here is a list of some known regressions in 2.6.23-rc1. Feel free to add new regressions/remove fixed etc. http://kernelnewbies.org/known_regressions List of Aces NameRegressions fixed since 21-Jun-2007 Adrian Bunk6 Andi Kleen 4 Andrew Morton 4 Linus Torvalds 4 Al Viro3 Jens Axboe 3 Tejun Heo 3 David Woodhouse2 Hugh Dickins 2 Unclassified Subject : 2.6.23-rc1-git3 init failure References : http://lkml.org/lkml/2007/7/26/467 Last known good : ? Submitter : Sid Boyce <[EMAIL PROTECTED]> Caused-By : ? Handled-By : ? Status : unknown Subject : Time Problems with 2.6.23-rc1-gf695baf2 References : http://lkml.org/lkml/2007/7/23/486 Last known good : ? Submitter : Eric Sesterhenn <[EMAIL PROTECTED]> Caused-By : ? Handled-By : ? Status : problem is being debugged IDE Subject : ide problems: 2.6.22-git17 working, 2.6.23-rc1* is not References : http://lkml.org/lkml/2007/7/27/298 Last known good : ? Submitter : dth <[EMAIL PROTECTED]> Caused-By : ? Handled-By : ? Status : unknown Networking Subject : sky2 boot crash in sky2_mac_intr References : http://lkml.org/lkml/2007/7/24/91 Last known good : ? Submitter : Florian Lohoff <[EMAIL PROTECTED]> Caused-By : Handled-By : Stephen Hemminger <[EMAIL PROTECTED]> Status : unknown Subject : New wake ups from sky2 References : http://lkml.org/lkml/2007/7/20/386 Last known good : ? Submitter : Thomas Meyer <[EMAIL PROTECTED]> Caused-By : Stephen Hemminger <[EMAIL PROTECTED]> commit eb35cf60e462491249166182e3e755d3d5d91a28 Handled-By : Stephen Hemminger <[EMAIL PROTECTED]> Status : unknown Regards, Michal -- LOG http://www.stardust.webpages.pl/log/ - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
errors on shutdown with PMP
hi, tejun. i've been using your libata-tj-2.6.22-rc6-20070702 kernel on a centos 4 machine for a while with some 3124's and 3726's. up until today, i hadn't seen any issues. while trying to shut the machine down, this happened: === Jul 27 14:58:44 dell shutdown: shutting down for system halt Jul 27 14:59:15 dell kernel: ata8.00: exception Emask 0x0 SAct 0x1 SErr 0x0 action 0x2 frozen Jul 27 14:59:15 dell kernel: ata8.00: cmd 61/10:00:a7:0a:00/00:00:00:00:00/40 tag 0 cdb 0x0 data 8192 out Jul 27 14:59:15 dell kernel: res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout) Jul 27 14:59:15 dell kernel: ata8.15: hard resetting link Jul 27 14:59:17 dell kernel: ata8.15: SATA link up 3.0 Gbps (SStatus 123 SControl 0) Jul 27 14:59:17 dell kernel: ata8.00: hard resetting link Jul 27 14:59:27 dell kernel: ata8.00: softreset failed (timeout) Jul 27 14:59:27 dell kernel: ata8.00: hard resetting link Jul 27 14:59:28 dell kernel: ata8.00: COMRESET failed (errno=-5) Jul 27 14:59:28 dell kernel: ata8.00: reset failed, giving up Jul 27 14:59:28 dell kernel: ata8.15: hard resetting link Jul 27 14:59:38 dell kernel: ata8.15: softreset failed (timeout) Jul 27 14:59:38 dell kernel: ata8.15: hard resetting link Jul 27 14:59:40 dell kernel: ata8.15: SATA link up 3.0 Gbps (SStatus 123 SControl 0) Jul 27 14:59:40 dell kernel: ata8.00: hard resetting link Jul 27 14:59:50 dell kernel: ata8.00: softreset failed (timeout) Jul 27 14:59:50 dell kernel: ata8.00: hard resetting link Jul 27 14:59:51 dell kernel: ata8.00: COMRESET failed (errno=-5) Jul 27 14:59:51 dell kernel: ata8.00: reset failed, giving up Jul 27 14:59:51 dell kernel: ata8.15: hard resetting link Jul 27 15:00:01 dell kernel: ata8.15: softreset failed (timeout) Jul 27 15:00:01 dell kernel: ata8.15: hard resetting link Jul 27 15:00:03 dell kernel: ata8.15: SATA link up 3.0 Gbps (SStatus 123 SControl 0) Jul 27 15:00:03 dell kernel: ata8.00: hard resetting link Jul 27 15:00:13 dell kernel: ata8.00: softreset failed (timeout) Jul 27 15:00:13 dell kernel: ata8.00: hard resetting link Jul 27 15:00:14 dell kernel: ata8.00: COMRESET failed (errno=-5) Jul 27 15:00:14 dell kernel: ata8.00: reset failed, giving up Jul 27 15:00:14 dell kernel: ata8.00: failed to recover link after 3 tries, disabling Jul 27 15:00:14 dell kernel: ata8.00: disabled Jul 27 15:00:14 dell kernel: ata8: failed to recover PMP, retrying in 5 secs Jul 27 15:00:19 dell kernel: ata8.15: hard resetting link Jul 27 15:00:29 dell kernel: ata8.15: softreset failed (timeout) Jul 27 15:00:29 dell kernel: ata8.15: hard resetting link Jul 27 15:00:32 dell kernel: ata8.15: SATA link up 3.0 Gbps (SStatus 123 SControl 0) Jul 27 15:00:32 dell kernel: ata8.01: hard resetting link Jul 27 15:00:33 dell kernel: ata8.01: SATA link up 3.0 Gbps (SStatus 123 SControl 300) Jul 27 15:00:33 dell kernel: ata8.02: hard resetting link Jul 27 15:00:33 dell kernel: ata8.02: SATA link up 3.0 Gbps (SStatus 123 SControl 300) Jul 27 15:00:33 dell kernel: ata8.03: hard resetting link Jul 27 15:00:34 dell kernel: ata8.03: SATA link up 1.5 Gbps (SStatus 113 SControl 300) Jul 27 15:00:34 dell kernel: ata8.04: hard resetting link Jul 27 15:00:35 dell kernel: ata8.04: SATA link down (SStatus 0 SControl 300) Jul 27 15:00:35 dell kernel: ata8.05: hard resetting link Jul 27 15:00:35 dell kernel: ata8.05: SATA link up 1.5 Gbps (SStatus 113 SControl 300) Jul 27 15:00:35 dell kernel: ata8.01: configured for UDMA/100 Jul 27 15:00:35 dell kernel: ata8.02: configured for UDMA/100 Jul 27 15:00:35 dell kernel: ata8.03: configured for UDMA/100 Jul 27 15:00:35 dell kernel: sd 7:0:0:0: [sdc] Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE,SUGGEST_OK Jul 27 15:00:35 dell kernel: sd 7:0:0:0: [sdc] Sense Key : Aborted Command [current] [descriptor] Jul 27 15:00:35 dell kernel: Descriptor sense data with sense descriptors (in hex): Jul 27 15:00:35 dell kernel: 72 0b 00 00 00 00 00 0c 00 0a 80 00 00 00 00 00 Jul 27 15:00:35 dell kernel: 00 00 00 00 Jul 27 15:00:35 dell kernel: sd 7:0:0:0: [sdc] Add. Sense: No additional sense information Jul 27 15:00:35 dell kernel: end_request: I/O error, dev sdc, sector 2727 Jul 27 15:00:35 dell kernel: ata8: EH complete Jul 27 15:00:35 dell kernel: sd 7:0:0:0: rejecting I/O to offline device Jul 27 15:00:35 dell kernel: Buffer I/O error on device dm-4, logical block 1055 Jul 27 15:00:35 dell kernel: lost page write due to I/O error on dm-4 Jul 27 15:00:35 dell kernel: Aborting journal on device dm-4. Jul 27 15:00:35 dell kernel: journal commit I/O error Jul 27 15:00:36 dell kernel: sd 7:0:1:0: [sdd] 488397168 512-byte hardware sectors (250059 MB) Jul 27 15:00:36 dell kernel: sd 7:0:1:0: [sdd] Write Protect is off Jul 27 15:00:36 dell kernel: sd 7:0:1:0: [sdd] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA Jul 27 15:00:36 dell kernel: sd 7:0:2:0: [sde] 488397168 512-byte hardware sectors (250059 MB) Jul 27 15:00:36 dell kernel: sd 7:0:2:0:
IRQ Delivery Problem for MCP65
Hello, I'm having trouble getting Linux to see any hard drives on an ASUS M2N-X motherboard with an MCP65 (nForce 520) chipset. When the kernel probes the AHCI controllers, it hangs for a minute or so on each one and returns the following; ata1.00: failed to IDENTIFY (I/O error, err_mask=0x4) Thanks in advance for any help you can lend, - Craig Got a little couch potato? Check out fun summer activities for kids. http://search.yahoo.com/search?fr=oni_on_mail&p=summer+activities+for+kids&cs=bz - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
