Re: [PATCH 4/9] enable FSL SATA driver config for Freescale SoCs

2008-01-25 Thread Kumar Gala 
On Thu, 24 Jan 2008, Kim Phillips wrote:

 The mpc8315 shares the same SATA controller as the mpc837x,
 and likelihood is that future SoCs from Freescale will also.

 Signed-off-by: Jerry Huang [EMAIL PROTECTED]
 Signed-off-by: Kim Phillips [EMAIL PROTECTED]
 ---
 Kumar, let me know if you want me to post this to the ata list (I'm
 assuming it's not necessary).

  drivers/ata/Kconfig |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)


applied.

- k
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] [POWERPC] MPC8349E-mITX: introduce localbus and pata nodes

2007-11-27 Thread Kumar Gala 


On Nov 27, 2007, at 9:49 AM, Sergei Shtylyov wrote:


Hello.

Anton Vorontsov wrote:


This patch adds localbus and pata nodes to use CF IDE interface
on MPC8349E-mITX boards.



Patch also adds code to probe localbus.



Signed-off-by: Anton Vorontsov [EMAIL PROTECTED]
---
arch/powerpc/boot/dts/mpc8349emitx.dts|   17 -
arch/powerpc/platforms/83xx/mpc834x_itx.c |   17 +
2 files changed, 33 insertions(+), 1 deletions(-)


diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts b/arch/powerpc/ 
boot/dts/mpc8349emitx.dts

index 5072f6d..7a97068 100644
--- a/arch/powerpc/boot/dts/mpc8349emitx.dts
+++ b/arch/powerpc/boot/dts/mpc8349emitx.dts
@@ -249,6 +249,21 @@
device_type = pci;
};

+   [EMAIL PROTECTED] {
+   #address-cells = 2;
+   #size-cells = 1;
+   compatible = fsl,mpc8349emitx-localbus,


   Board compatible bus?


+fsl,mpc8349e-localbus,
+fsl,pq2pro-localbus;
+   reg = e0005000 d8;
+   ranges = 3 0 f000 210;

-
+   [EMAIL PROTECTED],0 {
+   compatible = fsl,mpc8349emitx-pata, pata-platform;
+   reg = 3 0 10 3 20c 4;
+   ioport-shift = 1;


   Bleh... that shift again. And this is surely not a good name for a
property (where's I/O ports in your case?) -- why not call it reg- 
shift

(well, I'd call it reg-size or reg-stride myself :-)?


I'm coming into this late, but if ioport-shift applies to reg (which I  
think it does) it should really be called reg-shift.  The ePAPR is  
using that property name:


Specifies in bytes how far the discrete device registers are separated  
from each other. The
individual register location is calculated by using following formula:  
“registers address” 

reg-shift. If unspecified the default value is 0.

- k

-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] drivers/ata: add support to Freescale 3.0Gbps SATA Controller

2007-10-10 Thread Kumar Gala 


On Wed, 10 Oct 2007, Li Yang wrote:

 From: Ashish Kalra [EMAIL PROTECTED]

 This patch adds support for Freescale 3.0Gbps SATA Controller supporting
 Native Command Queueing(NCQ), device hotplug, and ATAPI.  This controller
 can be found on MPC8315 and MPC8378.

 Signed-off-by: Ashish Kalra [EMAIL PROTECTED]
 Signed-off-by: Li Yang [EMAIL PROTECTED]
 ---
  drivers/ata/Kconfig|9 +
  drivers/ata/Makefile   |1 +
  drivers/ata/sata_fsl.c | 1505 
 
  drivers/ata/sata_fsl.h |  104 
  4 files changed, 1619 insertions(+), 0 deletions(-)
  create mode 100644 drivers/ata/sata_fsl.c
  create mode 100644 drivers/ata/sata_fsl.h

This patch shouldn't be accepted until we close on the device tree
definition since it impacts the driver.

Also CONFIG_SATA_FSL_FPGA_PCI should be removed since that was just an
internal debug thing.

- k
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] mpc8xx: Only build mpc8xx on arch/ppc

2007-08-22 Thread Kumar Gala 
Currently the mpc8xx ide driver will only work on arch/ppc so only
allow it to be built there.  Also, killed a minor include that isn't
actually used by the driver.

Signed-off-by: Kumar Gala [EMAIL PROTECTED]
---
 drivers/ide/Kconfig  |2 +-
 drivers/ide/ppc/mpc8xx.c |1 -
 2 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/ide/Kconfig b/drivers/ide/Kconfig
index 7adb61b..24ad104 100644
--- a/drivers/ide/Kconfig
+++ b/drivers/ide/Kconfig
@@ -946,7 +946,7 @@ config BLK_DEV_Q40IDE

 config BLK_DEV_MPC8xx_IDE
bool MPC8xx IDE support
-   depends on 8xx  IDE=y  BLK_DEV_IDE=y
+   depends on 8xx  IDE=y  BLK_DEV_IDE=y  !PPC_MERGE
select IDE_GENERIC
help
  This option provides support for IDE on Motorola MPC8xx Systems.
diff --git a/drivers/ide/ppc/mpc8xx.c b/drivers/ide/ppc/mpc8xx.c
index 8859fe2..dab79af 100644
--- a/drivers/ide/ppc/mpc8xx.c
+++ b/drivers/ide/ppc/mpc8xx.c
@@ -32,7 +32,6 @@
 #include asm/mpc8xx.h
 #include asm/mmu.h
 #include asm/processor.h
-#include asm/residual.h
 #include asm/io.h
 #include asm/pgtable.h
 #include asm/ide.h
-- 
1.5.2.4

-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

pata error messages?

2007-08-09 Thread Kumar Gala 
I'm trying to figure out what could cause the following error  
messages.  This is on a PPC host using a ULI 1575 southbridge:


- k

ata5: PATA max UDMA/133 cmd 0xfdfee300 ctl 0xfdfee30a bmdma  
0xfdfee320 irq 6
ata6: PATA max UDMA/133 cmd 0xfdfee310 ctl 0xfdfee31a bmdma  
0xfdfee328 irq 6

ata5.00: ATAPI: SONYDVD RW AW-Q170A, 1.72, max UDMA/66
ata5.00: configured for UDMA/66
ata5.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen
ata5.00: cmd a0/00:00:00:00:20/00:00:00:00:00/a0 tag 0 cdb 0x12 data  
36 in

 res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout)
ata5: soft resetting port
ata5.00: configured for UDMA/66
ata5: EH complete
ata5.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen
ata5.00: cmd a0/00:00:00:00:20/00:00:00:00:00/a0 tag 0 cdb 0x12 data  
36 in

 res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout)
ata5: soft resetting port
ata5.00: configured for UDMA/66
ata5: EH complete
ata5.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen
ata5.00: cmd a0/00:00:00:00:20/00:00:00:00:00/a0 tag 0 cdb 0x12 data  
36 in

 res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout)
ata5: soft resetting port
ata5.00: configured for UDMA/66
ata5: EH complete
ata5.00: limiting speed to UDMA/44:PIO4
ata5.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen
ata5.00: cmd a0/00:00:00:00:20/00:00:00:00:00/a0 tag 0 cdb 0x12 data  
36 in

 res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout)
ata5: soft resetting port
ata5.00: configured for UDMA/44
ata5: EH complete
ata5.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen
ata5.00: cmd a0/00:00:00:00:20/00:00:00:00:00/a0 tag 0 cdb 0x12 data  
36 in

 res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout)
ata5: soft resetting port
ata5.00: configured for UDMA/44
ata5: EH complete
ata5.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen
ata5.00: cmd a0/00:00:00:00:20/00:00:00:00:00/a0 tag 0 cdb 0x12 data  
36 in

 res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout)
ata5: soft resetting port
ata5.00: configured for UDMA/44
ata5: EH complete
ata5.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen
ata5.00: cmd a0/00:00:00:00:20/00:00:00:00:00/a0 tag 0 cdb 0x12 data  
36 in

 res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout)
ata5: soft resetting port
ata5.00: configured for UDMA/44
ata5: EH complete
ata5.00: limiting speed to UDMA/33:PIO4
ata5.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen
ata5.00: cmd a0/00:00:00:00:20/00:00:00:00:00/a0 tag 0 cdb 0x12 data  
36 in

 res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout)
ata5: soft resetting port
ata5.00: configured for UDMA/33
ata5: EH complete
ata5.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen
ata5.00: cmd a0/00:00:00:00:20/00:00:00:00:00/a0 tag 0 cdb 0x12 data  
36 in

 res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout)
ata5: soft resetting port
ata5.00: configured for UDMA/33
ata5: EH complete
ata5.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen
ata5.00: cmd a0/00:00:00:00:20/00:00:00:00:00/a0 tag 0 cdb 0x12 data  
36 in

 res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout)
ata5: soft resetting port
ata5.00: configured for UDMA/33
ata5: EH complete
ata5.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen
ata5.00: cmd a0/00:00:00:00:20/00:00:00:00:00/a0 tag 0 cdb 0x12 data  
36 in

 res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout)
ata5: soft resetting port
ata5.00: configured for UDMA/33
ata5: EH complete
ata5.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen
ata5.00: cmd a0/00:00:00:00:20/00:00:00:00:00/a0 tag 0 cdb 0x12 data  
36 in

 res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout)
ata5: soft resetting port
ata5.00: configured for UDMA/33
ata5: EH complete
ata5.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen
ata5.00: cmd a0/00:00:00:00:20/00:00:00:00:00/a0 tag 0 cdb 0x12 data  
36 in

 res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout)
ata5: soft resetting port
ata5.00: configured for UDMA/33
ata5: EH complete
ata5.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen
ata5.00: cmd a0/00:00:00:00:20/00:00:00:00:00/a0 tag 0 cdb 0x12 data  
36 in

 res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout)
ata5: soft resetting port
ata5.00: configured for UDMA/33
ata5: EH complete
ata5.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen
ata5.00: cmd a0/00:00:00:00:20/00:00:00:00:00/a0 tag 0 cdb 0x12 data  
36 in

 res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout)
ata5: soft resetting port
ata5.00: configured for UDMA/33
ata5: EH complete
ata5.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen
ata5.00: cmd a0/00:00:00:00:20/00:00:00:00:00/a0 tag 0 cdb 0x12 data  
36 in

 res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout)

Re: pata error messages?

2007-08-09 Thread Kumar Gala 


On Aug 9, 2007, at 12:17 PM, Alan Cox wrote:


On Thu, 9 Aug 2007 10:59:12 -0500
Kumar Gala [EMAIL PROTECTED] wrote:


I'm trying to figure out what could cause the following error
messages.  This is on a PPC host using a ULI 1575 southbridge:


I'm still chasing problems with ATAPI DMA on some ALi host bridges.  
I'd

like to say I knew what was going on but the truth is I'm currently
diffing lspci out and staring at spec sheets with little result.


yeah, the ALi spec I have for 1575 is terse at best.

I'd be interested in possible register dumps, I'm not sure if we are  
even setting up the controllers properly or not.


- k
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-25 Thread Kumar Gala 


On Jul 25, 2007, at 11:53 AM, Vitaly Bordug wrote:



This is now very similar to pata_platform.c, they both use
same platform data structure and same resources.

To achieve that, byte_lanes_swapping platform data variable
and platform specified iops removed from that driver. It's fine,
since those were never used anyway.

pata_platform and ide_platform are carrying same driver names,
to easily switch between these drivers, without need to touch
platform code.

Signed-off-by: Anton Vorontsov [EMAIL PROTECTED]
Signed-off-by: Vitaly Bordug [EMAIL PROTECTED]


Out of interest is this something that could exist in pata land?  I  
haven't really been following legacy/ide vs pata lately.


- k
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: compile error if CONFIG_BLOCK not enabled related to linux/ide.h include

2007-07-18 Thread Kumar Gala 


On Jul 18, 2007, at 5:47 AM, Bartlomiej Zolnierkiewicz wrote:



Hi,

On Wednesday 18 July 2007, Kumar Gala wrote:

M:  [EMAIL PROTECTED]
L:  linux-ide@vger.kernel.org

We get the following compile error if CONFIG_BLOCK isn't enabled:

  CC  arch/powerpc/kernel/setup_32.o
In file included from arch/powerpc/kernel/setup_32.c:14:
include/linux/ide.h:558: error: expected specifier-qualifier-list  
before 'request_queue_t'
include/linux/ide.h:696: warning: 'struct request' declared inside  
parameter list
include/linux/ide.h:696: warning: its scope is only this  
definition or declaration, which is probably not what you want
include/linux/ide.h:820: warning: 'struct request' declared inside  
parameter list

include/linux/ide.h:853: error: field 'wrq' has incomplete type
include/linux/ide.h:1205: error: expected ')' before '*' token
make[1]: *** [arch/powerpc/kernel/setup_32.o] Error 1
make: *** [arch/powerpc/kernel] Error 2


include/linux/ide.h is exclusively for IDE subsystem

What I'm trying to figure out is if include/linux/ide.h should be  
wrapped
in a #if defined(CONFIG_IDE) || defined(CONFIG_IDE_MODULE) or if  
there is

some other desired way to handle this.


Plese remove linux/ide.h include, there doesn't seem to be any  
piece of

code in arch/powerpc/kernel/setup_32.c which needs it anyway.


Its needed for:

struct ide_machdep_calls ppc_ide_md;

which gets defined in asm/ide.h which needs linux/ide.h for the defn  
of ide_init_hwif.


- k



-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

compile error if CONFIG_BLOCK not enabled related to linux/ide.h include

2007-07-17 Thread Kumar Gala 
M:  [EMAIL PROTECTED]
L:  linux-ide@vger.kernel.org

We get the following compile error if CONFIG_BLOCK isn't enabled:

  CC  arch/powerpc/kernel/setup_32.o
In file included from arch/powerpc/kernel/setup_32.c:14:
include/linux/ide.h:558: error: expected specifier-qualifier-list before 
'request_queue_t'
include/linux/ide.h:696: warning: 'struct request' declared inside parameter 
list
include/linux/ide.h:696: warning: its scope is only this definition or 
declaration, which is probably not what you want
include/linux/ide.h:820: warning: 'struct request' declared inside parameter 
list
include/linux/ide.h:853: error: field 'wrq' has incomplete type
include/linux/ide.h:1205: error: expected ')' before '*' token
make[1]: *** [arch/powerpc/kernel/setup_32.o] Error 1
make: *** [arch/powerpc/kernel] Error 2

What I'm trying to figure out is if include/linux/ide.h should be wrapped
in a #if defined(CONFIG_IDE) || defined(CONFIG_IDE_MODULE) or if there is
some other desired way to handle this.

This seems to stem from the fact that include/linux/blkdev.h is wrapped in
a CONFIG_BLOCK and thus request_queue_t isn't always defined.

- k


-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] ide: Use inline function for eieio

2007-07-09 Thread Kumar Gala 
Move to using inline function variant of eieio instead of inline assmebly.

Signed-off-by: Kumar Gala [EMAIL PROTECTED]

---
commit ff6ce6329e19cb82ee12447fe16c76c3dae7c1f4
tree ef830cd02624a79d7fa8c33b41f7229ff25a7d77
parent b30083183bf4987c8f7e9a8f753002a7ca5dc084
author Kumar Gala [EMAIL PROTECTED] Tue, 10 Jul 2007 00:13:54 -0500
committer Kumar Gala [EMAIL PROTECTED] Tue, 10 Jul 2007 00:13:54 -0500

 drivers/ide/pci/scc_pata.c |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ide/pci/scc_pata.c b/drivers/ide/pci/scc_pata.c
index 55bc0a3..b9fd2ac 100644
--- a/drivers/ide/pci/scc_pata.c
+++ b/drivers/ide/pci/scc_pata.c
@@ -165,9 +165,9 @@ scc_ide_outbsync(ide_drive_t * drive, u8 addr, unsigned 
long port)
ide_hwif_t *hwif = HWIF(drive);

out_be32((void*)port, addr);
-   __asm__ __volatile__(eieio:::memory);
+   eieio();
in_be32((void*)(hwif-dma_base + 0x01c));
-   __asm__ __volatile__(eieio:::memory);
+   eieio();
 }

 static void
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html