Re: [PATCH 01/14] sata_mv EH fixes

2008-01-25 Thread Jeff Garzik 

Mark Lord wrote:

sata_mv EH fixes.

A hard reset is necessary after hotplug events.
Only clear the error irq bits that were set on entry.

Signed-off-by: Mark Lord <[EMAIL PROTECTED]>

--- old/drivers/ata/sata_mv.c2008-01-24 10:40:11.0 -0500
+++ new/drivers/ata/sata_mv.c2008-01-24 11:11:26.0 -0500
@@ -1437,6 +1437,7 @@
ata_ehi_hotplugged(ehi);
ata_ehi_push_desc(ehi, edma_err_cause & EDMA_ERR_DEV_DCON ?
"dev disconnect" : "dev connect");
+action |= ATA_EH_HARDRESET;
}

if (IS_GEN_I(hpriv)) {
@@ -1465,7 +1466,7 @@
}

/* Clear EDMA now that SERR cleanup done */
-writelfl(0, port_mmio + EDMA_ERR_IRQ_CAUSE_OFS);
+writelfl(~edma_err_cause, port_mmio + EDMA_ERR_IRQ_CAUSE_OFS);


ACK


-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 01/14] sata_mv EH fixes

2008-01-24 Thread Mark Lord 

sata_mv EH fixes.

A hard reset is necessary after hotplug events.
Only clear the error irq bits that were set on entry.

Signed-off-by: Mark Lord <[EMAIL PROTECTED]>

--- old/drivers/ata/sata_mv.c   2008-01-24 10:40:11.0 -0500
+++ new/drivers/ata/sata_mv.c   2008-01-24 11:11:26.0 -0500
@@ -1437,6 +1437,7 @@
ata_ehi_hotplugged(ehi);
ata_ehi_push_desc(ehi, edma_err_cause & EDMA_ERR_DEV_DCON ?
"dev disconnect" : "dev connect");
+   action |= ATA_EH_HARDRESET;
}

if (IS_GEN_I(hpriv)) {
@@ -1465,7 +1466,7 @@
}

/* Clear EDMA now that SERR cleanup done */
-   writelfl(0, port_mmio + EDMA_ERR_IRQ_CAUSE_OFS);
+   writelfl(~edma_err_cause, port_mmio + EDMA_ERR_IRQ_CAUSE_OFS);

if (!err_mask) {
err_mask = AC_ERR_OTHER;
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html