Re: [PATCH 4/4] ide-disk: fix issues found by checkpatch.pl

2008-02-19 Thread Sergei Shtylyov

Bartlomiej Zolnierkiewicz wrote:


There are no changes to the resulting drivers/ide/ide-disk.o binary file
(md5sum-s after and before the patch match).



Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>


Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]>

MBR, Sergei

-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 4/4] ide-disk: fix issues found by checkpatch.pl

2008-02-17 Thread Bartlomiej Zolnierkiewicz
There are no changes to the resulting drivers/ide/ide-disk.o binary file
(md5sum-s after and before the patch match).

Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
 drivers/ide/ide-disk.c |  120 -
 1 file changed, 70 insertions(+), 50 deletions(-)

Index: b/drivers/ide/ide-disk.c
===
--- a/drivers/ide/ide-disk.c
+++ b/drivers/ide/ide-disk.c
@@ -16,8 +16,6 @@
 
 #define IDEDISK_VERSION"1.18"
 
-//#define DEBUG
-
 #include 
 #include 
 #include 
@@ -88,7 +86,7 @@ static void ide_disk_put(struct ide_disk
  *
  * It is called only once for each drive.
  */
-static int lba_capacity_is_ok (struct hd_driveid *id)
+static int lba_capacity_is_ok(struct hd_driveid *id)
 {
unsigned long lba_sects, chs_sects, head, tail;
 
@@ -176,7 +174,8 @@ static void ide_tf_set_cmd(ide_drive_t *
  * __ide_do_rw_disk() issues READ and WRITE commands to a disk,
  * using LBA if supported, or CHS otherwise, to address sectors.
  */
-static ide_startstop_t __ide_do_rw_disk(ide_drive_t *drive, struct request 
*rq, sector_t block)
+static ide_startstop_t __ide_do_rw_disk(ide_drive_t *drive, struct request *rq,
+   sector_t block)
 {
ide_hwif_t *hwif= HWIF(drive);
unsigned int dma= drive->using_dma;
@@ -228,7 +227,8 @@ static ide_startstop_t __ide_do_rw_disk(
tf->device = (block >> 8) & 0xf;
}
} else {
-   unsigned int sect,head,cyl,track;
+   unsigned int sect, head, cyl, track;
+
track = (int)block / drive->sect;
sect  = (int)block % drive->sect + 1;
head  = track % drive->head;
@@ -271,7 +271,8 @@ static ide_startstop_t __ide_do_rw_disk(
  * 1073741822 == 549756 MB or 48bit addressing fake drive
  */
 
-static ide_startstop_t ide_do_rw_disk (ide_drive_t *drive, struct request *rq, 
sector_t block)
+static ide_startstop_t ide_do_rw_disk(ide_drive_t *drive, struct request *rq,
+ sector_t block)
 {
ide_hwif_t *hwif = HWIF(drive);
 
@@ -452,7 +453,7 @@ static void idedisk_check_hpa(ide_drive_
  * in above order (i.e., if value of higher priority is available,
  * reset will be ignored).
  */
-static void init_idedisk_capacity (ide_drive_t  *drive)
+static void init_idedisk_capacity(ide_drive_t *drive)
 {
struct hd_driveid *id = drive->id;
/*
@@ -479,7 +480,7 @@ static void init_idedisk_capacity (ide_d
}
 }
 
-static sector_t idedisk_capacity (ide_drive_t *drive)
+static sector_t idedisk_capacity(ide_drive_t *drive)
 {
return drive->capacity64 - drive->sect0;
 }
@@ -524,10 +525,11 @@ static int proc_idedisk_read_cache
int len;
 
if (drive->id_read)
-   len = sprintf(out,"%i\n", drive->id->buf_size / 2);
+   len = sprintf(out, "%i\n", drive->id->buf_size / 2);
else
-   len = sprintf(out,"(none)\n");
-   PROC_IDE_READ_RETURN(page,start,off,count,eof,len);
+   len = sprintf(out, "(none)\n");
+
+   PROC_IDE_READ_RETURN(page, start, off, count, eof, len);
 }
 
 static int proc_idedisk_read_capacity
@@ -536,8 +538,9 @@ static int proc_idedisk_read_capacity
ide_drive_t*drive = (ide_drive_t *)data;
int len;
 
-   len = sprintf(page,"%llu\n", (long long)idedisk_capacity(drive));
-   PROC_IDE_READ_RETURN(page,start,off,count,eof,len);
+   len = sprintf(page, "%llu\n", (long long)idedisk_capacity(drive));
+
+   PROC_IDE_READ_RETURN(page, start, off, count, eof, len);
 }
 
 static int proc_idedisk_read_smart(char *page, char **start, off_t off,
@@ -551,12 +554,14 @@ static int proc_idedisk_read_smart(char 
char *out = ((char *)val) + (SECTOR_WORDS * 4);
page = out;
do {
-   out += sprintf(out, "%04x%c", le16_to_cpu(*val), (++i & 
7) ? ' ' : '\n');
+   out += sprintf(out, "%04x%c", le16_to_cpu(*val),
+  (++i & 7) ? ' ' : '\n');
val += 1;
} while (i < (SECTOR_WORDS * 2));
len = out - page;
}
-   PROC_IDE_READ_RETURN(page,start,off,count,eof,len);
+
+   PROC_IDE_READ_RETURN(page, start, off, count, eof, len);
 }
 
 static int proc_idedisk_read_sv
@@ -620,12 +625,13 @@ static int set_multcount(ide_drive_t *dr
if (drive->special.b.set_multmode)
return -EBUSY;
 
-   ide_init_drive_cmd (&rq);
+   ide_init_drive_cmd(&rq);
rq.cmd_type = REQ_TYPE_ATA_TASKFILE;
 
drive->mult_req = arg;
drive->special.b.set_multmode = 1;
-   (void) ide_do_drive_cmd (drive, &rq, ide_wait);
+   (void)ide_do_drive_cmd(drive, &rq, ide_wait);
+
return (drive->mult_count == arg) ? 0 : -EIO;
 }
 
@