[PATCH v2 3/4] [POWERPC] MPC8349E-mITX: introduce localbus and pata nodes

2007-12-04 Thread Anton Vorontsov 
This patch adds localbus and pata nodes to use CF IDE interface
on MPC8349E-mITX boards.

Patch also adds code to probe localbus.

Signed-off-by: Anton Vorontsov [EMAIL PROTECTED]
---
 arch/powerpc/boot/dts/mpc8349emitx.dts|   18 +-
 arch/powerpc/platforms/83xx/mpc834x_itx.c |   17 +
 2 files changed, 34 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts 
b/arch/powerpc/boot/dts/mpc8349emitx.dts
index 5072f6d..c459b0a 100644
--- a/arch/powerpc/boot/dts/mpc8349emitx.dts
+++ b/arch/powerpc/boot/dts/mpc8349emitx.dts
@@ -249,6 +249,22 @@
device_type = pci;
};
 
+   [EMAIL PROTECTED] {
+   #address-cells = 2;
+   #size-cells = 1;
+   compatible = fsl,mpc8349emitx-localbus,
+fsl,mpc8349e-localbus,
+fsl,pq2pro-localbus;
+   reg = e0005000 d8;
+   ranges = 3 0 f000 210;
 
-
+   [EMAIL PROTECTED],0 {
+   compatible = fsl,mpc8349emitx-pata, ata-generic;
+   reg = 3 0 10 3 20c 4;
+   reg-shift = 1;
+   pio-mode = 6;
+   interrupts = 17 8;
+   interrupt-parent = ipic;
+   };
+   };
 };
diff --git a/arch/powerpc/platforms/83xx/mpc834x_itx.c 
b/arch/powerpc/platforms/83xx/mpc834x_itx.c
index aa76819..ea5f176 100644
--- a/arch/powerpc/platforms/83xx/mpc834x_itx.c
+++ b/arch/powerpc/platforms/83xx/mpc834x_itx.c
@@ -23,6 +23,7 @@
 #include linux/delay.h
 #include linux/seq_file.h
 #include linux/root_dev.h
+#include linux/of_platform.h
 
 #include asm/system.h
 #include asm/atomic.h
@@ -37,6 +38,22 @@
 
 #include mpc83xx.h
 
+static struct of_device_id mpc834x_itx_ids[] = {
+   { .name = localbus, },
+   {},
+};
+
+static int __init mpc834x_itx_declare_of_platform_devices(void)
+{
+   if (!machine_is(mpc834x_itx))
+   return 0;
+
+   of_platform_bus_probe(NULL, mpc834x_itx_ids, NULL);
+
+   return 0;
+}
+device_initcall(mpc834x_itx_declare_of_platform_devices);
+
 /* 
  *
  * Setup the architecture
-- 
1.5.2.2

-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 3/4] [POWERPC] MPC8349E-mITX: introduce localbus and pata nodes

2007-12-04 Thread Olof Johansson 
Hi,

On Tue, Dec 04, 2007 at 08:07:26PM +0300, Anton Vorontsov wrote:
 diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts 
 b/arch/powerpc/boot/dts/mpc8349emitx.dts
 index 5072f6d..c459b0a 100644
 --- a/arch/powerpc/boot/dts/mpc8349emitx.dts
 +++ b/arch/powerpc/boot/dts/mpc8349emitx.dts
 @@ -249,6 +249,22 @@
   device_type = pci;
   };
  
 + [EMAIL PROTECTED] {
 + #address-cells = 2;
 + #size-cells = 1;
 + compatible = fsl,mpc8349emitx-localbus,
 +  fsl,mpc8349e-localbus,
 +  fsl,pq2pro-localbus;
 + reg = e0005000 d8;
 + ranges = 3 0 f000 210;
  
 -
 + [EMAIL PROTECTED],0 {

What's the ,0 for?

 + compatible = fsl,mpc8349emitx-pata, ata-generic;
 + reg = 3 0 10 3 20c 4;
 + reg-shift = 1;
 + pio-mode = 6;
 + interrupts = 17 8;
 + interrupt-parent = ipic;
 + };
 + };
  };
 diff --git a/arch/powerpc/platforms/83xx/mpc834x_itx.c 
 b/arch/powerpc/platforms/83xx/mpc834x_itx.c
 index aa76819..ea5f176 100644
 --- a/arch/powerpc/platforms/83xx/mpc834x_itx.c
 +++ b/arch/powerpc/platforms/83xx/mpc834x_itx.c
 @@ -23,6 +23,7 @@
  #include linux/delay.h
  #include linux/seq_file.h
  #include linux/root_dev.h
 +#include linux/of_platform.h
  
  #include asm/system.h
  #include asm/atomic.h
 @@ -37,6 +38,22 @@
  
  #include mpc83xx.h
  
 +static struct of_device_id mpc834x_itx_ids[] = {
 + { .name = localbus, },
 + {},
 +};

Please add the compatible field here (fsl,pq2pro-localbus should do
just fine), instead of the name.

(Sorry for not spotting this sooner)


-Olof

-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 3/4] [POWERPC] MPC8349E-mITX: introduce localbus and pata nodes

2007-12-04 Thread Scott Wood 

Olof Johansson wrote:

Hi,

On Tue, Dec 04, 2007 at 08:07:26PM +0300, Anton Vorontsov wrote:

diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts 
b/arch/powerpc/boot/dts/mpc8349emitx.dts
index 5072f6d..c459b0a 100644
--- a/arch/powerpc/boot/dts/mpc8349emitx.dts
+++ b/arch/powerpc/boot/dts/mpc8349emitx.dts
@@ -249,6 +249,22 @@
device_type = pci;
};
 
+	[EMAIL PROTECTED] {

+   #address-cells = 2;
+   #size-cells = 1;
+   compatible = fsl,mpc8349emitx-localbus,
+fsl,mpc8349e-localbus,
+fsl,pq2pro-localbus;
+   reg = e0005000 d8;
+   ranges = 3 0 f000 210;
 
-

+   [EMAIL PROTECTED],0 {


What's the ,0 for?


chipselect 3, offset 0.

-Scott
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 3/4] [POWERPC] MPC8349E-mITX: introduce localbus and pata nodes

2007-12-04 Thread Anton Vorontsov 
On Tue, Dec 04, 2007 at 01:16:57PM -0600, Olof Johansson wrote:
 Hi,
 
 On Tue, Dec 04, 2007 at 08:07:26PM +0300, Anton Vorontsov wrote:
  diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts 
  b/arch/powerpc/boot/dts/mpc8349emitx.dts
  index 5072f6d..c459b0a 100644
[...]
  +static struct of_device_id mpc834x_itx_ids[] = {
  +   { .name = localbus, },
  +   {},
  +};
 
 Please add the compatible field here (fsl,pq2pro-localbus should do
 just fine), instead of the name.

Done, thanks.

- - - -
From: Anton Vorontsov [EMAIL PROTECTED]
Subject: [PATCH v2.1] [POWERPC] MPC8349E-mITX: introduce localbus and pata nodes

This patch adds localbus and pata nodes to use CF IDE interface
on MPC8349E-mITX boards.

Patch also adds code to probe localbus.

Signed-off-by: Anton Vorontsov [EMAIL PROTECTED]
---
 arch/powerpc/boot/dts/mpc8349emitx.dts|   18 +-
 arch/powerpc/platforms/83xx/mpc834x_itx.c |   17 +
 2 files changed, 34 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts 
b/arch/powerpc/boot/dts/mpc8349emitx.dts
index 5072f6d..c459b0a 100644
--- a/arch/powerpc/boot/dts/mpc8349emitx.dts
+++ b/arch/powerpc/boot/dts/mpc8349emitx.dts
@@ -249,6 +249,22 @@
device_type = pci;
};
 
+   [EMAIL PROTECTED] {
+   #address-cells = 2;
+   #size-cells = 1;
+   compatible = fsl,mpc8349emitx-localbus,
+fsl,mpc8349e-localbus,
+fsl,pq2pro-localbus;
+   reg = e0005000 d8;
+   ranges = 3 0 f000 210;
 
-
+   [EMAIL PROTECTED],0 {
+   compatible = fsl,mpc8349emitx-pata, ata-generic;
+   reg = 3 0 10 3 20c 4;
+   reg-shift = 1;
+   pio-mode = 6;
+   interrupts = 17 8;
+   interrupt-parent = ipic;
+   };
+   };
 };
diff --git a/arch/powerpc/platforms/83xx/mpc834x_itx.c 
b/arch/powerpc/platforms/83xx/mpc834x_itx.c
index aa76819..4797850 100644
--- a/arch/powerpc/platforms/83xx/mpc834x_itx.c
+++ b/arch/powerpc/platforms/83xx/mpc834x_itx.c
@@ -23,6 +23,7 @@
 #include linux/delay.h
 #include linux/seq_file.h
 #include linux/root_dev.h
+#include linux/of_platform.h
 
 #include asm/system.h
 #include asm/atomic.h
@@ -37,6 +38,22 @@
 
 #include mpc83xx.h
 
+static struct of_device_id mpc834x_itx_ids[] = {
+   { .compatible = fsl,pq2pro-localbus, },
+   {},
+};
+
+static int __init mpc834x_itx_declare_of_platform_devices(void)
+{
+   if (!machine_is(mpc834x_itx))
+   return 0;
+
+   of_platform_bus_probe(NULL, mpc834x_itx_ids, NULL);
+
+   return 0;
+}
+device_initcall(mpc834x_itx_declare_of_platform_devices);
+
 /* 
  *
  * Setup the architecture
-- 
1.5.2.2

-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 3/4] [POWERPC] MPC8349E-mITX: introduce localbus and pata nodes

2007-12-04 Thread Olof Johansson 
On Tue, Dec 04, 2007 at 10:45:31PM +0300, Anton Vorontsov wrote:
 This patch adds localbus and pata nodes to use CF IDE interface
 on MPC8349E-mITX boards.
 
 Patch also adds code to probe localbus.
 
 Signed-off-by: Anton Vorontsov [EMAIL PROTECTED]

Acked-by: Olof Johansson [EMAIL PROTECTED]


-Olof
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html