Re: [regression] 2.6.23 sata_mv EH updates broke my 7042 controller

2007-10-02 Thread Jeff Garzik

Olof Johansson wrote:

On Mon, Oct 01, 2007 at 06:37:44PM -0400, Jeff Garzik wrote:

Olof Johansson wrote:

Hardware config in my case:
Highpoint 2310 controller
PPC (big endian)
WD Raptor disk
Works fine with the other controller I've been using (SIL24), and works
fine if I revert the driver.
It also works fine if I disable the IOMMU. This would point towards
either a stale dma mapping, or a missing setup of one.
Not being much at home in the SATA drivers I could keep digging but I
figured I'd bring it up first in case it rings a bell for someone.
The IOMMU data point is certainly interesting.  Nothing jumps out on a 
re-review of the patch, so keep digging and let us know ;-)


Looks like it's caused by enabling vmerge (which tends to be on for the
common PPC defconfigs). If I disable it, things look OK.

Perhaps the Marvell controller doesn't like requests larger than 64K,
or wrapping some boundary. Do you have access to erratas/docs?

I have verified it on a powermac now as well (had a quick scare that it
might have been some problem with the PA Semi IOMMU, but no).


FWIW:  I just tried the 6042 on my AMD64 platform with iommu=force, and 
was unable to reproduce any trouble.


You could try changing MV_DMA_BOUNDARY to 0xU and see what happens.

I'll also look through my errata, to see what is different between 6042 
and 7042, if anything.


Jeff


-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[regression] 2.6.23 sata_mv EH updates broke my 7042 controller

2007-10-01 Thread Olof Johansson
Hi,

I just pulled out my Marvell 7042 SATA controller here to give it a spin
and noticed that it no longer worked (i.e. init segvs when loading from
it), etc. 2.6.22 is fine.

Bisecting (just the file drivers/ata/sata_mv.c) resulted in
bdd4dddee325a7dce3e84cf48201a06aa8508aa4 popping out as the culprit
(file version 4537deb5e90b717a725b3d74b58b4bb1d28443d0 is fine).

Just for sanity checking: Has anyone else used 7042/6042 with the current
mainline driver?

Hardware config in my case:
Highpoint 2310 controller
PPC (big endian)
WD Raptor disk

Works fine with the other controller I've been using (SIL24), and works
fine if I revert the driver.

It also works fine if I disable the IOMMU. This would point towards
either a stale dma mapping, or a missing setup of one.

Not being much at home in the SATA drivers I could keep digging but I
figured I'd bring it up first in case it rings a bell for someone.


-Olof
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [regression] 2.6.23 sata_mv EH updates broke my 7042 controller

2007-10-01 Thread Jeff Garzik

Olof Johansson wrote:

Hi,

I just pulled out my Marvell 7042 SATA controller here to give it a spin
and noticed that it no longer worked (i.e. init segvs when loading from
it), etc. 2.6.22 is fine.

Bisecting (just the file drivers/ata/sata_mv.c) resulted in
bdd4dddee325a7dce3e84cf48201a06aa8508aa4 popping out as the culprit
(file version 4537deb5e90b717a725b3d74b58b4bb1d28443d0 is fine).

Just for sanity checking: Has anyone else used 7042/6042 with the current
mainline driver?


The update was tested extensively on 6042.  I have a 7042, but haven't 
found a compatible PCI slot here.




Hardware config in my case:
Highpoint 2310 controller
PPC (big endian)
WD Raptor disk

Works fine with the other controller I've been using (SIL24), and works
fine if I revert the driver.

It also works fine if I disable the IOMMU. This would point towards
either a stale dma mapping, or a missing setup of one.

Not being much at home in the SATA drivers I could keep digging but I
figured I'd bring it up first in case it rings a bell for someone.


The IOMMU data point is certainly interesting.  Nothing jumps out on a 
re-review of the patch, so keep digging and let us know ;-)


Jeff


-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [regression] 2.6.23 sata_mv EH updates broke my 7042 controller

2007-10-01 Thread Olof Johansson
On Mon, Oct 01, 2007 at 06:37:44PM -0400, Jeff Garzik wrote:
 Olof Johansson wrote:
 Hardware config in my case:
 Highpoint 2310 controller
 PPC (big endian)
 WD Raptor disk
 Works fine with the other controller I've been using (SIL24), and works
 fine if I revert the driver.
 It also works fine if I disable the IOMMU. This would point towards
 either a stale dma mapping, or a missing setup of one.
 Not being much at home in the SATA drivers I could keep digging but I
 figured I'd bring it up first in case it rings a bell for someone.

 The IOMMU data point is certainly interesting.  Nothing jumps out on a 
 re-review of the patch, so keep digging and let us know ;-)

Looks like it's caused by enabling vmerge (which tends to be on for the
common PPC defconfigs). If I disable it, things look OK.

Perhaps the Marvell controller doesn't like requests larger than 64K,
or wrapping some boundary. Do you have access to erratas/docs?

I have verified it on a powermac now as well (had a quick scare that it
might have been some problem with the PA Semi IOMMU, but no).


-Olof
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html