Re: [PATCH 11/11v2] ata: fix sparse warnings in pata_legacy.c
Harvey Harrison wrote: Use ld_qdi and ld_winbond to avoid shadowing static int variables qdi and winbond. The ld_ prefix refers to legacy_data. drivers/ata/pata_legacy.c:777:21: warning: symbol 'qdi' shadows an earlier one drivers/ata/pata_legacy.c:128:12: originally declared here drivers/ata/pata_legacy.c:811:21: warning: symbol 'qdi' shadows an earlier one drivers/ata/pata_legacy.c:128:12: originally declared here drivers/ata/pata_legacy.c:848:21: warning: symbol 'qdi' shadows an earlier one drivers/ata/pata_legacy.c:128:12: originally declared here drivers/ata/pata_legacy.c:882:21: warning: symbol 'qdi' shadows an earlier one drivers/ata/pata_legacy.c:128:12: originally declared here drivers/ata/pata_legacy.c:1040:21: warning: symbol 'winbond' shadows an earlier one drivers/ata/pata_legacy.c:129:12: originally declared here Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Alan Cox's suggestion of using a ld_ prefix incorporated. applied - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 11/11v2] ata: fix sparse warnings in pata_legacy.c
On Thu, 14 Feb 2008 09:36:32 -0800 Harvey Harrison <[EMAIL PROTECTED]> wrote: > Use ld_qdi and ld_winbond to avoid shadowing static int > variables qdi and winbond. The ld_ prefix refers to > legacy_data. > > drivers/ata/pata_legacy.c:777:21: warning: symbol 'qdi' shadows an earlier one > drivers/ata/pata_legacy.c:128:12: originally declared here > drivers/ata/pata_legacy.c:811:21: warning: symbol 'qdi' shadows an earlier one > drivers/ata/pata_legacy.c:128:12: originally declared here > drivers/ata/pata_legacy.c:848:21: warning: symbol 'qdi' shadows an earlier one > drivers/ata/pata_legacy.c:128:12: originally declared here > drivers/ata/pata_legacy.c:882:21: warning: symbol 'qdi' shadows an earlier one > drivers/ata/pata_legacy.c:128:12: originally declared here > drivers/ata/pata_legacy.c:1040:21: warning: symbol 'winbond' shadows an > earlier one > drivers/ata/pata_legacy.c:129:12: originally declared here > > Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> Acked-by: Alan Cox <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html