Re: [PATCH 12/13] ide: move drive-using_dma check to callers of -dma_host_on method

2007-11-13 Thread Sergei Shtylyov 

Bartlomiej Zolnierkiewicz wrote:


Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]


Acked-by: Sergei Shtylyov [EMAIL PROTECTED]

MBR, Sergei


Index: b/drivers/ide/ide-dma.c
===
--- a/drivers/ide/ide-dma.c
+++ b/drivers/ide/ide-dma.c
@@ -470,7 +470,7 @@ EXPORT_SYMBOL(ide_dma_off);
 
 void ide_dma_host_on(ide_drive_t *drive)

 {
-   if (drive-using_dma) {
+   if (1) {


   Why so?


ide_hwif_t *hwif= HWIF(drive);
u8 unit = (drive-select.b.unit  0x01);
u8 dma_stat = hwif-INB(hwif-dma_status);


WBR, Sergei
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 12/13] ide: move drive-using_dma check to callers of -dma_host_on method

2007-11-13 Thread Bartlomiej Zolnierkiewicz 
On Tuesday 13 November 2007, Sergei Shtylyov wrote:
 Bartlomiej Zolnierkiewicz wrote:
 
  Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
 
 Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
 
 MBR, Sergei
 
  Index: b/drivers/ide/ide-dma.c
  ===
  --- a/drivers/ide/ide-dma.c
  +++ b/drivers/ide/ide-dma.c
  @@ -470,7 +470,7 @@ EXPORT_SYMBOL(ide_dma_off);
   
   void ide_dma_host_on(ide_drive_t *drive)
   {
  -   if (drive-using_dma) {
  +   if (1) {
 
 Why so?

Just not to move the code around (because it vanishes in patch #13/13).

  ide_hwif_t *hwif= HWIF(drive);
  u8 unit = (drive-select.b.unit  0x01);
  u8 dma_stat = hwif-INB(hwif-dma_status);
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html